From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nick Helm Newsgroups: gmane.emacs.bugs Subject: bug#28843: 26.0.90; gnus kills unsaved message buffer Date: Wed, 08 Nov 2017 15:28:50 +1300 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510108578 1878 195.159.176.226 (8 Nov 2017 02:36:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2017 02:36:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (darwin) To: 28843@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 08 03:36:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCGDt-0000Ke-D1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 03:36:13 +0100 Original-Received: from localhost ([::1]:56668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCGE0-0004q1-Ow for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Nov 2017 21:36:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCG7z-0000fc-5v for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:30:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCG7v-0005Yv-Vk for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:30:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCG7v-0005Y4-JK for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCG7u-0008OO-DQ; Tue, 07 Nov 2017 21:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nick Helm Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 08 Nov 2017 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28843 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 28843-submit@debbugs.gnu.org id=B28843.151010814832162 (code B ref 28843); Wed, 08 Nov 2017 02:30:02 +0000 Original-Received: (at 28843) by debbugs.gnu.org; 8 Nov 2017 02:29:08 +0000 Original-Received: from localhost ([127.0.0.1]:57312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCG71-0008Me-R8 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 21:29:08 -0500 Original-Received: from mail-me1aus01on0097.outbound.protection.outlook.com ([104.47.116.97]:45120 helo=AUS01-ME1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCG6z-0008M4-5A for 28843@debbugs.gnu.org; Tue, 07 Nov 2017 21:29:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenpointcomms.onmicrosoft.com; s=selector1-tenpoint-co-nz; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qt720fvNYqxRfOGYlBe5LhDsIbvL0LsospdAzcBPi8k=; b=iL8zntQME4dnEDNprY8JGSWcQ5QVwqb9fYfVaohWpUCAJOUIjG1CO9VJrjDroGhD00UbMv4gPtPk3IC3/mP1okz1IoHCK7naqVlr7x0mS+wIoHBxbFb5OmuxUjs7I937E11EaAPIai2F6OXFnpv+okVOVxN39k8At7VEw3J9WaY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=nick@tenpoint.co.nz; Original-Received: from oberon.local (125.239.172.252) by SYXPR01MB1070.ausprd01.prod.outlook.com (10.169.175.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 02:28:53 +0000 In-Reply-To: (Nick Helm's message of "Thu, 26 Oct 2017 13:52:13 +1300") X-Originating-IP: [125.239.172.252] X-ClientProxiedBy: ME1PR01CA0118.ausprd01.prod.outlook.com (10.171.8.155) To SYXPR01MB1070.ausprd01.prod.outlook.com (10.169.175.11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83451fb4-6df7-43a1-5da4-08d52650747d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603249); SRVR:SYXPR01MB1070; X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB1070; 3:V58JKGgabqohx3A2zL/rrNbXTTIO3UgWFN5dvOC4r52f1fHhTdYQm/hAMm6ZtevyTl2rWL09yOBERLaINT1NEPtKL3KDjSxVFBpECoInzW0ALKDDzINvmmpc5SIjaFnyAzIExuHWU56+UjSYP9Q+Uldx56Kdhc161pbnI2c2N418itMqfncCPUaaCaubc+swrByqgbmnR9MaJENwh7e1SF6rsScpMCD8zyg+Jk6Nh7J2dOOu75QnbE3tHfiyKs+0; 25:/Ww+hoElfXMsUcyb2oSr0dyc3QSwfHBji3COOggRn2n8bFF77LRXqMewxHJ7t6MspJaAr6e495BgP3pBqB3KI38VR9wac5aLV+CC8/h/DfbD3kHqh/Bw7Z5p203/0S9Refv7M1QLblUCfwjl4ADANBhtMiLneLi9V5ebYXQufDBLNVkk/0AYy5qoLwyAaqKOLbzg0Tgtz4Eij8NUr9iJfv+j5LyTS/o7FuFnJSoYwEqJzY/DCAnzKEOPB6UqCXGFMWLrLnywgH9xO5belDGv5B15XeZj6OogdIfvp/OYB7cpqdBqkqGlhhzh34EInVl+qufGZY6aF2MDGW3gHyoawg==; 31:ishfTWWG2AdPtJDEb+jOzLj0dKsS3ESCxYV7bpMCbpQr28dtbMvq+RsC6A9O/hWI1JS0oRyJb6PIjZx3hKtfEWMMleBVNAzH0kRZttpksLsSTjRi7gV+WOA0AAa2qg0ZzeqOpVwQPjy4tOShiiAZBkMKQdiGjOAPENOTxRA6/nGOO+quvT9ptKbLb74FtbcPVo53MquwIXO/1VdRmgIN5xlXP4NvzFC7meolMp4rB X-MS-TrafficTypeDiagnostic: SYXPR01MB1070: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(3231021)(6041248)(20161123564025)(2016111802025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(6043046)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SYXPR01MB1070; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SYXPR01MB1070; X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB1070; 4:Hxb8nk4xmRE5ug3ly3TQwoQL+c20jo15DWyQS8mwIeOoQdy0GrOX6VKJryFBgVJ3fUOrOMQG0PTC0wFPrHr3hYpDZPLv2eKTTIHExk1wpuMFFGI2Ce7Y8IioK3g1vD11wqQJuGrtZY8b0S/Aexeselfom79jiGrFSosaqo71vfDqPx4kup116/q1YJbld074CD3u8FtdjXuCyq8oyxQnKlWOdfnQsCUt4vKx1nCVO/Ll+WAQ16H/2UWS3M3EY1gPPIuWXQPLbjDV/C92oHb7CQ== X-Forefront-PRVS: 0485417665 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(39830400002)(376002)(346002)(199003)(377424004)(189002)(24454002)(5423002)(81156014)(2906002)(316002)(16586007)(58126008)(81166006)(6916009)(8936002)(8676002)(36756003)(305945005)(6246003)(5003940100001)(5660300001)(42882006)(7736002)(6116002)(478600001)(2950100002)(47776003)(15650500001)(54356999)(50986999)(76176999)(3846002)(6512007)(101416001)(66066001)(83506002)(33646002)(189998001)(53936002)(25786009)(106356001)(105586002)(2361001)(2351001)(48376002)(16526018)(68736007)(86362001)(50466002)(229853002)(4001150100001)(97736004)(74482002)(6486002)(6506006); DIR:OUT; SFP:1102; SCL:1; SRVR:SYXPR01MB1070; H:oberon.local; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: tenpoint.co.nz does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB1070; 23:mRGYCMPtbuL6oRfpNUrgxWatyiqx0muG2aU3duhhve7AS1QefNtDEtZFZwroEd7dYfCiHEAAxWzQm06Nuho2Url8uquvaFzJ3vl8UQt5GamUdYHZ7gYvKQ0YJZDMdKQbRA9P8XNdAI6VFpGHv/IoUCumw1OBUcfqx+FNaRtQHuqZLpnDmYBKLhVFcCkmczHBc3gX/gLfkjuZ99vI6q69onYvRmPKXbpsWbsPq6hoYBesxnKFw2qvIILOUX3eXX8eYhWScnJqHF1UskrR+37B34H9Vg3YT7V0Bspu0Ww89KvcHNrr9sgnctK78vAuY3kU8NdYSGNL5ZfADu0EYxwLOiej2zXaKCy3T+9b66SltC4ElW3kwtjov+TfaOYzTecZszM6rDqJQbtV/6hFlOcOXwxsySCAGF4Mf+fJf6fIfGnrRPtt1Ut4VAlPnTOLGYwhU2xwLz+dgaFf6XaNB3r2juLgioum2vixUhck4yHFSIgEUzA0J7499DKD1R/prVGeSV5bccNuNJvjfwiwdDZPlLZlB6qa/OtVHnlI2TERXMQNJhSn4K9F6ZQyVnNiRs5lw1I4iAyfXfFuzUJUBNTQmZAmUFXoEqOlGjvCzHPn2srA4uMvSrRFFM9GqrhAAkNJYdpJlgqL7WymA1okTrPRJPNO/vng0OFUToCpI6WnYcLyjqtsg+wRADDsMU8qIXPawYamBgk/L2i/Ekb8g4SDC6mwqeMII8C6oOTLJN95qeHyI0yLTtsO//4up5U/chg3cC8FJWEuCr/K5gwypU7ol/fUDUUW Bs6TgLReyIymSh0y6QEw8UTOq0V9aiDj4bXNR2pti1lveA X-Microsoft-Exchange-Diagnostics: 1; SYXPR01MB1070; 6:Pha122egkOQ6vavw2aCgzFcc5wtKFIcdcLEbrjbxRmcWj74fhoP/CW1Uqb4Y0Q2riv2xlRk1z1D57zKTN3AMXC6AmhUbCG60AjfQ2+we5sZIs3UloPEGCRf4ydcZegpWC8B7r76dcrDiPw6imf84e3RaD9mQOXpFGZfjxedx9StEO0WW9TdBH0v48KJ2Jeun+EhMfaEsuajFCLu9eKMqgo9kPSV686sojUTmir1xlnl+vv739dSRFOJrCgWx5d2utTBBz23iDxUMKXS+BCcyqqdNBrnIwrQX2qMRVjiGlEW/gJLbYTYoEmxIKycZ425j3KdzBqkDN666jI7OoFpPdLxWam0ya1L9/hmHXs89BUE=; 5:0/T40qyJEIAQVYj444Bp2VYdQqf+9BT8SKHeGL2pLWL+jk2bo9tFwbkxJHXUQijwkd6ZJxJPqFHCFzXuve0+A6XVZDw9Xt5048W+dFZOdqBtP4RKt1bfEOmuXub5NI2egf82onLNuL8ma+uOpgYVMcMAEGRs1822MyyN7/gqaOs=; 24:ON5fW3BMeQvQVlHLrBUfS4a7j8uqo6pE/6lOMblKCF5LqPFF3q1+4YoVvTzuenRGTYWengF7p8L/nG3Kpwf33XYe/Cv2V6cMq2FjG2hMREQ=; 7:RHDY6SEuJfKInQExlMNUQcfLXfuXzai02bHROkM2TfN7VtE0pjTiehsEhpm7SEHcRMTmqB1UDgk04HDetYohjeV2I7EdzmUPLbQRUIIyG3CllMUoqGbs6+ssec0B3+r5XPWeSj32ePoiuFxLS8AJyPpDyIXNivS9NMn0mvcYzTsig11Y1AXYw84+q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: tenpoint.co.nz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 02:28:53.4061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83451fb4-6df7-43a1-5da4-08d52650747d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ed686f26-19e8-407b-91d0-7364c1c6f5cf X-MS-Exchange-Transport-CrossTenantHeadersStamped: SYXPR01MB1070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139593 Archived-At: On Thu, 26 Oct 2017 at 13:52:13 +1300, Nick Helm wrote: > On Sun, 15 Oct 2017 at 20:46:25 +1300, Nick Helm wrote: > >> Gnus exits, and the unsaved message buffer dies with it, without prompts >> to save. > > It seems the behaviour is intentional ... This commit changed > `gnus-clear-system' to include this: > > #+begin_src emacs-lisp > ;; Kill Gnus buffers. > (do-auto-save t) > (dolist (buffer (gnus-buffers)) > (when (gnus-buffer-exists-p buffer) > (with-current-buffer buffer > (set-buffer-modified-p nil) > (when (local-variable-p 'kill-buffer-hook) > (setq kill-buffer-hook nil)))) > (gnus-kill-buffer buffer)) > #+end_src > > So gnus is at least auto-saving draft messages before zapping them. > > Is there a better way to do this though? I think the user should at > least have some warning that an unsaved buffer is about to be > automatically killed. One solution (though not a very good one IMHO) would be to make the auto-save depend on the user's value of guns-interactive-exit. For example: --- a/lisp/gnus/gnus-start.el 2017-10-26 12:49:43.000000000 +1300 +++ b/lisp/gnus/gnus-start.el 2017-10-26 12:45:12.000000000 +1300 @@ -731,11 +731,12 @@ (kill-buffer (get-file-buffer (gnus-newsgroup-kill-file nil)))) (gnus-kill-buffer nntp-server-buffer) ;; Kill Gnus buffers. - (do-auto-save t) (dolist (buffer (gnus-buffers)) (when (gnus-buffer-exists-p buffer) (with-current-buffer buffer - (set-buffer-modified-p nil) + (unless gnus-interactive-exit + (do-auto-save t t) + (set-buffer-modified-p nil)) (when (local-variable-p 'kill-buffer-hook) (setq kill-buffer-hook nil)))) (gnus-kill-buffer buffer))