From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Re: Review request (compilation-error-regexp-alist-alist) Date: Tue, 29 Oct 2019 02:33:16 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="89062"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 29 00:34:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPEWP-000Myk-E5 for ged-emacs-devel@m.gmane.org; Tue, 29 Oct 2019 00:34:02 +0100 Original-Received: from localhost ([::1]:45464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPEWO-0006Hg-2Y for ged-emacs-devel@m.gmane.org; Mon, 28 Oct 2019 19:34:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57715) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPEWH-0006HT-Id for emacs-devel@gnu.org; Mon, 28 Oct 2019 19:33:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPEWF-0007dP-KX for emacs-devel@gnu.org; Mon, 28 Oct 2019 19:33:53 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57989) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPEWD-0007cK-Ds for emacs-devel@gnu.org; Mon, 28 Oct 2019 19:33:50 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 41A7D21E90; Mon, 28 Oct 2019 19:33:48 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 19:33:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=9VZ2J3RdxxxBjzPHdO8D927jcd jMKu/SYHQ76FPJA7g=; b=eUZXp4aE2Luyu7Txep9JIksdbMKlO4fGWoxKmpSMkl JXnl6kWFgvWjr14MtqDec4kJ+qW6+d9RHinL48jgDny4A6DI+H+YSneXTiYgmW/v FMtDGwKfo+JcZgToLJxZ6EBUFZQezt0woRHHMRDwVC1B0ipHx60QVpl2LtmvUxru 5rIShSjScbDOgBlLZCXHBi6m4IFUiWq12jxYcd373FF34c/ZXgO3sRDxg3RknHni fGY5r/VswJX/9WpVt4WhAuxkELWBo0730t7FmCI8F897zptV88mILAwr5zjDZE7g 3QN9GA4CEZ4aOe5oKlKguYnkgN5wQ0DcmNf2d8pJhcOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9VZ2J3 RdxxxBjzPHdO8D927jcdjMKu/SYHQ76FPJA7g=; b=ii4sIMzjG27w+n71LZRChe Z71TizpsFv1neyZI/Luswm2hdD0d3V2rlMwnx5ZNNXYMEp4sVcHxFSW6JYuOS+D3 Q6Qzbu1lABPR2eiEIPcZy93aZK1wv7E/1ppftrlulwu3Z+LXxBDmh1hF4lifYAqB F1ye5CXDeS+zpgSkcaTdF0qvPfxp6Zmc9hjojCku/DX4zccA+ddU++eLp4sp4wz5 dg64HIUbzgpTbp/SJsJOSJtom3ibDfVHMWJbQ5+5oyLxk92Krwe9Y4YKbDvHNcNS HEMu8XZ0jsUDHokBxQwbV+BVxkcjF+RNlGq0Fm3ICTIYc8eGeLm7tAKgKWEFPjwg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddttddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecuffhomh grihhnpehgihhthhhusgdrtghomhenucfkphepkeefrddutddvrddvtdefrdduudelnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from fgunbin.local (unknown [83.102.203.119]) by mail.messagingengine.com (Postfix) with ESMTPA id 712BED60068; Mon, 28 Oct 2019 19:33:47 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Mon, 28 Oct 2019 17:43:23 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241569 Archived-At: Hi Stefan, On 28/10/2019 17:43 -0400, Stefan Monnier wrote: > Could you open a bug report against Kotlin requesting they use > a standard error format instead of inventing yet another one? Looks like it's done on purpose. Current source (I refer to it in comment in patch) is here: https://github.com/JetBrains/kotlin/blob/master/compiler/cli/src/org/jetbrains/kotlin/cli/common/messages/GradleStyleMessagerRenderer.kt If I trace back a little, I see this commit made 5 years ago: https://github.com/JetBrains/kotlin/commit/ffe8ae3840d7b9bdc82170c8181031f05ced68bd, in which they explicitly set the present format. I don't know why they did that, and commit message doesn't help. So probably it's not very promising to file a bug about it. BTW, kotlin compiler by itself reports more "normal" error messages, this one-letter-error-type format is for gradle plugin only. The reason for my patch is that kotlin + gradle is a popular combination nowadays in java world (not that I like this fact :-) In this course I also added basic support for gradle in my javaimp package (now on scratch branch, will merge in elpa master soon). Thanks, Filipp