From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.devel Subject: Re: master 0161c9d 1/2: Load all generic-x.el modes unconditionally Date: Wed, 10 Feb 2021 10:29:27 -0800 Message-ID: References: <20210209160550.18823.10795@vcs0.savannah.gnu.org> <20210209160551.832FB20AD1@vcs0.savannah.gnu.org> <87o8gti2ln.fsf@gnus.org> <83sg65jffx.fsf@gnu.org> <83im71j96z.fsf@gnu.org> <83czx8k3gn.fsf@gnu.org> <83sg64hqzj.fsf@gnu.org> <83im6zj1bo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21886"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: Eli Zaretskii , Stefan Kangas , larsi@gnus.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 10 19:34:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9uJX-0005ZG-Ax for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 19:34:11 +0100 Original-Received: from localhost ([::1]:56292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9uJW-000375-9M for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 13:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9uFE-0000Zk-Cy for emacs-devel@gnu.org; Wed, 10 Feb 2021 13:29:44 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9uF9-0007Dl-SA; Wed, 10 Feb 2021 13:29:44 -0500 X-Originating-IP: 24.113.169.116 Original-Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B23A44000D; Wed, 10 Feb 2021 18:29:31 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 10 Feb 2021 12:45:11 -0500") Received-SPF: pass client-ip=217.70.183.194; envelope-from=matt@rfc20.org; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264322 Archived-At: Stefan Monnier writes: >> Users might not want some file suddenly turn on a mode the user didn't >> intend to use. I don't understand what else there is to explain here, >> really. > > I thought you were talking about modes being defined, for which I don't > see any harm. But indeed, the changes to `auto-mode-alist` imply > a change in behavior which could I guess be annoying (especially since > those modes are quite primitive). > > My problem was with conditionally defining the modes, not with > conditionally activating them. So if we restore the config var but make > it apply only to the `auto-mode-alist` changes, then I think we'll all > be happy. > > Stefan K, could you do that? Separately (almost), when looking at this I noticed that files.el installs a mode for .Xdefaults in auto-mode-alist, and so does generic-x.el. I wonder how many modes in generic-x.el are redundant with modes elsewhere in Emacs. Perhaps it is just the one.