all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Add oauth2 customize group (resolve FIXME)
@ 2021-02-19  1:16 Naoya Yamashita
  2021-02-19 10:17 ` Julien Danjou
  0 siblings, 1 reply; 5+ messages in thread
From: Naoya Yamashita @ 2021-02-19  1:16 UTC (permalink / raw)
  To: emacs-devel, julien

[-- Attachment #1: Type: Text/Plain, Size: 214 bytes --]


Hi, thanks for maintaining such a great project!

I find oauth2 ELPA package and also find a easy FIXME comment.
This patch add a new group and changed all customization
variables to belong to it.

Regards,
Naoya

[-- Attachment #2: 0001-packages-oauth2-oauth2.el-Add-oauth2-group-and-use-i.patch --]
[-- Type: Text/X-Patch, Size: 1469 bytes --]

From b6619724abc1f268eb3b68bc9077f899f9d70bea Mon Sep 17 00:00:00 2001
From: Naoya Yamashita <conao3@gmail.com>
Date: Fri, 19 Feb 2021 09:56:48 +0900
Subject: [PATCH] * packages/oauth2/oauth2.el: Add oauth2 group and use it

(oauth2): New group.
(oauth2-token-file): Belongs to it.
---
 oauth2.el | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/oauth2.el b/oauth2.el
index 43c4e9e4d4..43e48c1dbe 100644
--- a/oauth2.el
+++ b/oauth2.el
@@ -47,6 +47,12 @@
 (defvar url-callback-arguments)
 (defvar url-callback-function)
 
+(defgroup oauth2 nil
+  "OAuth 2.0 Authorization Protocol."
+  :group 'comm
+  :link '(url-link :tag "Savannah" "http://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/?h=externals/oauth2")
+  :link '(url-link :tag "ELPA" "https://elpa.gnu.org/packages/oauth2.html"))
+
 (defun oauth2-request-authorization (auth-url client-id &optional scope state redirect-uri)
   "Request OAuth authorization at AUTH-URL by launching `browse-url'.
 CLIENT-ID is the client id provided by the provider.
@@ -149,8 +155,7 @@ TOKEN should be obtained with `oauth2-request-access'."
 
 (defcustom oauth2-token-file (concat user-emacs-directory "oauth2.plstore")
   "File path where store OAuth tokens."
-  ;; FIXME: This var doesn't belong to any group.  Either add it to some
-  ;; pre-existing group or create an `oauth2' group for it.
+  :group 'oauth2
   :type 'file)
 
 (defun oauth2-compute-id (auth-url token-url scope)
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-19 16:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19  1:16 Add oauth2 customize group (resolve FIXME) Naoya Yamashita
2021-02-19 10:17 ` Julien Danjou
2021-02-19 11:13   ` Naoya Yamashita
2021-02-19 15:14     ` Stefan Monnier
2021-02-19 16:57       ` Naoya Yamashita

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.