From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.devel Subject: Re: Add oauth2 customize group (resolve FIXME) Date: Fri, 19 Feb 2021 11:17:08 +0100 Message-ID: References: <20210219.101653.1338518986357974746.conao3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12894"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: emacs-devel@gnu.org To: Naoya Yamashita Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 19 11:18:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD2rm-0003Ca-3s for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 11:18:30 +0100 Original-Received: from localhost ([::1]:36038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD2rj-00027u-HW for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 05:18:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD2qY-0001eS-N9 for emacs-devel@gnu.org; Fri, 19 Feb 2021 05:17:18 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD2qW-0005Ig-Qq for emacs-devel@gnu.org; Fri, 19 Feb 2021 05:17:14 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 87A075C00DE; Fri, 19 Feb 2021 05:17:10 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Feb 2021 05:17:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=danjou.info; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=fm3; bh=pw2TDpa9KUqmy954wc3O8yVgM3 UKtkha3Y5XMCgdDqE=; b=AHDbzhLMDYyB1zw4sOtiG46Zu8kt9C9tARyo/RR3qQ Ahx25eW63OhJN6pGPGxftOqYEGYdAtNzYmgAFTh3yJQkRPtYKPoGLbHqNI33JoCl Hc3rWpSKh5m0KjcbodEgXqVU650rTSzmLWGuXFCQRBW6tv7EpYkO+LUrqv7aM7FR zGbJZYIFiwJCLxXvMAakIIh4Hce0/Ffm7K5qwXhXsmfbZkfO/gaGDmx47Tna1RWw nkTrrGh2nSnTtvJ59K4uoz1iPvLaAM3cX4UhGvGbyQpzKja/gfw8jFyIWT1xt3aI wyDX3glLAXvOmCEKfdDtGLY7EwGBluBWXSPc8IdIoM3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pw2TDp a9KUqmy954wc3O8yVgM3UKtkha3Y5XMCgdDqE=; b=FDqTx7GYZmqXE3psRMm+M0 DWJJxXoWqKz19j5LeIbwWWvT7pLgwL99C/oRAtcBFOOrxNinjI5cMiDqSXKn3OC/ gTGAlvn8kWM5bmdTJL3/VQdj8aanqPtVPxT7PNeQvqMASsxXXRv2+thI7VCuDW9p TNjqisxaizIoQV7M6QJuR7nYqW3VCF7wncb/0n3U+cVk0SuRew434ig4zv8JELgi idlbfbePuhzk2dl2uZFjcOqKU6WEnYz9pJFqqRHBpB5iOkuPkg+mLClKiX/1mdGK nuEfG1SBARF1IDhm3+5qfeW5YclQ+p3vuLzFRDKxQxTV/IQfIgfaXCymd5tK37Sg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeeigddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufhfffgjkfgfgggtsehttdertd dtredtnecuhfhrohhmpefluhhlihgvnhcuffgrnhhjohhuuceojhhulhhivghnsegurghn jhhouhdrihhnfhhoqeenucggtffrrghtthgvrhhnpeefueelgfeuudegteehvdekveejhe efjeelfeegveffgeelgeejkeeifedvudegieenucffohhmrghinhepghhnuhdrohhrghdp uggrnhhjohhurdhinhhfohenucfkphepkedvrdeijedrgedtrdduvdehnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhulhhivghnsegurghn jhhouhdrihhnfhho X-ME-Proxy: Original-Received: from abydog (unknown [82.67.40.125]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B4F21080059; Fri, 19 Feb 2021 05:17:09 -0500 (EST) In-Reply-To: <20210219.101653.1338518986357974746.conao3@gmail.com> (Naoya Yamashita's message of "Fri, 19 Feb 2021 10:16:53 +0900 (JST)") Received-SPF: pass client-ip=66.111.4.27; envelope-from=julien@danjou.info; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265219 Archived-At: On Fri, Feb 19 2021, Naoya Yamashita wrote: Thanks Naoya. I pushed your change. > Hi, thanks for maintaining such a great project! > > I find oauth2 ELPA package and also find a easy FIXME comment. > This patch add a new group and changed all customization > variables to belong to it. > > Regards, > Naoya > > From b6619724abc1f268eb3b68bc9077f899f9d70bea Mon Sep 17 00:00:00 2001 > From: Naoya Yamashita > Date: Fri, 19 Feb 2021 09:56:48 +0900 > Subject: [PATCH] * packages/oauth2/oauth2.el: Add oauth2 group and use it > > (oauth2): New group. > (oauth2-token-file): Belongs to it. > --- > oauth2.el | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/oauth2.el b/oauth2.el > index 43c4e9e4d4..43e48c1dbe 100644 > --- a/oauth2.el > +++ b/oauth2.el > @@ -47,6 +47,12 @@ > (defvar url-callback-arguments) > (defvar url-callback-function) > > +(defgroup oauth2 nil > + "OAuth 2.0 Authorization Protocol." > + :group 'comm > + :link '(url-link :tag "Savannah" "http://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/?h=externals/oauth2") > + :link '(url-link :tag "ELPA" "https://elpa.gnu.org/packages/oauth2.html")) > + > (defun oauth2-request-authorization (auth-url client-id &optional scope state redirect-uri) > "Request OAuth authorization at AUTH-URL by launching `browse-url'. > CLIENT-ID is the client id provided by the provider. > @@ -149,8 +155,7 @@ TOKEN should be obtained with `oauth2-request-access'." > > (defcustom oauth2-token-file (concat user-emacs-directory "oauth2.plstore") > "File path where store OAuth tokens." > - ;; FIXME: This var doesn't belong to any group. Either add it to some > - ;; pre-existing group or create an `oauth2' group for it. > + :group 'oauth2 > :type 'file) > > (defun oauth2-compute-id (auth-url token-url scope) -- Julien Danjou /* Free Software hacker https://julien.danjou.info */