From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#58144: 29.0.50; [noverlay] Abort when committing in Magit Date: Wed, 28 Sep 2022 16:29:39 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19381"; mail-complaints-to="usenet@ciao.gmane.io" To: 58144@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 28 16:30:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odY4p-0004rw-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Sep 2022 16:30:19 +0200 Original-Received: from localhost ([::1]:51256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odY4o-0003wu-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Sep 2022 10:30:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odY4Y-0003tc-UV for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 10:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odY4Y-0004JO-Kf for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 10:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odY4Y-0007l1-Ee for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58144 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166437539629780 (code B ref -1); Wed, 28 Sep 2022 14:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Sep 2022 14:29:56 +0000 Original-Received: from localhost ([127.0.0.1]:34073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odY4R-0007kG-KP for submit@debbugs.gnu.org; Wed, 28 Sep 2022 10:29:55 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odY4P-0007k8-ON for submit@debbugs.gnu.org; Wed, 28 Sep 2022 10:29:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odY4P-0003YQ-ER for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 10:29:53 -0400 Original-Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:40837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odY4F-0004DK-Us for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 10:29:53 -0400 Original-Received: by mail-ej1-x631.google.com with SMTP id l14so27524098eja.7 for ; Wed, 28 Sep 2022 07:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date; bh=+E5rgU+69XKu5hiYoEZV7Oi4lONJ965aJq6lMnxXXKg=; b=jl7Qc4vy2R4Jtm9tmbfw3aCz8+Fv8hXTHcIExKnDvaZ6F1KzN4rZRoahON6X3imkNU VhDHQ4oZVripgQMcYWQLy4AG2p6coUIHnZY/SLs6o7MZcvliawe17E+9I3NueI82HOqz TvZ0IoUoLRqAbX6XxUkbaLAx70Y+V/LDLbcaYOJzZlXYJnpCxCVM4Bpj5+32ZjOMvLXG +Bh+6uIMGl4lx6gVoFcLQWTF+md2kGr8G4sqXSyt2oaDr9s/N6B69sgfOnXUNOu+ogib uOOE4wF+puf4uw6wqKox7E8YUHbRn9I2Y8QEcVprkC3QIpPVhSA9D9UojJPGkCFDSHrV 9qfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date; bh=+E5rgU+69XKu5hiYoEZV7Oi4lONJ965aJq6lMnxXXKg=; b=6PkcS0EYParPWnDsy7yO9e4S5AF+oPy6Ry9VJl26dil2Hn5hr4WsQ5pU6PuoKQ+UQi gA4BBfF7qUGtDY4mEgtWmjATIuO8pKjh9U1rhareZ3UQwPGMWPCdQ8aUuYekBbvaxcE/ B3knhFmydONt8md7RU1Ud059mX8DcY8vbUTZZ/omE7tFta60XLp3WRfmsUNB4CY6WyNH GJzlqE+PZ+rxcdgALc0Gg9XvvQqTUGId15CpUK0brcKi+BRSnlyhgpARMbxTl/lr3rpH 09g3jLEkSKWXboSwy/YthNlsDV08mq/Fz8sgDS4PTmbDLqdo6XwVzQiUZ9ubu9pboN6p hf/Q== X-Gm-Message-State: ACrzQf0TB2gRcDZ2pTHNuvjGVnrFDa5FZTiyvMrngLt8qggmVFCGclOR SOmPxat1phHelfCZyK/xAiWPThpYsOA= X-Google-Smtp-Source: AMsMyM7a+WZA8D2GWlu7FwNkJaZZDR7vISvijPPWaDYgGkpskQws6YAJCm3dswBqASSnj4Qc+lueTg== X-Received: by 2002:a17:907:60c7:b0:783:4fe0:dad0 with SMTP id hv7-20020a17090760c700b007834fe0dad0mr15604742ejc.342.1664375382159; Wed, 28 Sep 2022 07:29:42 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36b47.dip0.t-ipconnect.de. [217.227.107.71]) by smtp.gmail.com with ESMTPSA id 2-20020a170906308200b0073d70df6e56sm2492037ejv.138.2022.09.28.07.29.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 07:29:41 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243809 Archived-At: An attempt to commit changes in Magit led to an abort in interval_tree_iter_start frame #9: 0x00000001002e2900 emacs`interval_tree_iter_start(tree=0x0000600003034870, begin=5464, end=2730898, order=ITREE_ASCENDING, file="buffer.c", line=2937) at itree.c:441:5 438 const char* file, int line) 439 { 440 if (tree->iter_running) -> 441 emacs_abort (); 442 interval_generator_reset (tree->iter, begin, end, order); 443 tree->iter_running = 1; 444 tree->file = file; Because this wasn't debuggable, I've changed the code to record where an iteration starts, which is, in this case, static bool strings_with_newlines (ptrdiff_t startpos, ptrdiff_t endpos, struct window *w) { struct interval_node *node; /* Process overlays before the overlay center. */ buffer_overlay_iter_start (current_buffer, startpos, endpos, ITREE_DESCENDING); I'll fix that, and also put the location recording in, to make debugging such cases easier.