From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.bugs Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Date: Sun, 29 Jan 2023 17:05:07 +0100 Message-ID: References: <83mt61747b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61151@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 17:06:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMAC2-0005kn-5t for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 17:06:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMABv-0006OW-F0; Sun, 29 Jan 2023 11:06:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMABu-0006OH-K6 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 11:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMABu-0001un-7t for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 11:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMABu-0000V0-2w for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs Original-Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.16750083171859 (code B ref 61151); Sun, 29 Jan 2023 16:06:02 +0000 Original-Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 16:05:17 +0000 Original-Received: from localhost ([127.0.0.1]:45254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMABA-0000Tv-VU for submit@debbugs.gnu.org; Sun, 29 Jan 2023 11:05:17 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:55808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMAB9-0000Tg-S8 for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 11:05:16 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id q8so6498740wmo.5 for <61151@debbugs.gnu.org>; Sun, 29 Jan 2023 08:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EXFospkwvq4e2E8xJUlHbbGxKlW68dPMffQ2nkeag4g=; b=Uk9Vv1c0WK1kjUoHIoD3ktl4PR60H2+/TAiRREv2tWPXRg+CE+/l0Qivw51n+Lk5OL C6iI0rcfXxAOmV1wZysXY848N4DvGVLNo+NchyDjlZXDx5DYYeXeKnBSDg84Jr52C8fH FKen1BgTcOKy7bYaoFTuAis55LrhZ5gCm2N00btnvbnLJkpv54MGMhkhxQvtC5Jw0TRc fj0iQPpH8nxc5n7vDLmcV84tf7r+6eo+k84LYGyKwPaiy2lXVHT8C0BwTfiDLnxgoDel MKig4UYFrYkN+j3UBeDlTk/ycN9bMNr9SA+cBRkOhhQJLUNZ5Ur76nS2ZH2X7ePUBIkQ 2+QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXFospkwvq4e2E8xJUlHbbGxKlW68dPMffQ2nkeag4g=; b=hksCBw+L20bOKGOcEiXCoowYFsHDizQdBk1nmW+dNa6YyJU3WY9fonfgussmRJ9xg4 8lZjQd9EnSeWLft8X83UoTm7Ksy2sYxmPs3orYeUf/u3Ycl6GsctTJbyJGgpw4il+zvK fZlQGf50vX7MAHBsDfKc4IbN6lcqaPbLTxK02c8vqpnCPvFMmAxr2cCg8GJNyVLPoVbg eEhBSLGK/7TZSdX1F8zip/jGJWFLYnFTI5H02Ys44q5SyyCrX0Ce87KdvLjbHHlKvEdJ r4tonf+YKTKkgvhjgzvr9nbkRH4KC1gevrcynhA13X+nW9asbzNUqhKd/fMSRLT1sdA8 uo/g== X-Gm-Message-State: AFqh2koxq4G+bkVexnwKmJSGYGyBJe1xzINjUrM7YY4cFq38TYAcqjRa qJkvi4Mh/hUK/icu+L86KEtOLtJZVBM= X-Google-Smtp-Source: AMrXdXsyj7HikIWKxA1TTzZIMYG7CYzI/a8EijGX/2Q+ujSzjR+MIlYC6d6RIQPlZunlpWxO9Xh20A== X-Received: by 2002:a05:600c:3d16:b0:3d3:3deb:d916 with SMTP id bh22-20020a05600c3d1600b003d33debd916mr46836512wmb.4.1675008308977; Sun, 29 Jan 2023 08:05:08 -0800 (PST) Original-Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id t1-20020a05600c41c100b003dc47d458cdsm4884337wmh.15.2023.01.29.08.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 08:05:08 -0800 (PST) In-Reply-To: <83mt61747b.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 17:25:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254368 Archived-At: On Sun, Jan 29 2023, Eli Zaretskii wrote: > I'm not sure I understand why you need sqlite-more-p here. > sqlite-next returns nil when it hits the end, so it should be enough. > If we document this fact in the doc string of sqlite-next, would that > be good enough to satisfy your use cases? Yes, I guess it would be possible to get rid of sqlite-more-p. However, sqlite-next seems to return nil once, but then it starts over. E.g this (let* ((db (sqlite-open)) (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) (rows '())) (list (sqlite-next stmt) (sqlite-next stmt) (sqlite-next stmt) (sqlite-next stmt))) returns: (("a" 0) ("b" 1) nil ("a" 0)) This "wrap around" behavior is strange. In summary, I think that sqlite-next should signal and error instead of returning nil. And sqlite-more-p should be used to detect the end of the stream. (Theoretically, sqlite-next could then also return zero length rows, though that's probably not needed in practice.) Helmut