From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.bugs Subject: bug#72941: jsonrpc: Check if parameters are in line with the spec Date: Thu, 05 Sep 2024 22:35:32 +0200 Message-ID: References: <87bk17l4rp.fsf@betli.tmit.bme.hu> <8634mi9u01.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20133"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Felician Nemeth , 72941@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 22:45:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smJLx-00056C-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 22:45:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smJLe-0000kV-GL; Thu, 05 Sep 2024 16:44:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smJLc-0000jh-My for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 16:44:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smJLc-00041j-DA for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 16:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=0ZZIjU13Hjtcqc1NDdu5L3eEfqwNETF59kE4XRe0dF4=; b=d6/H0tifPc3eJ1ayecjn3XF8rmAuRdOwZ9Q6hx8a6dvRFR6BtEqKUdh11+CfAE9TIV6jwLvspHZUVeJkoWZM1AgOu198fUqqqIW9rVsIW71MDOYeL31UqCtW+gISfrK106pILXgoARa4kPvnyCOHgOWJEZBoRAD98VoUpPkx2LUriuL2Fufy0P9VC4QEQdLWWYh+DQUViUv7hkCt2P8dOibs3NnJTti1EBDQC7nyIRALSKbLMa0Ksq3+XeJCc7X+1ohOwITeNXDCZ+usoWs3GYeI498y9kfYf2vPGj5oc7WBt+qcl4xP9inZqg1+2/9Kn7T7i4eSaTizKpwTKQgYGQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smJMf-0000Qt-Pm for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 16:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Pettersson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72941 X-GNU-PR-Package: emacs Original-Received: via spool by 72941-submit@debbugs.gnu.org id=B72941.17255691221569 (code B ref 72941); Thu, 05 Sep 2024 20:46:01 +0000 Original-Received: (at 72941) by debbugs.gnu.org; 5 Sep 2024 20:45:22 +0000 Original-Received: from localhost ([127.0.0.1]:38336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smJM1-0000PF-PF for submit@debbugs.gnu.org; Thu, 05 Sep 2024 16:45:22 -0400 Original-Received: from mail-ej1-f44.google.com ([209.85.218.44]:47443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smJM0-0000P3-Ek for 72941@debbugs.gnu.org; Thu, 05 Sep 2024 16:45:20 -0400 Original-Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a8a6d1766a7so135267866b.3 for <72941@debbugs.gnu.org>; Thu, 05 Sep 2024 13:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725569049; x=1726173849; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ZZIjU13Hjtcqc1NDdu5L3eEfqwNETF59kE4XRe0dF4=; b=oawp/AGWUVlAsxJI+RoYFcQ7aprLo0gfZ39L3WF300YyWS33s/SqLLQ964yBbcJJxQ Y/Qq1MK2Z8FSk6P2Djz3RvBZisvIMgm/XyYVEYv8dRv3HO37uMkWWVqsM4Zx4vcoW2Yf tdjH2zU9VM+m/xur8qYqiOGgATtLNUUMxpT6MQWRdGphZfxHA7szK78ImOPmDhyrkRP4 jbDSwWsWszIVnJqfVgMjrqZ8IM5E4S4OP6A62z4eBKD2weL6ARm1p9mHKDgCoJl2sUxd gPr1IaerGM7pUFaKtgIcVAhHJuhlYq3YmNSFuZROiEnD1dzn84ZykLHAZ4rAzqlnS89/ hqYA== X-Forwarded-Encrypted: i=1; AJvYcCUYnH4XAV4sVe9YaWb39AIi69EbZdLFBSPfvcJGiVXCFFoZrmkLj9ra11xGDlGurFA072EXvg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy7ljGKLPO0g4XIrcOvlHhfRhkiY7RC93eMyPFo+pSQvCbqPKXW kv/PmQZwdWMndYh8iJ6jDaflUuljh3eSUEzpQG0Iz3gXjEycy4Z6UxJ4jQ== X-Google-Smtp-Source: AGHT+IHeO/I2ZO7K9NIEsL+fIVgnC0f8nek0r5KfO56SWkDIawvoXlmLIQ0KD5n+iPwynxYC+kqBYQ== X-Received: by 2002:a05:6512:2202:b0:536:55ae:7444 with SMTP id 2adb3069b0e04-536587aaf27mr86533e87.22.1725568534425; Thu, 05 Sep 2024 13:35:34 -0700 (PDT) Original-Received: from Daniels-Air (c-97c9e455.027-357-6d6c6d4.bbcust.telenor.se. [85.228.201.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-536572f3447sm42502e87.242.2024.09.05.13.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 13:35:33 -0700 (PDT) In-Reply-To: <8634mi9u01.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Sep 2024 14:26:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291291 Archived-At: >> Would it be possible to extend jsonrpc.el to check the params argument >> of jsonrpc-request, jsonrpc-notify, and jsonrpc-async-request whether it >> is a structured value? And if it is not, then guide the programmer to >> the above URL with a warning. The use case makes sense to me, but I would go with updating the docs rather then the API. The current wording could use some love as it's refereed to as JSON object or plist (at different functions). When it should be plist or vector, where we could throw in a link to the specification. I am not for signaling an error or similar as it's a breaking change in my book, which does not seam called for in this case. /Daniel Pettersson