assq_no_quit... huh?

assq_no_quit... huh?

[Po Lu]

What's the meaning of this code?

	  if (is_tty_frame (f))
	    {
	      /* Ignore all invisble tty frames, children or root.  */
	      if (!FRAME_VISIBLE_P (root_frame (f)))
		continue;

	      /* Remember tty root frames which we've seen.  */
	      if (!FRAME_PARENT_FRAME (f)
		  && NILP (assq_no_quit (frame, tty_root_frames))) <===
		tty_root_frames = Fcons (frame, tty_root_frames);
	    }

No alist is being constructed and consequently assq_no_quit always
returns nil.

Re: assq_no_quit... huh?

[Gerd Möllmann]

Po Lu <luangruo@yahoo.com> writes:

> What's the meaning of this code?
>
> 	  if (is_tty_frame (f))
> 	    {
> 	      /* Ignore all invisble tty frames, children or root.  */
> 	      if (!FRAME_VISIBLE_P (root_frame (f)))
> 		continue;
>
> 	      /* Remember tty root frames which we've seen.  */
> 	      if (!FRAME_PARENT_FRAME (f)
> 		  && NILP (assq_no_quit (frame, tty_root_frames))) <===
> 		tty_root_frames = Fcons (frame, tty_root_frames);
> 	    }
>
> No alist is being constructed and consequently assq_no_quit always
> returns nil.

Thanks, that's a bug. It would have better been memq_no_quit but that
doesn't seem to exist anymore. Will be fixed soon.

Re: assq_no_quit... huh?

[Gerd Möllmann]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> What's the meaning of this code?
>>
>> 	  if (is_tty_frame (f))
>> 	    {
>> 	      /* Ignore all invisble tty frames, children or root.  */
>> 	      if (!FRAME_VISIBLE_P (root_frame (f)))
>> 		continue;
>>
>> 	      /* Remember tty root frames which we've seen.  */
>> 	      if (!FRAME_PARENT_FRAME (f)
>> 		  && NILP (assq_no_quit (frame, tty_root_frames))) <===
>> 		tty_root_frames = Fcons (frame, tty_root_frames);
>> 	    }
>>
>> No alist is being constructed and consequently assq_no_quit always
>> returns nil.
>
> Thanks, that's a bug. It would have better been memq_no_quit but that
> doesn't seem to exist anymore. Will be fixed soon.

Should be fixed now.

Re: assq_no_quit... huh?

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 20 Dec 2024 06:00:35 +0100
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > What's the meaning of this code?
> >
> > 	  if (is_tty_frame (f))
> > 	    {
> > 	      /* Ignore all invisble tty frames, children or root.  */
> > 	      if (!FRAME_VISIBLE_P (root_frame (f)))
> > 		continue;
> >
> > 	      /* Remember tty root frames which we've seen.  */
> > 	      if (!FRAME_PARENT_FRAME (f)
> > 		  && NILP (assq_no_quit (frame, tty_root_frames))) <===
> > 		tty_root_frames = Fcons (frame, tty_root_frames);
> > 	    }
> >
> > No alist is being constructed and consequently assq_no_quit always
> > returns nil.
> 
> Thanks, that's a bug. It would have better been memq_no_quit but that
> doesn't seem to exist anymore.

It did exist, in the w32*.c files.  So the change you made to re-add
memq_no_quit broke the MS-Windows build.

Please in the future, when you add a new function, grep _all_ of the
sources for the same symbol, to avoid inadvertent breakage of
platforms where you don't build Emacs routinely.

Thanks.

Re: assq_no_quit... huh?

[Gerd Möllmann]

Eli Zaretskii <eliz@gnu.org> writes:

> It did exist, in the w32*.c files.  So the change you made to re-add
> memq_no_quit broke the MS-Windows build.

Sorry for that.