From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andrew Choi Newsgroups: gmane.emacs.devel Subject: Re: Mac OS X: Rebuild Require after Security Update 2002-11-21 Date: Sun, 24 Nov 2002 14:58:06 -0700 Sender: emacs-devel-admin@gnu.org Message-ID: References: <97823BA8-FFEC-11D6-AD9F-00039390AB82@mac.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: main.gmane.org 1038175656 19623 80.91.224.249 (24 Nov 2002 22:07:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 24 Nov 2002 22:07:36 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18G4uc-00056L-00 for ; Sun, 24 Nov 2002 23:07:34 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18G4zw-0003wq-00 for ; Sun, 24 Nov 2002 23:13:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 18G4ms-0005zV-00; Sun, 24 Nov 2002 16:59:34 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 18G4lb-0004r8-00 for emacs-devel@gnu.org; Sun, 24 Nov 2002 16:58:15 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 18G4lW-0004h1-00 for emacs-devel@gnu.org; Sun, 24 Nov 2002 16:58:13 -0500 Original-Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10] helo=pd6mo3so.prod.shaw.ca) by monty-python.gnu.org with esmtp (Exim 4.10) id 18G4lV-0004eE-00 for emacs-devel@gnu.org; Sun, 24 Nov 2002 16:58:09 -0500 Original-Received: from pd5mr2so.prod.shaw.ca (pd5mr2so-qfe3.prod.shaw.ca [10.0.141.233]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H6300DJKP0X8M@l-daemon> for emacs-devel@gnu.org; Sun, 24 Nov 2002 14:58:09 -0700 (MST) Original-Received: from pn2ml6so.prod.shaw.ca (pn2ml6so-qfe0.prod.shaw.ca [10.0.121.150]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H63005IZP0XAZ@l-daemon> for emacs-devel@gnu.org; Sun, 24 Nov 2002 14:58:09 -0700 (MST) Original-Received: from owlbear.local.shawmail (h68-144-207-94.cg.shawcable.net [68.144.207.94]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H6300AK4P0WCP@l-daemon> for emacs-devel@gnu.org; Sun, 24 Nov 2002 14:58:09 -0700 (MST) In-reply-to: <97823BA8-FFEC-11D6-AD9F-00039390AB82@mac.com> Original-To: Steven Tamm User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 37 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:9655 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:9655 Steven Tamm writes: > [...] So here is my proposed change. > > *** unexmacosx.c.old Sun Nov 24 12:24:03 2002 > --- unexmacosx.c Sun Nov 24 12:35:41 2002 > *************** > *** 888,894 **** > /* 2002-04-15 T. Ikegami . The original > code to get size failed to reallocate read_buffer > (lread.c). */ > ! int old_size = emacs_zone->size (emacs_zone, old_ptr); > int size = new_size > old_size ? old_size : new_size; > > if (size) > --- 888,894 ---- > /* 2002-04-15 T. Ikegami . The original > code to get size failed to reallocate read_buffer > (lread.c). */ > ! int old_size = malloc_default_zone()->size (emacs_zone, old_ptr); > int size = new_size > old_size ? old_size : new_size; > > if (size) Hi Steven, Hey, that's some great debugging!! With your change above, I was able to verify that an executable dumped on 10.2.2 before the security update can be run on one after the update was applied. Please install the change when you can. Somewhat related, while working in unexmacosx.c, I notice the function build_region_list. This function is left over from earlier versions of the file and is unnecessary since dumping is now based on the emacs_zone regions. I'll remove it at some point. Andrew.