From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Possible emacs bug when type password fields Date: Wed, 06 May 2009 17:08:31 +0200 Message-ID: References: <1f62569f0905010413k13fde32fsbcd1ebef8f872516@mail.gmail.com> <20090501.184211.227773522.hanche@math.ntnu.no> <87k54vtn0j.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1241622660 7808 80.91.229.12 (6 May 2009 15:11:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 May 2009 15:11:00 +0000 (UTC) Cc: Harald Hanche-Olsen , Borja Tarraso , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 06 17:10:45 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M1ikH-0004d0-I2 for ged-emacs-devel@m.gmane.org; Wed, 06 May 2009 17:09:17 +0200 Original-Received: from localhost ([127.0.0.1]:49401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1ikH-0004dS-00 for ged-emacs-devel@m.gmane.org; Wed, 06 May 2009 11:09:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1ijg-0004M8-8t for emacs-devel@gnu.org; Wed, 06 May 2009 11:08:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1ijb-0004JG-Bb for emacs-devel@gnu.org; Wed, 06 May 2009 11:08:39 -0400 Original-Received: from [199.232.76.173] (port=34303 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1ijb-0004JC-93 for emacs-devel@gnu.org; Wed, 06 May 2009 11:08:35 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:54327) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1ija-0006bp-PG for emacs-devel@gnu.org; Wed, 06 May 2009 11:08:35 -0400 Original-Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 6CF371C001DF; Wed, 6 May 2009 17:08:33 +0200 (CEST) Original-Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id F08E290381; Wed, 6 May 2009 17:08:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id F7-Cz77yBzrq; Wed, 6 May 2009 17:08:31 +0200 (CEST) Original-Received: from igel.home (DSL01.83.171.167.252.ip-pool.NEFkom.net [83.171.167.252]) by mail.mnet-online.de (Postfix) with ESMTP; Wed, 6 May 2009 17:08:31 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 6AB9F10C409; Wed, 6 May 2009 17:08:31 +0200 (CEST) X-Yow: LOU GRANT froze my ASSETS!! In-Reply-To: (Stefan Monnier's message of "Wed, 06 May 2009 10:25:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110729 Archived-At: Stefan Monnier writes: >>> --- lisp/subr.el 2009-05-02 00:32:01 +0000 >>> +++ lisp/subr.el 2009-05-06 01:21:02 +0000 >>> @@ -1997,10 +1997,11 @@ >>> (and (arrayp pass) (clear-string pass)) >>> (setq pass new-pass)))) >>> ((not (numberp c))) >>> - ((= c ?\C-u) ; kill line >>> + ((eq c ?\C-u) ; kill line > >> That should not make a difference, since c is guaranteed to be a number >> here. > > That's the thing: by changing red-char into read-key (done by the > previous patch), it is not guaranteed any more. Look closer. The preceeding clause catches all non-numberp cases. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."