From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: fix latent bug in process.c Date: Mon, 13 Aug 2012 22:45:36 +0200 Message-ID: References: <87txw661c8.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344890748 11005 80.91.229.3 (13 Aug 2012 20:45:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Aug 2012 20:45:48 +0000 (UTC) Cc: Emacs discussions To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 13 22:45:49 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T11WF-0007Ax-M9 for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 22:45:47 +0200 Original-Received: from localhost ([::1]:48090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11WE-0001BG-ML for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 16:45:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11WB-0001Ag-IZ for emacs-devel@gnu.org; Mon, 13 Aug 2012 16:45:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T11WA-0005C7-DJ for emacs-devel@gnu.org; Mon, 13 Aug 2012 16:45:43 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:60351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T11WA-0005Bx-6Q for emacs-devel@gnu.org; Mon, 13 Aug 2012 16:45:42 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3WwpqR5kJ1z3hhT6; Mon, 13 Aug 2012 22:45:38 +0200 (CEST) X-Auth-Info: XUyuHzyeP8VG7hlnvGyVpkNQ5EpSYZ5HJWARJ746Xc0= Original-Received: from igel.home (ppp-93-104-154-197.dynamic.mnet-online.de [93.104.154.197]) by mail.mnet-online.de (Postfix) with ESMTPA id 3WwpqQ0szfzbbcs; Mon, 13 Aug 2012 22:45:38 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 7508ACA2A5; Mon, 13 Aug 2012 22:45:36 +0200 (CEST) X-Yow: I can see you GUYS an' GALS need a LOT of HELP...You're all very STUPID!! I used to be STUPID, too..before I started watching UHF-TV!! In-Reply-To: <87txw661c8.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 13 Aug 2012 13:25:43 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 212.18.0.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152494 Archived-At: Tom Tromey writes: > First, we unconditionally set Writeok, even if SELECT_CANT_DO_WRITE_MASK > is set. It seems to me that in one branch we ought to clear Writeok; > and only set it in the other. It doesn't matter, since if SELECT_CANT_DO_WRITE_MASK is defined write_mask will always be empty anyway (w32 does not support dbus). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."