From: Andreas Schwab <schwab@linux-m68k.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111747: * doc-view.el (doc-view-odf->pdf-converter-soffice): Use separate
Date: Wed, 13 Feb 2013 00:43:05 +0100 [thread overview]
Message-ID: <m2mwv9yu7q.fsf@linux-m68k.org> (raw)
In-Reply-To: <jwvd2w5ty4x.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 12 Feb 2013 09:21:02 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + ;; A workaround is to start soffice with a
>> + ;; separate UserInstallation directory.
>> + (concat "-env:UserInstallation=file://"
>> + (expand-file-name (format "libreoffice-docview%d" (user-uid))
>> + temporary-file-directory))
>
> I'm pretty sure there's some kind of race condition here that lets an
> attacker on the same machine make you write files you didn't intend.
It should be put in a directory like server.el and doc-view.el do.
server-ensure-safe-dir and doc-view-make-safe-dir should probably be
factored out into a generic function.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-02-12 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1U5DrQ-0008KT-9G@vcs.savannah.gnu.org>
2013-02-12 14:21 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111747: * doc-view.el (doc-view-odf->pdf-converter-soffice): Use separate Stefan Monnier
2013-02-12 23:43 ` Andreas Schwab [this message]
2013-02-13 7:07 ` Tassilo Horn
2013-02-13 8:31 ` Andreas Schwab
2013-02-13 9:14 ` Tassilo Horn
2013-02-13 15:04 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mwv9yu7q.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.