From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nick Helm Newsgroups: gmane.emacs.bugs Subject: bug#26892: 25.2; whitespace-mode does not turn off correctly Date: Mon, 22 May 2017 11:11:11 +1200 Message-ID: References: <837f1ma96f.fsf@gnu.org> <83mva92fqv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1495408337 26927 195.159.176.226 (21 May 2017 23:12:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 May 2017 23:12:17 +0000 (UTC) User-Agent: mu4e 0.9.18; emacs 25.2.1 Cc: 26892-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 22 01:12:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCa1D-0006pI-Ju for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 May 2017 01:12:11 +0200 Original-Received: from localhost ([::1]:39561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCa1H-0001OB-J5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 May 2017 19:12:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCa17-0001Mk-CY for bug-gnu-emacs@gnu.org; Sun, 21 May 2017 19:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCa14-0008Rb-6y for bug-gnu-emacs@gnu.org; Sun, 21 May 2017 19:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCa14-0008RX-3w for bug-gnu-emacs@gnu.org; Sun, 21 May 2017 19:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dCa13-0000I4-V1 for bug-gnu-emacs@gnu.org; Sun, 21 May 2017 19:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nick Helm Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 May 2017 23:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26892-done@debbugs.gnu.org id=D26892.14954082891074 (code D ref 26892); Sun, 21 May 2017 23:12:01 +0000 Original-Received: (at 26892-done) by debbugs.gnu.org; 21 May 2017 23:11:29 +0000 Original-Received: from localhost ([127.0.0.1]:59744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCa0W-0000HG-RY for submit@debbugs.gnu.org; Sun, 21 May 2017 19:11:29 -0400 Original-Received: from mail-sy3aus01on0090.outbound.protection.outlook.com ([104.47.117.90]:45074 helo=AUS01-SY3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCa0U-0000H2-Ib for 26892-done@debbugs.gnu.org; Sun, 21 May 2017 19:11:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenpointcomms.onmicrosoft.com; s=selector1-tenpoint-co-nz; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tlb6KSN7JXBVtdSiCzcfYn/+obrHrPH2mfFvGPGOMKA=; b=HEjoQNCYliSUCby/WA6GmD2uMGpAMZicOIjTzaTyDqwhVSZ+WHLWOCPLMSI8N7FUR3EunzTHLlPoAt74NYeZYQru3C/xMSNXVqOpRzDixbEkLvmVwc+IdmWAW13EoW/gqhTOYVhIR7Xalq7y/6MASV7be5HKFdgRErvckxU1Kcw= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=tenpoint.co.nz; Original-Received: from jupiter.local (125.239.122.5) by SY3PR01MB0971.ausprd01.prod.outlook.com (10.169.171.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Sun, 21 May 2017 23:11:14 +0000 In-Reply-To: <83mva92fqv.fsf@gnu.org> X-Originating-IP: [125.239.122.5] X-ClientProxiedBy: SY3PR01CA0101.ausprd01.prod.outlook.com (10.173.248.34) To SY3PR01MB0971.ausprd01.prod.outlook.com (10.169.171.22) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SY3PR01MB0971: X-MS-Office365-Filtering-Correlation-Id: e39dda7b-258e-40df-a830-08d4a09eae0c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075); SRVR:SY3PR01MB0971; X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 3:9K8m8c/UAmRoHR2PRirHHVwm9yPxfQwQWNUVj9oQZhFpxknPrTYZNJ2AlfCnZZuu0GC5XsxYiaKb4yKMDwtKRoDSbECh5OAMSZX0TNkV5UNa6lNNQQkXnrC4zD6CCD4+hJ2t91h/rbUW0jqGYgqvdjYbRgiwany1euS3NJRIhku7ph8v9HKLbBCMxPLG9IsTJuebuEWmPxZDaHLu2+CcABiGijapnlTGpvKvpzAvpptzMuNW6Iu+jVLbcJCIbMIDOK+MPybSZuRgLl6utgV4loMgdGDeB0Rdsfv6yXej2O1EyA/UiXdh2wGl074l1/fv; 25:qk4q0tI0wyJZ/N8MO+JrtxofnxUuXsrANclZ3gn5PUVWiV8djjFzel0rIClU7YZj9mWB3ZO4Cc99j80IEVLlUP3I8oYDAocN451397ePJVXgMK67yBlTIXt+E4v+HFn4QPnpT0ynrQnUw1D8Bo6O9fNRcSnuHar6eTn9mTnsDNrlwziaXnUfbPR30xsrqXOG1eEDr5UIKjEev7qLUSKCfYcqEtmZVwWhaG2+D8EqCkw5fE7U2PdPaPqpD4N9NfASjZ1s5jjoVf1DM8xPtR1BKuXMWl8YL4VvQCoAtDNDuZU5iqO1vzArmh9bbbHcP/aFozIZuG+FnG3Eo5Oaedz5Iq3HCKS6V0O+uwWsGiyiF87Vz6fbq+H9Fbrk+lziDeBTMf84uXMPw9K+RYKx7kZ5TtWoR/wQgipW8KeyPuOKlygUUymgXyT3fEGHvYJbpjnh5GAVdhnz80Tfc/M8nh52wF00omHF5Vn/1hRgqBdD5JU= X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 31:ixfPPENeqyAVyP5WkhGnkFuDRmYCRQRa0COWrUlcOBwr3UzPEzgfdwCLoY4LLlEFQSkGjqOKqwOuO9mWkUzU0fSBj6JAJK/fp0cJGPs62ylBN6jx2OMLdj5rq0NoehpXQQ1rGZ7TVXb3WmLkScy3v2xfEROj6pZj4vf1DXjorlc+NGxA6qcFmt23y+TpzdsYyuHOcXGRRnaDVP+yPgnLjsh//W0exv2IMic53R3Dr/KdJxr0zbTeSq2au9QkCm83waVay4wHL6qWZf5CdOPbLg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123558100)(2016111802025)(201703131423075)(201703061421075)(20161123560025)(20161123564025)(6043046)(6072148); SRVR:SY3PR01MB0971; BCL:0; PCL:0; RULEID:; SRVR:SY3PR01MB0971; X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 4:/Le1s23ne6ZS/KrY7vExnGVX87sFOFf3IeLeDJl+AWrBBneyDhlUAlDjpCr5P/CNbZOmnxf+tPz0c4x4rp0x5B0JRNPvtI1smkWCmZgFg3CGduJC9wk6XoJiOK5Hmg981BJvplmxeXNnQ+Jshs1sUtDhHPO+w4fFugMX1/87pl3TudvGvfL2VXeufVPXJgnPIAJW9tacZpkG38KpQmrZq3SP5luWjmJOrNF9KvvPmGkqocUw8Fp7mTo4NZO/kdS3e3iCTs48Qhro/4HK5WS7kT1IrWDyZzpCdD6r+RE2ZNEfr8+5siSxJ5Dmua1m+N0YcCYX1mwsD8Mjr3SJ8+XvqtP6Tj92aClnpE81zn4JSHO/wGiIsyG5nT7ACeKIQOZSS9xyfpr6SEl50PFdfBVVidhNmCNDa08o+UkyducVRa8Yvf8lAPRdY8CWjm2Ifi3Wo1FYAKU8ogmKoLAGGcgN46edONQfdOoiLM1hpSJ+rnnKFy/mzvr3mCdvoqcxTK+Sg9D5eGhCSwM4ggm3Cv4VjSIZvUmmLRD7/zd7kjTTnfRR0hargaGsrWP7X2NR89tbyKfuLJ0AIP6D6GTOKfceUe/ja5N4iWhsULkaWxsxJBqaXBy/5AGa+J5koI8xZe81vHP8ZOPJfOFeicUoAFc9iaW4LhUWGnm638mUL/BpDsb/U+R5O0iEK8Qy9DRj+kfx1SUaxbhQ/VdNuxkVEsHh6xvWFJG8rnHmshpCn4jKbaGPCaRDxAzFDMcQPSuIO7nO X-Forefront-PRVS: 03142412E2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39400400002)(39450400003)(36756003)(229853002)(5660300001)(508600001)(81166006)(2950100002)(53936002)(6916009)(6512007)(42882006)(8676002)(6666003)(74482002)(7736002)(3846002)(6116002)(6246003)(86362001)(110136004)(83506001)(25786009)(38730400002)(4326008)(6486002)(6506006)(42186005)(33646002)(5003940100001)(345774005)(76176999)(54356999)(50986999)(189998001)(93886004)(4001350100001)(48376002)(2906002)(47776003)(66066001)(305945005)(50466002); DIR:OUT; SFP:1102; SCL:1; SRVR:SY3PR01MB0971; H:jupiter.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 23:gSvQEUmE+qRXeZEWK6v8KljjRqoqKIkrtJhU9o1x/h25poVO5DJJVE6rkUHafNdxRuQNKuC2xEL9jbesID2uqUU/vcxUqYepWNvos4abOXCM8scYgdBknJW6B4Ion6IoWq9YqiYf8Urhzv74pDWfVQimdgrzURl0ugAqNnfvh8by7sWSXqM7lf0EvQfF7q1SjNnXif4X6ObQuwHI3xJz+8YRk3S1vziygNtsszcYBc5S9FN/nhG9GWyJ2D8rBraA846V1Vzj5FOMv7sC0AGYV/woCoq/+6BjJKS9eIYG5lcEf9Vcr2IFzgtqGqfpG8UFKp+HBS6IrVzppD3VRzgrlFiI+U9K/+EP8u+qYaHGIa5fmV6P4POUfhDNsItHxnLoFPHO7v57OIhANHiSdk4opsoVDt//jMb7LO5xMSCRLMVNkqFU0inEV2g1Kbfcx/vh0+MyFWZJ/6b0yKs8J5f+0NikIHVDIgQQhXkhxjV5vjpFfHHIz+8qhgOUQNZfVQdRNuhKS7EkboTpzVjvn/maJufOXHbpI1PaVXYSsKEYOam2piHLUfdkANapojyWDk7+Z5jOZI8B2Ti/ntjbbuqEidjVvXithO1JENc45uWDnMs5MUyIAIJJwmfplVyf1MHqkuS6YGI8lvvHQiP0wpBIVGteGo1seJDshieqDNdlix6Pib5qP80u+4K/6kVHyj8PsDvtS1MQTjcZtw3ULSG+shJ+vxZ+zHGIL2nODXoFPxdPo40DIjw2u50SO4t4cCrkpo+c1ScSXVF+3R2P02m7kg8ZLKOj bFysxi3oPlBzyMYSTozRaXW67DHiu3YB6Ng8N4av2mtZ1F X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 6:BwoTmC+jC+r6xcUsvkMcSAFeIaTqH22fCOBSn4ieaZQTlLnp+27Kst49zYkVznHP9bUrSkZARFT+FewDmT4fRehTdWmckBaKUUGoxRlH6XDzBi4sRImH+mwi8NrN8dUVzbwzFGni2BMdiPzssbVMcrzvvx0ek+nohz3V5r6AZscmWElSTxVTPhUUKKKxHDd6JW1QMi7+VhMx3rgvj9GVCtMjJk7oFjk/WaIonW+6BK2Wk53sBkgPFOSmz0+UcxWJz6c365FS1i7hVJmUAtqkYeA2/jiPtODm/piiJdryyDvaQLcM8OMkOZGSsOoTILGkGmezp+II+owJAfTuO0EJg0kBXw/guf3CvFDvSa7YZZ2Slxwh54cggFnqJIJXwEPjWgMbE+Z+fgcVpI/db6bsYN4y7LS/AzeomlAXF/LpxAaCZKOcNspi2wli28IQBOBQ14yoc0oz1iFz+5+tKKtlqgd2aPnOjmA+A1jJqH50XHtQL1tPuTgBDdTunTRAFOKMJ4q5jRZWQb9f9SI23wHYpg==; 5:mE3t+MYpWrTmS5PDtpmiQ5c5r5UYLzYXLIb0GX6LGzDLTbK4kB+7QYkM2QDROTAjSC5B1ADXBn1FrkXK0yh2htTpUJQriHn7T2icKqAEPK624jm7Le9xozUA75XX+IuIQMQ3wN0m2K0CAl/uMQ9HNA==; 24:mcFJkX6XbH9WF8TWcCsM/+o6ny/KuU31HZni9uwqWy/ZRowQ2svt7kuj3JjwDdQ3M/se4TP4VQlWlpiRWjjvGgXNUfPs/vyrxCRZY8C+iQU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SY3PR01MB0971; 7:C7uY0bydK5oqKsBXAvYVVMHa5yXkLyUAh7JuC6EewZfIMoOTipNm7I5UnlL/bSB2EVBpJFS/wBZ8HO5YY9g26p7nrNzoxEkgS0qwCrR/Bvr3hytqaxYrDi+w5SIkklMM8jhHNqx/j0W3TbBbiB2BczGDTAfCiTphjf73KmPlBXpbmgUfpKzn2sWdH4MxWl0YiC0MU6EcJ2d/kZOwnMJp+3nHeUtd5NLfeDjxoMLJ7OPIPa40eICBmdw2HUd/YZbl4ErQ80LxpWEDxlXj/lxeN79Wn1wGpMzDMN3U2QrMSXLj0UpZkQsZS2EOwj3ZxQzR6tE1886NCLXRLyVZmV3NHg== X-OriginatorOrg: tenpoint.co.nz X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2017 23:11:14.8852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY3PR01MB0971 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132718 Archived-At: > A couple of notes, for the future: > > . The test at first failed for me, and needed some tweaking, because > whitespace-mode refuses to turn on in batch mode. I guess you ran > the tests in interactive mode? You should run tests in batch. Sorry, yes, I did. I read about batch testing in the manual, but didn't click that most tests need to run that way. Of course they do, now that I think about it. > . The patch was not applicable without manual editing, because it > used file names like whitespace-a.el, which don't exist. Please in > the future submit patches produced against the correct file names, > preferably with "git diff" or somesuch. > > . Please include with the patch a ChangeLog-style commit log message > (see CONTRIBUTE for details). > > . Finally, this contribution exhausts the amount of changes we can > accept from you without legal paperwork, so I encourage you to > start the paperwork rolling, for us to be able to accept your > future contributions. (I can send you the forms off-list if you > want.) I'd like to keep contributing where I can, so please do send the paperwork when you have a moment. Thank you for the feedback and for fixing up the code. It is very much appreciated!