From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.bugs Subject: bug#29353: [PATCH] Add window divider faces to NS (bug#29353) Date: Sun, 19 Nov 2017 12:40:09 -0800 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1511124079 17160 195.159.176.226 (19 Nov 2017 20:41:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 20:41:19 +0000 (UTC) Cc: 29353@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 21:41:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWOn-0003e6-Fq for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 21:41:06 +0100 Original-Received: from localhost ([::1]:54318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGWOu-0007Bd-Ua for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 15:41:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGWOo-0007BY-36 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:41:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGWOk-0006XC-53 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:41:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGWOj-0006X0-T0 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGWOj-0001Z1-IS for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 15:41:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Keith David Bershatsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29353-submit@debbugs.gnu.org id=B29353.15111240135949 (code B ref 29353); Sun, 19 Nov 2017 20:41:01 +0000 Original-Received: (at 29353) by debbugs.gnu.org; 19 Nov 2017 20:40:13 +0000 Original-Received: from localhost ([127.0.0.1]:47977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWNx-0001Xs-3o for submit@debbugs.gnu.org; Sun, 19 Nov 2017 15:40:13 -0500 Original-Received: from gateway30.websitewelcome.com ([192.185.145.3]:40443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWNv-0001Xl-Ed for 29353@debbugs.gnu.org; Sun, 19 Nov 2017 15:40:11 -0500 Original-Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A2254619 for <29353@debbugs.gnu.org>; Sun, 19 Nov 2017 14:40:10 -0600 (CST) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id GWNue4PMEHEImGWNue7HWl; Sun, 19 Nov 2017 14:40:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:Cc:To:From:Message-ID:Date: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aYplApM/yutQp5eGdrJKtWPlLD6MKFgsMGumx5pFutE=; b=Cgk0lpnMFylNZ9h0SjIeEpVCcd u8ijVoRaOdH3Le3KHEZFkgsCaYLg2CgwEa/jWkqQy1LMrzlq3phdju/HNjJV4NH1cB8jomrSfGjXN dfqStSYX9d0Vv637NIkomlpZ1D5hfRCpSz3blY1vPQk/9qkfnjmr7rSrDfVG523wdGdYlKNImhpZh 9LsDF+ySzsRHqFeB0Spnuk1DYd9Mcyn3sZFpYha+0xywhYX9AVU52rPWszDpTpW+vjJzFMrHIuawN a3OIYhoapLdrwG211iKquPIRjDquAscG/IiTVLat+ji4AwS0y46/RjPPg7siNVMd3ITHkbuq+Zv5f nuUTgSSQ==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:51120 helo=server.private) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.89) (envelope-from ) id 1eGWNt-003n2v-NT; Sun, 19 Nov 2017 14:40:09 -0600 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1eGWNt-003n2v-NT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.private) [45.48.239.195]:51120 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140119 Archived-At: Thank you, Alan, for bringing this feature to Emacs on the OSX/MacOS platforms. The only issue I observed with the patch applied is when a user selects a divider width of 3 for right and bottom. In that situation, the bottom divider is entirely one color -- window-divider face. And, the right divider is 2 pixels in the window-divider-first-pixel face and 1 pixel in the window-divider-last-pixel face. When there are exactly 3 pixels, both dividers should have the rainbow of all three available colors in the applicable order. The resolution on my screen is not the greatest in the world, but it looks like all other width variations are working properly. I.e., 1 and 2 pixel widths properly have just the window-divider color (since there is agreeably no room for both the first/last pixel colors), and 4 pixels in width and above have the rainbow effect. (face-spec-set 'default '((t :background "black" :foreground "red"))) (face-spec-set 'window-divider-first-pixel '((t :foreground "red"))) (face-spec-set 'window-divider '((t :foreground "DarkBlue"))) (face-spec-set 'window-divider-last-pixel '((t :foreground "magenta"))) (with-selected-frame (make-frame '((right-divider-width . 3) (bottom-divider-width . 3))) (split-window-horizontally)) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; DATE: [11-19-2017 03:53:13] <19 Nov 2017 11:53:13 +0000> FROM: Alan Third > > * src/nsterm.m (ns_draw_window_divider): Use > window-divider-first-pixel and window-divider-last-pixel faces. > --- > * * *