From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Thu, 09 Aug 2018 18:23:34 +0200 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533831084 19754 195.159.176.226 (9 Aug 2018 16:11:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 16:11:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 18:11:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnnWw-00052O-W1 for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 18:11:19 +0200 Original-Received: from localhost ([::1]:51812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnnZ3-0003Hn-Md for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 12:13:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnnYV-0003Hh-CD for emacs-devel@gnu.org; Thu, 09 Aug 2018 12:12:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnnYQ-0001sw-DM for emacs-devel@gnu.org; Thu, 09 Aug 2018 12:12:55 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:52401) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnnYQ-0001r8-3P for emacs-devel@gnu.org; Thu, 09 Aug 2018 12:12:50 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 109F52280C for ; Thu, 9 Aug 2018 16:15:56 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= reply-to:references:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1533831355; x=1534695356; bh=JN aofCKBaGXGrkOawYnK6LurAzF1+WeeBpZWgfIcmAI=; b=nqxOw3kVpl4+XVCblG kWHaKSp+DOiMCrm6RlZprG71Im7vGnyYo6Kr0jnfCbTGqDRKf7jH5ymgIZpSNwVV 4A3tXWmXzKX5dzcg7zQ9E/eWOziaW63vAYDdeg3EC+vrudqZMLxbtetVO5Cr7M8W 4TGDRuO5Ft/vTaOGYoFZbtdd8= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Gvff0UjmSmVB for ; Thu, 9 Aug 2018 16:15:55 +0000 (UTC) Original-Received: from gray (65.104.198.178.dynamic.wline.res.cust.swisscom.ch [178.198.104.65]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id E3591227E9; Thu, 9 Aug 2018 16:15:54 +0000 (UTC) In-reply-to: (message from Andy Moreton on Thu, 09 Aug 2018 16:17:18 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 37.35.109.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228332 Archived-At: > From: Andy Moreton > Date: Thu, 09 Aug 2018 16:17:18 +0100 > > > Where should that symbol be defined? > > It's defined in gmp.h from the GMP library. If you are building without > GMP installed, then emacs uses an internal copy of the GMP library's > simplified version from src/mini-gmp.[ch]. > > It appears that mini-gmp does not define GMP_NUMB_BITS, so does this > patch work for you instead ? > > Thanks for testing, > > AndyM > > diff --git a/src/alloc.c b/src/alloc.c > index 1504d7912b..a8bc55beb4 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -3830,7 +3830,7 @@ make_number (mpz_t value) > for (i = 0; i < limbs; i++) > { > mp_limb_t limb = mpz_getlimbn (value, i); > - v |= (EMACS_INT) ((EMACS_UINT) limb << (i * GMP_NUMB_BITS)); > + v |= (EMACS_INT) ((EMACS_UINT) limb << (i * mp_bits_per_limb)); > } > if (sign < 0) > v = -v; Thanks, Emacs now builds and runs with this patch installed locally. I also ran "make check" in this configuration (with GMP uninstalled) and it seems that none of the bignum-related tests have failed.