From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#34710: the mode line flicks on set-window-vscroll Date: Mon, 04 Mar 2019 22:07:25 +0100 Message-ID: References: <3D005746-B3FB-4915-A406-10DD0935C671@misasa.okayama-u.ac.jp> <20190302201048.GA20712@breton.holly.idiocy.org> <20190304192550.GB21727@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="64226"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Tak Kunihiro , 34710@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 04 22:17:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h0uxp-000GaR-0y for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Mar 2019 22:17:33 +0100 Original-Received: from localhost ([127.0.0.1]:33177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0uxl-0005re-P0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Mar 2019 16:17:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0uuO-0003Hc-0c for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2019 16:14:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0uod-0001Nt-6d for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2019 16:08:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46740) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0uod-0001Nn-1z for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2019 16:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0uoc-0000EP-SA for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2019 16:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Mar 2019 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34710 X-GNU-PR-Package: emacs Original-Received: via spool by 34710-submit@debbugs.gnu.org id=B34710.1551733656848 (code B ref 34710); Mon, 04 Mar 2019 21:08:02 +0000 Original-Received: (at 34710) by debbugs.gnu.org; 4 Mar 2019 21:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:60283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0uoC-0000Dc-Ah for submit@debbugs.gnu.org; Mon, 04 Mar 2019 16:07:36 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:51206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h0uo9-0000DO-ML for 34710@debbugs.gnu.org; Mon, 04 Mar 2019 16:07:34 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id n19so550693wmi.1 for <34710@debbugs.gnu.org>; Mon, 04 Mar 2019 13:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=TPXfpSxPnY5cQWI++Grv+UCalfmpyVgAPWBYqWiRsAo=; b=AxJ3RS4hzARzU41lkndBcp0aBT/8lU0stPz3atAR+OO2WqcqdvQqVzln66Q27Sq+Zc NpjIRvSlqHf7QWK4NxSiaBoFiWfye5dlvNgvUxwzTJFza+PZlAcdyZWM7iZCw/cwbnDX RQIWc62Chl+gb8tI4JaAOKQd4rJ5oZ8WUMGrAX6TVBpL8EfPlJqLAEGkEuXzHbXkoq1i TKf40aW0R+VpmNDnfpKtzsZYgVLJiLTilHeDtCadKLseUD48EcSL2YwkSGhsqYRgBR/8 DMCCHJOUFOg5h7zQE8UPVesDOlk5jOBXkFAVIOkvtEgf+N15N5YFXUdnDOWaofYwZ+hl lNfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=TPXfpSxPnY5cQWI++Grv+UCalfmpyVgAPWBYqWiRsAo=; b=E+EV1VQ7QPsb/IcM3r6conABwtIoyg8LZUur8cmzdsF4F7t7WOOZVB34Cy7r3gndaH jnqhbvTTmIffmgnsTfwiBsjcO6ZltukbOFaDMmkcT0hhY3Clcq4NXQW66eS15McbDHz2 JnU2QQpfA250vCnM3KMEgKfi0vIK6QaGe63S40bdoR3mBpVjLldtfw3VZHgvWcr/enc4 o0HSb3Y4FRMCpDBLcPGYY8rBYUnyakPd1RV13bBgDgcdwl2LxTFs1k0TiVHPEiq9mwzG vVqtol8drlJYGZVPMyt2apybDsWpR4uTYbFO07A+DowWHJq+W/8mliQRTl1HJsNYDvjc rwdQ== X-Gm-Message-State: APjAAAV7MRY49DcZISNvpzgS/65ANXB3+l8o9vefIGa7V/TcmkKBG1B4 jAzxdbjyg87q6yiY3+dSV5s8D0hN X-Google-Smtp-Source: APXvYqxfeUfFzTnRDP4OHgZbVNDcJdPdbKYBR7IlQnSWXV+okqFRW2e/kXXKft15pWIufBHM9KH7rw== X-Received: by 2002:a1c:670a:: with SMTP id b10mr645149wmc.82.1551733647325; Mon, 04 Mar 2019 13:07:27 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:3cf2:e5dc:fbbc:2d9e]) by smtp.gmail.com with ESMTPSA id a131sm3196694wmh.34.2019.03.04.13.07.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 04 Mar 2019 13:07:26 -0800 (PST) In-Reply-To: <20190304192550.GB21727@breton.holly.idiocy.org> (Alan Third's message of "Mon, 4 Mar 2019 19:25:50 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156043 Archived-At: Alan Third writes: > On Mon, Mar 04, 2019 at 10:06:20AM +0100, Robert Pluim wrote: >> Alan Third writes: >>=20 >> > I believe it=E2=80=99s a problem with running redisplay rapidly (sit-f= or) and >> > the way we=E2=80=99re drawing in NS. We end up with macOS demanding a = screen >> > update, and Emacs unable to deliver due to there being another >> > redisplay coming up. >> > >> > The patch attached to this discussion doesn=E2=80=99t have the problem: >> > >> > https://lists.gnu.org/archive/html/emacs-devel/2019-02/msg00354.html >> > >> > However Robert Pluim reported serious performance problems with it. I >> > haven=E2=80=99t been able to replicate them. >>=20 >> I can try it again. Perhaps something in my configuration is causing >> this. > > If you can try and track it down that would be very helpful. > > The only thing I can think of that could make it very slow is drawing > the buffer to the screen, but that really shouldn=E2=80=99t be as slow as > you=E2=80=99re experiencing, it is, after all, just drawing an image to t= he > screen. To be clear: the slowness I experience does not seem wholly related to redisplay: if I move down in a file using 'C-n', without the buffer scrolling, the movement is very slow. Then when it does actually update the screen because I=CA=BCve moved point off the bottom, it is again slow (by a rough measurement, moving from the top to the bottom of my org file using C-v is approximately twice as slow). (this is all with 'emacs -Q') I=CA=BCve just run another test where I scroll my org file programmatically rather than interactively, and then your patch makes no discernable difference: (benchmark-run 1000 (goto-char (point-min)) (condition-case nil (while t (scroll-up-command)) (error nil))) =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 takes ~15 seconds in both vanilla emacs-26 and with your patch. Are there any other tests you'd like me to run? (I know nothing about macOS profiling tools) Robert