From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Tue, 02 Apr 2019 19:01:45 +0200 Message-ID: References: <20190318010313.rec67ljatygf5xlf@Ergus> <837ecwx3ao.fsf@gnu.org> <20190318114249.ouqxfghhw5dfr5ry@Ergus> <83y35cumzs.fsf@gnu.org> <20190402124236.cpb63pdopfk6vpj5@Ergus> <87k1gczhi8.fsf@telefonica.net> <20190402133718.z464xomdq6l3pfrl@Ergus> <83pnq4fnte.fsf@gnu.org> <20190402153504.jfliuexzn4ntqnn4@Ergus> <83k1gcfm3y.fsf@gnu.org> <20190402163623.2gvlraa5qitzgi6y@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60108"; mail-complaints-to="usenet@blaine.gmane.org" Cc: ofv@wanadoo.es, Eli Zaretskii , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 19:02:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBMo3-000FWW-9I for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 19:02:39 +0200 Original-Received: from localhost ([127.0.0.1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBMo2-0000NS-99 for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 13:02:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBMnG-0000Lr-6s for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:01:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBMnF-000591-AV for emacs-devel@gnu.org; Tue, 02 Apr 2019 13:01:50 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:54048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBMnF-00057r-1H; Tue, 02 Apr 2019 13:01:49 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id q16so4208166wmj.3; Tue, 02 Apr 2019 10:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=FCF7WWd5Z+0QPJeiLnzb2npT6SIsRKggWHKsuXBuIjg=; b=sDneQiSgDSUOVeSrGYRiuQAlrlv37iuEDWbSOn/B5g88QvmnQ7DJSg+atIemR9N/9E sEH1WyEu3SIUsKgrENLQdMzyCJZJlkn2cXAkBwT0UrJvf+8REkLtacWXT7DPYOu/Lx/K k8QzYWUfsRZectOn6uvQQzyBc6bpOKNM4iEbSHxvC2/QPLxfwAwWyVgO5QzdJaG1XQbs VhggUtF3HRzMlpwg01pSWOU3Gb1B1EYqWFh349wGS/EeW7DOsZNdsdNcJ/gQKuvlibwU ZVFFwGZRDRkM14vZXBfPKzE4DgqSZncjncA3d6DMw6Fh4LGeJ+ljSU6XXIsl22+TpLO5 9D4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=FCF7WWd5Z+0QPJeiLnzb2npT6SIsRKggWHKsuXBuIjg=; b=mruWrMCFW6RMfEEDiZhYEh+UBNOmZ48Fe/HNMU7cbgy/Wmqs2uhOKdKpQrDvXYM6k/ lHRhqVUMCkn/4ldqQqOxsDgLK3v51IOdDpMkHhMK/4WgC5Z6/LT1qlrinEbo771sWy/j xTaB9Yx7oA0hhfzA7ORnHOJxPhc+ctn3DS4u2GAoAdLjmzp+f0nNpgZfzX6XsMh32XBn yQBRPSERBtRHJs0eeo1uPTjQF3cxSmaF3Sat1ajdUvqY3cnjQKZdKin54LTOnBS8ZE40 tdkHMmN4WIdCLPohY1S9+BZLSvDXArd3Qf7gcMShetolEgsPdNYui/XF52kRGgCnY9VM i5Iw== X-Gm-Message-State: APjAAAXfbo6lFrV1N+85Ebe4sO0bkqboB9/oUIy6PiUC8bpnRmD7qrIo fsA/l2NL7YNABT/l2gst2VQFIKrQPbc= X-Google-Smtp-Source: APXvYqwth9a5pWxG+m5NO0S6icpRETKvSnVpUp65iWnN+zMtqNGXWRROX4C5aJEfoQA4gRGTNvKXSA== X-Received: by 2002:a1c:1aca:: with SMTP id a193mr4630574wma.40.1554224507308; Tue, 02 Apr 2019 10:01:47 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:f514:32e2:4dcd:993e]) by smtp.gmail.com with ESMTPSA id l8sm14719072wrv.45.2019.04.02.10.01.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Apr 2019 10:01:46 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <20190402163623.2gvlraa5qitzgi6y@Ergus> (Ergus's message of "Tue, 2 Apr 2019 18:36:23 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234881 Archived-At: >>>>> On Tue, 2 Apr 2019 18:36:23 +0200, Ergus said: Ergus> I just pushed a new branch with the fill-column-indicator Ergus> feature. I would prefer to rebase before pushing to the Ergus> master branch. (In my ideal world I will rebase and then do Ergus> a merge with -no-ff. But this is not the workflow you have Ergus> here) I took a quick look. It=CA=BCs three commits, including the NEWS changes. Any reason you don=CA=BCt want to squash those into a single commit? Ergus> So, how is decided when to move this to the master branch? Ergus> (the equivalent to accept the pull request) Ergus> There are changes in the NEWS already but not in the Ergus> manual. So, just tell me the following steps. The NEWS changes have some minor issues (spelling, two spaces after full stop, spurious whitespace), but the new user variables and modes need descriptions in the user manual. Robert