From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Thu, 05 Sep 2024 15:57:50 +0200 Message-ID: References: <8734mezkgo.fsf@gmail.com> <87plpis6ff.fsf@protonmail.com> <87bk124aip.fsf@gmail.com> <87h6aus5yz.fsf@protonmail.com> <87y1461frv.fsf@gmail.com> <864j6u47g4.fsf@gnu.org> <8634me447j.fsf@gnu.org> <861q1y437s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40197"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 05 15:58:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smD0M-000AHs-9C for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Sep 2024 15:58:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smCzn-0005XQ-32; Thu, 05 Sep 2024 09:57:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smCzk-0005X1-MG for emacs-devel@gnu.org; Thu, 05 Sep 2024 09:57:57 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smCzi-0004wS-U9; Thu, 05 Sep 2024 09:57:56 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5c0aa376e15so417596a12.1; Thu, 05 Sep 2024 06:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725544672; x=1726149472; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LaUl7rvWvipMSwv3xEOOG7IeGfJ6xnYBWChtrzvCbTk=; b=F4ziEwmGt1BGyZVxan2DX7yiyX4G079Nn3JQDF42NPjqQkph5WAaYz/tpurFOW4kdR W5a/CJbBO4SymZTobuTyLt7zgA/P3O1Evjrc+SSTcwv7OvVJYl55f++iRTvFP6XFpLRL d8wHaJZsyAg0MMwMJ+pZCMoXq9+Tqjx3z/r/afqAXpjkDI42zm+J7t0O7gOMDEDWaDSq I3YLjx/0sumaJanMyuRS4J7tBI7Ey8wC2nS2zofSigd0gMqhUFXPXs+K/TrudgS0EdJ+ xKsfvzhP1uEkh0Lix3RNKaFczdCB4PDADkfUhY42PMsv/KVb52MoaF8KFLtqCfE3xAXu c29g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725544672; x=1726149472; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LaUl7rvWvipMSwv3xEOOG7IeGfJ6xnYBWChtrzvCbTk=; b=gfZYdPw85PBGJA0rDJNXTYduC74HpUlqR5cCwe/MrsopT4km2tb4CClieUgcnuZ0JB dPWxTX2nrsULqEXt3jQx3CG9vGV/puqHufOav3y+UlkyiBG9vEErZefvnPV3W7JV61Nj XYRZh/hrOOMfeRISY0HjhbeER7LYwCapNk+imeiuMfoxsVzUI7S+vm3QDJe76OsdCGLx dkfnXXEI+tVlNPhNHOqV/KaTbIINNUUWPIJbTCOLf5kbTm2+6meUy4o5ahNOnpHI+Hs4 AljGymFjheze26N96tDI0VEQ1jB7s3RiWNDIWM+zsSZYnLoYPlnxqW5nKqknbXm16s61 zfCw== X-Forwarded-Encrypted: i=1; AJvYcCVLdrOTwEJ0/wQuudOI4CmGn6UZEbkBYS+cRxHAO7uWWESTnHE1IZkmXFMV9c0VjlrXR4I1vjpkgrVXrQ==@gnu.org X-Gm-Message-State: AOJu0Yz/e8erXaW/l8TvvBNhudfJalh2JY8OYUfEbW9uh8fS8KB1LfMl yyYp5JTw/ywwdOwxY82iWePzXOJhl2dbzBU+W0vv9fbLYiIzL3ecFWXChg== X-Google-Smtp-Source: AGHT+IFq3y9sVfSSPEx4GenZRY03KD/y4CinWA3tClOVEzJ+4XdDMzotSRXVLE4/os0GKdXokB7/2g== X-Received: by 2002:a05:6402:528f:b0:5c2:6bb8:1859 with SMTP id 4fb4d7f45d1cf-5c3cd78cbbamr2355084a12.19.1725544671418; Thu, 05 Sep 2024 06:57:51 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3af05.dip0.t-ipconnect.de. [79.227.175.5]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3cc52ebfcsm1275035a12.20.2024.09.05.06.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 06:57:51 -0700 (PDT) In-Reply-To: <861q1y437s.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 16:52:55 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323408 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org >> Date: Thu, 05 Sep 2024 15:37:38 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> Hm, sesms we have to check for FRAME_OUTPUT_DATA being null for window >> >> frames. >> > >> > Why do you think so? Are we sure FRAME_OUTPUT_DATA is NULL in this >> > case (as opposed to a pointer that cannot be dereferenced because it >> > was moved)? >>=20 >> I would be 100% sure only if I had it in the debugger :-). >> But if you look a bit further down in fix_frame: >>=20 >> if (FRAME_WINDOW_P (f) && FRAME_OUTPUT_DATA (f)) >> { >> struct font **font_ptr =3D &FRAME_FONT (f); >> if (*font_ptr) >> IGC_FIX12_PVEC (ss, font_ptr); >> Lisp_Object *nle =3D &FRAME_DISPLAY_INFO (f)->name_list_element; >>=20 >> That means FRAME_OUTPUT_DATA can be null during the lifetime of a >> frame. If that happens, we'll crash exactly in that way in the new code >> for window frames. > > We never test for FRAME_OUTPUT_DATA being non-NULL in the code, so I > don't think I understand why igc.c is different. Our scan functions can run at arbitrary times, including when FRAME_OUTPUT_DATA is still null.