From: Alex Bochannek <alex@bochannek.com>
To: 73763@debbugs.gnu.org
Subject: bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number
Date: Fri, 11 Oct 2024 20:45:53 -0700 [thread overview]
Message-ID: <m2msjaf0ge.fsf@bochannek.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
Hello!
I am using the SRC back end to VC and noticed `^J' after the revision
number in the mode line. This appears to be due to the way the output of
the `src list' command is converted to a string, which keeps the
newline.
The following patch has been tested under macOS Sequoia 15.0.1 and
should be equally applicable to other platforms.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-unnecessary-trailing-white-space-from-SRC-rev.patch --]
[-- Type: text/x-patch, Size: 958 bytes --]
From 37d0c418b633f588c8162704630e422afecbf5df Mon Sep 17 00:00:00 2001
From: Alex Bochannek <awb@awb-mbp-m3.local>
Date: Fri, 11 Oct 2024 20:32:41 -0700
Subject: [PATCH] Remove unnecessary trailing white space from SRC revision
number
---
lisp/vc/vc-src.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/vc/vc-src.el b/lisp/vc/vc-src.el
index 27f58cb3369..ff19b0f7696 100644
--- a/lisp/vc/vc-src.el
+++ b/lisp/vc/vc-src.el
@@ -222,8 +222,9 @@ vc-src-command
(defun vc-src-working-revision (file)
"SRC-specific version of `vc-working-revision'."
(let ((result (ignore-errors
- (with-output-to-string
- (vc-src-command standard-output file "list" "-f{1}" "@")))))
+ (string-trim-right
+ (with-output-to-string
+ (vc-src-command standard-output file "list" "-f{1}" "@"))))))
(if (zerop (length result)) "0" result)))
;;;
--
2.39.5 (Apple Git-154)
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
--
Alex.
next reply other threads:[~2024-10-12 3:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 3:45 Alex Bochannek [this message]
2024-10-12 12:40 ` bug#73763: 31.0.50; [PATCH] Remove unnecessary trailing white space from SRC revision number Eli Zaretskii
2024-10-12 17:22 ` Dmitry Gutov
2024-10-12 18:22 ` Eli Zaretskii
2024-10-13 8:36 ` Sean Whitton
2024-10-13 17:50 ` Alex Bochannek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2msjaf0ge.fsf@bochannek.com \
--to=alex@bochannek.com \
--cc=73763@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.