From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "O'Brien, Will" Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Tue, 17 Dec 2024 08:34:05 +0000 Message-ID: References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24760"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Robert Pluim , Eli Zaretskii , 74786@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 17 16:20:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNZNA-0006Gf-PR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Dec 2024 16:20:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNZMw-0004G3-OH; Tue, 17 Dec 2024 10:20:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNZMk-0003zV-TS for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 10:20:09 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNZMk-000479-Jk for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 10:20:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=uhAice5Eg42NhONDPpStQuQHTPYEEK5e/QWBKwQ4s9Q=; b=LB7ctfGdsrHQjbeRrRhNP+JW7Jas/Bpss7dzDM+7F/TA0KAMi2ydDfz/pxu/Kd6GCdLVJ1gd0Rxacjc9aqKVfBrPxz9yHR57dRyCT/zDH1mPKZXwobvzU07TOGW8YObf4fKsRM5PPspAwypCPW4yMzeoQbhfXylxK2dWvn8s0C8BzKYofE2ROb6fowCgqwAUptEoz8smqIUzSBUTKfm6JfTrKhLb1KW/Mj1vIwzUJk6RGqC1u/qdnbHe8XJFAgoS7GJo9LApWPa1EIflKQNTeftRebwt/iIAFY2TXLkN8zqJUGlmmO4PmqEDJKwnSEfiRE0xxk7TV3joQ2YbuPt8Dg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNZMj-0005Xf-Ir for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 10:20:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "O'Brien, Will" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Dec 2024 15:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.173444879221243 (code B ref 74786); Tue, 17 Dec 2024 15:20:05 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 17 Dec 2024 15:19:52 +0000 Original-Received: from localhost ([127.0.0.1]:59907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNZMW-0005WW-4y for submit@debbugs.gnu.org; Tue, 17 Dec 2024 10:19:52 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:59789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNT2q-0002AH-7t for 74786@debbugs.gnu.org; Tue, 17 Dec 2024 03:35:08 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-436281c8a38so32798555e9.3 for <74786@debbugs.gnu.org>; Tue, 17 Dec 2024 00:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734424447; x=1735029247; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uhAice5Eg42NhONDPpStQuQHTPYEEK5e/QWBKwQ4s9Q=; b=cgn6okZxw7XYTt0mojEMWMzg0ZfukzLZ0LemgnqM/axG5QvVbRUrb80j+sfGt6kY1s +8rZJkn2JDOBPjNhfnv7mUmI6fMzNUiyFusE16GJyyC4gb6zWA5tfzuvaakdFemtUkTO n5kPQz7+kANavsUctvg8zShSNuV6vBURrz7GKIXAoTDgbNjClmrM3Dr47ODYgF9Kn427 m945rOTyQtd10Ntv/OSUNoRtqyHKRiPxixLpP4Nobyhgj3CVkavRmjK1/r5EokOjmVTe QZuBUzSET/7nFa2UDdVzJyl8fISdF1jJCrD9zAHJenNyzn7P4RpO5vcX0L7wgLT5mbJP YidQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734424447; x=1735029247; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uhAice5Eg42NhONDPpStQuQHTPYEEK5e/QWBKwQ4s9Q=; b=S+AxtksUh+W4sydtEdOo5iSKFDNMBhZwYF0+8FXgpNXtYcthlBP7o40dlKtAEwpo4I DGimOGLGykNhK1Poz0EgL7dsg0FByd15JUYc2P3tbNpn9iXusLsRoraw5vGNVMack7/h p6pRHx4RS4BCPOj05BnQ/a5+xieHx39dFjH86TzefM3HH5inwXWxLwkq/SPByc2HvEKV NR03Uc0CBHC5mHePiBiD/uXcsyag6jYAWxF7UG+y/c7tiZ7jeN/0n6Hrd5L6AAiz1DHq 3nCnGfnE432gRvdG65hBuy1rkw4e/aV/ImdumTB5Hjcqvs0I0fZJzXz2jUKKRFxPkGhy qwkw== X-Forwarded-Encrypted: i=1; AJvYcCW0PnMhDvitEw2LfQpvU4NGLCCOT2rN/xvZ93W21ZJru6QEFhNkQ9a0HJ7YgyyygOfs2iLpFQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwG+PVJ9WbPZpScXIefZVoT585bj3Tyf/1z8zbdtUQGBiOwntJl fJ+FUVrid1yhwKSIWgT5PEyBA4eBBTdawd4hTo2nNWcLUBklz0Yz1PCBS37DjEECbg== X-Gm-Gg: ASbGncujc2x61CiapnXjIxWQFQsjjxdSwGZIvVFkuAtr4bojqI1YfeJ5rSufyv2L4Pa cmppULVzwRpASyzuNaTcRCEwAhAyslchLTXqZ3sw5/WRyuFsUV4zQWPw7g2Ols1oCKS8RbaNr5/ +qapU8UvS1tPfGjekGMMhGE4gfUAPcFCV3US1h7zmrWMsiPGR7oH34ke0lrKFe2j+davKXF5tti uSFKn551/3uY659AVju3mHWFfyCep//gPpybf1bgNCyOdhzmXwVkK0sfY/NSshdEcRR3TrX52VQ ufeR3L4LFc4Lq9UR0kI= X-Google-Smtp-Source: AGHT+IHCVw0GGWujOtjqhGxGGgOYAmb+RfwXqrKO517/sHHkskA6buXcGT/qWBRSWEyulDwBscp3LQ== X-Received: by 2002:a05:6000:1fa9:b0:386:4acd:4d77 with SMTP id ffacd0b85a97d-3888e0b8b65mr13471412f8f.44.1734424447420; Tue, 17 Dec 2024 00:34:07 -0800 (PST) Original-Received: from Wills-MacBook-Pro.local ([2a00:23c7:253d:cd01:e1f5:b71:ad4c:a24b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8012034sm10360087f8f.22.2024.12.17.00.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 00:34:06 -0800 (PST) In-Reply-To: (Randy Taylor's message of "Sun, 15 Dec 2024 02:17:55 +0000") X-Mailman-Approved-At: Tue, 17 Dec 2024 10:19:50 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297304 Archived-At: On Sun, Dec 15 2024 at 02:17, Randy Taylor wrote: > On Wednesday, December 11th, 2024 at 11:31, O'Brien, Will wrote: >> [...] >> >> Ah, thanks! I've attached a new patch with the simplification. >> >> best >> -- >> will > > Thanks for working on this. > > +(defcustom go-ts-mode-test-args nil > + "List of extra args for the Go test commands." > Should we call this `go-ts-mode-test-flags' instead? > That seems to be the parlance golang uses, and there is an official > `-args' that go test supports that has a specific behaviour: > -args > Pass the remainder of the command line (everything after -args) > to the test binary, uninterpreted and unchanged. > Because this flag consumes the remainder of the command line, > the package list (if present) must appear before this flag. > > + (compile (format "go test %s -v %s -run '%s'" > + (string-join go-ts-mode-test-args) > With the above in mind, we may want to move the %s to the absolute > end so that -args could be used without catastrophe. Got it. Right I'll work on this and test out a few options with combinations flags. > This will also need a commit message and a NEWS entry. > See the CONTRIBUTE file for details. Ok, will send new patch with code changes and NEW entry along with a commit message. Thank you! -- will