From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: igc, macOS avoiding signals Date: Sat, 28 Dec 2024 14:28:57 +0100 Message-ID: References: <799DDBC5-2C14-4476-B1E0-7BA2FE9E7901@toadstyle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: pipcet@protonmail.com, emacs-devel@gnu.org To: Sean Devlin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 28 14:29:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRWt6-0005YW-Em for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Dec 2024 14:29:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRWsM-0004OX-6m; Sat, 28 Dec 2024 08:29:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRWsL-0004OP-2k for emacs-devel@gnu.org; Sat, 28 Dec 2024 08:29:05 -0500 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRWsH-0008MZ-K5 for emacs-devel@gnu.org; Sat, 28 Dec 2024 08:29:03 -0500 Original-Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-aaeecbb7309so617448666b.0 for ; Sat, 28 Dec 2024 05:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735392539; x=1735997339; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zo5aT3P6BBGw8N8wmXJgEcpBcUFrWR/Go/1oNcp7IcQ=; b=Hsc4aGkE7lMdJlk62kq6KN4tZiJmO7YT1gh02UqnAbI63DnPLM+RP2mDNtGEWzpWgc kRdTiAceB3KbzwJouG9FeBNli40+mg9zPdJjQBKBK4IPtqcgQRMG4jhSj6Zf1eIEr6D7 odHCyKr4nJCcfajqG641AoqAIZ0gnCdg4j5/tX+/3fed5O4PVyE4yfou1qY2PeVYlMaH ZyUXOzFbDCTXXEEzrhx5q48p7Vfcdt91djbpXwWhq3+EpoQl9iOrmgy2zyDSLKcICsdf hzlA1QR9EJLAapj8ceYBvfbf0nGVFG+r8slstefFZ564BGh5j2Jk5zqLcQikEzQrND6p lh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735392539; x=1735997339; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zo5aT3P6BBGw8N8wmXJgEcpBcUFrWR/Go/1oNcp7IcQ=; b=InIHQcTCoDmHgssdlEatXjsq18RZbju0F0QUbpNPJNJbIN/0LL4UPGLT+iD4zOH0QA A+LTCXZ4k8bq8MDYrV7SEYq9/UnQIKNrP5YgrRhZoiKe6DEoGBf3bJalYCeOOzaXdVZ0 YvGk4xFMGEpx7+6bQyBvNinZWuGzO961DBRQQOM5cKJg8+T3kb6+NoeMoi/35gqPCOan 4Zu8Fo2+4hvkipc26EkV3KAZvJrPMdPSKS9jSsmw5CE5i0K69LPUkLr52K9WZipr01bX MeSw8uJRFhQKCi1qnG5lB03sBPdtjz3CZyfFonqSGbgJZZxe2dLWq/8JEFCtKvq0Q+d1 6UgQ== X-Forwarded-Encrypted: i=1; AJvYcCWWiVnZ47XSmDDJd+5IYDPqh9saoHGevxs7T0kWY0GOYSYBPXdBrQVEgBC9rG0rP4j/UpbU514c167PMg==@gnu.org X-Gm-Message-State: AOJu0YwYnnp9kI5eukfJuWFv6SdeiFQLIWKFFqgHYe1Ice21XlDbgTLc RKspAR2GK9RM4/YP4MmzpNSTsrOH4ORNKJiYRxDpOb1pPYUj2y1dWgws9A== X-Gm-Gg: ASbGncvmNjjE+HRQlWLBMX65s+ZyEo/Oaggq817RXH/1qTYtboe4j9AGExxZkiyglzb sy1YTqYCjcI2DwXT8qeusnOEBpvbBKdzU70oF7JTxky29RK1DVHZkbA2k5OmxDqhXKHm8b2qDs4 mfLE6kxj2UwL7qQ7sB1ZigrLPF8JyF4Rr/QhJwQ7wFdFceOn0r3I9Yg1c7iYbB4ZZNEj4k6oH/M KS6lZVptCb7Z1bO5ioel8FQC471MZueHl4Vhg3/qkNAxHpygKzjr65yvmNHqO7QPkMPHsM2c8Vb SQiFrGR2t+/o2GMZvx3cEat0XiSJkFEilj/D1JhFY/qkocEAwaVuB9YKON8/iM/QMw== X-Google-Smtp-Source: AGHT+IHc9Ab+WrF1Fh0a/sEIEJXKw1q3MTZkkK3Y7UiMY6ZTwZynu1WCpvi/9k1Ukx5d01nYGvRIKA== X-Received: by 2002:a17:907:2cc5:b0:aa6:96be:2bed with SMTP id a640c23a62f3a-aac3378cbd9mr2330795166b.59.1735392538575; Sat, 28 Dec 2024 05:28:58 -0800 (PST) Original-Received: from pro2 (p200300e0b706e400c44cad3d21adb953.dip0.t-ipconnect.de. [2003:e0:b706:e400:c44c:ad3d:21ad:b953]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e89617bsm1235122566b.76.2024.12.28.05.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 05:28:58 -0800 (PST) In-Reply-To: <799DDBC5-2C14-4476-B1E0-7BA2FE9E7901@toadstyle.org> (Sean Devlin's message of "Sat, 28 Dec 2024 22:24:49 +0900") Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327262 Archived-At: Sean Devlin writes: >> Pip Cet writes: >>=20 >> > Gerd M=C3=B6llmann writes: >> > >> >> This is about commit >> >> >> >> ceec5ace134081b64dbf46c4fb5702ef5209c5fd >> >> Avoid MPS being interrupted by signals >> >> >> >> I've been running with this for some days now, and must report that >> >> Emacs feels a _bit_ different here in interactive use, maybe one could >> >> say not as smooth. (macOS, --without-ns, in my fork of Emacs, which is >> >> very recent master++). >> > >> > I think we should quantify that. Set a watchpoint on >> > igc_global->signals_pending, check how often we even set that, and how >> > often we call igc_maybe_quit, particularly if we were previously idle. >> > Maybe it's sufficient to call it again from the idle handler. >> > >> >> After reverting the commit, it's feeling smoother again. >> > >> > Entirely possible. Let's measure it. >>=20 >> I'm sorry, but I pass. It's too time-consuming for me. Maybe someone >> else using macOS can do that. I just wanted to make you aware of this. > > I can take a stab at this. I=E2=80=99ve been running the scratch/igc bran= ch on > macOS using the NS build. > > To be clear, I should make sure to include the above commit in my > build? Or should I not include it? Just let in in. I reverted it only in my Emacs. > When I take my measurements, are there any kinds of tasks I should try > to perform? What durations of time should I try to measure? > > Cheers. That's something for Pip to tell.