Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows]

[Andrew Choi <akochoi@shaw.ca>]

Juanma Barranquero <lektu@terra.es> writes:

> [...] the following patch would do, I think.
> 
> Basically it makes sense to extract the definition of XColor from the
> three or four places it happens now and define it specifically in the
> *gui.h files of the platforms that need it (w32gui.h and macgui.h at
> this moment). The same bug is also present in EMACS_21_1_RC, BTW. If the
> patch is approved it should be applied to the pretest too.
> 
> It works on my system. I've not commited the patch because I don't want
> to change Mac files without Andrew Choi's approval, specially as I
> can not test the changes on that platform. 
> 
> I've maintained the #ifndef HAVE_X_WINDOWS guards. On Window systems
> probably that's unnecesary, but on Macs I bet they're needed if you
> happen to build on Mac OS X.
> 
> Comments?
> 
>                                                            /L/e/k/t/u
> [...]

Thank you for taking macgui.h into consideration.  I've just checked
that the change works fine on Mac OS X.

I believe the `#ifndef HAVE_X_WINDOWS' is needed when compiling for X
Window on Mac OS X.  Please keep it around.  Thanks.