From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#28817: incorrect NEWS entry about vc-state faces Date: Fri, 13 Oct 2017 20:28:44 +0200 Message-ID: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507919437 25190 195.159.176.226 (13 Oct 2017 18:30:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Oct 2017 18:30:37 +0000 (UTC) To: 28817@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 13 20:30:31 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34io-0003nc-AT for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 20:30:10 +0200 Original-Received: from localhost ([::1]:51471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e34iv-0007ba-Qc for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 14:30:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e34in-0007Zx-71 for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:30:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34ii-0003yz-9i for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:30:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57926) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e34ii-0003ym-60 for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e34ig-0000im-Hs for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28817 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15079193732702 (code B ref -1); Fri, 13 Oct 2017 18:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Oct 2017 18:29:33 +0000 Original-Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34i9-0000hS-Oe for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34i5-0000h9-1n for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34hv-0003ge-Tr for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:19 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e34hv-0003gZ-Qj for submit@debbugs.gnu.org; Fri, 13 Oct 2017 14:29:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e34hr-0007XZ-OY for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e34hm-0003VC-Qw for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:11 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:59166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e34hm-0003TU-Hm for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 14:29:06 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 6DB6C2256A for ; Fri, 13 Oct 2017 18:22:23 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1507918939; x=1508782940; bh=f6fOBhlPNPRPNYVp/opw5cl6Q+orOZHqeRj jP6ADhc0=; b=HsUapC9H6q93AqZI2A/3fzNvV3iMn1a6louDZQktQwJdKzhz84W LpNaOET2gqXqLUtzYrG9zRlTRBfhP0Sycj/9U37xMJSaxdfY94ptU5hi+pCHBzk/ zD+U9gT2jvofuXXKGqwmZjV8srnNZx0cC2X6qte+ywDGJP1Jfu4PUa90= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CPcoBnbW9BjU for ; Fri, 13 Oct 2017 18:22:19 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id E9BD822564 for ; Fri, 13 Oct 2017 18:22:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138355 Archived-At: In the 26.0.90 NEWS file we have: *** The VC state indicator in the mode line now defaults to more colorful faces to make it more obvious to the user what the state is. See the 'vc-faces' customization group. which was added in these commits: * | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator commit 65fa442f2bae42d3f9b06264ca432073ee3197c3 Author: Lars Ingebrigtsen Date: Tue Mar 1 14:31:35 2016 +1100 Add a NEWS entry for the colorful VC indicator * | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b Author: Lars Ingebrigtsen Date: Tue Mar 1 14:25:27 2016 +1100 Use colors in the VC mode lines * lisp/vc/vc-hooks.el: Make the mode line faces default to using colors to more clearly tell the user what the status is. The NEWS entry commit seems to have made it to Emacs 26, but the mode line faces are still the same as in Emacs 25. Looks like commit 2621c29 got lost somehow. Also, not sure why this group is defined (in vc-hooks.el): (defgroup vc-state-faces nil "Faces used in the mode line by the VC state indicator." :group 'vc-faces :group 'mode-line :version "25.1") then never used. It looks like the vc-state-*/vc-*-state faces are meant to inherit from it, but it's not clear. It also makes the customization buffers confusing.