From: charles@aurox.ch (Charles A. Roelli)
To: 28817@debbugs.gnu.org
Subject: bug#28817: incorrect NEWS entry about vc-state faces
Date: Fri, 13 Oct 2017 20:28:44 +0200 [thread overview]
Message-ID: <m2lgkelx5v.fsf@aurox.ch> (raw)
In the 26.0.90 NEWS file we have:
*** The VC state indicator in the mode line now defaults to more
colorful faces to make it more obvious to the user what the state is.
See the 'vc-faces' customization group.
which was added in these commits:
* | | | | | | | | | | | | | | | | | 65fa442..: Lars Ingebrigtsen 2016-03-01 Add a NEWS entry for the colorful VC indicator
commit 65fa442f2bae42d3f9b06264ca432073ee3197c3
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date: Tue Mar 1 14:31:35 2016 +1100
Add a NEWS entry for the colorful VC indicator
* | | | | | | | | | | | | | | | | | 2621c29..: Lars Ingebrigtsen 2016-03-01 Use colors in the VC mode lines
commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date: Tue Mar 1 14:25:27 2016 +1100
Use colors in the VC mode lines
* lisp/vc/vc-hooks.el: Make the mode line faces default to
using colors to more clearly tell the user what the status is.
The NEWS entry commit seems to have made it to Emacs 26, but the mode
line faces are still the same as in Emacs 25. Looks like commit
2621c29 got lost somehow.
Also, not sure why this group is defined (in vc-hooks.el):
(defgroup vc-state-faces nil
"Faces used in the mode line by the VC state indicator."
:group 'vc-faces
:group 'mode-line
:version "25.1")
then never used. It looks like the vc-state-*/vc-*-state faces are
meant to inherit from it, but it's not clear. It also makes the
customization buffers confusing.
next reply other threads:[~2017-10-13 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 18:28 Charles A. Roelli [this message]
2017-10-13 18:41 ` bug#28817: incorrect NEWS entry about vc-state faces Eli Zaretskii
2017-10-16 14:34 ` Charles A. Roelli
2017-11-21 19:40 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lgkelx5v.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=28817@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.