From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Wed, 19 Dec 2018 09:32:52 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <225c3958-7adf-ce9a-f7f5-c4531b8b6058@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545208301 17249 195.159.176.226 (19 Dec 2018 08:31:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 08:31:41 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 19 09:31:37 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZXGS-0004Mv-AG for ged-emacs-devel@m.gmane.org; Wed, 19 Dec 2018 09:31:36 +0100 Original-Received: from localhost ([::1]:58282 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZXIY-0001V8-Mu for ged-emacs-devel@m.gmane.org; Wed, 19 Dec 2018 03:33:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZXHr-0001Up-Rf for emacs-devel@gnu.org; Wed, 19 Dec 2018 03:33:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZXHm-0007nI-SD for emacs-devel@gnu.org; Wed, 19 Dec 2018 03:33:03 -0500 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:33860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZXHm-0007n2-LR for emacs-devel@gnu.org; Wed, 19 Dec 2018 03:32:58 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id j2so18581591wrw.1 for ; Wed, 19 Dec 2018 00:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=ug8kUiYbHCvzNT75WXxqVVDAgKFy/WwU7Grv+9Z0vJw=; b=o8GHwgAIkGmaBEWK2uMceiDr0wyOUQ0ypjXSkA8CYfhk6rH/1d8c9cIclWkMmSOn92 V6ghcgYuirxw2ytt5k8KnZ2t/EhWMBEA3DH4ObjaE/vgKBEkrAl3F60eFuOYbbv1TOQG cnPz6N8g3K+Pp8G/8RoPhargHDPK24AqQg3mafeeiq2b8OER+LCYj2DMB4yTLFJaEARY l8L14ioui3+3MA+sVNfNeR0WDmc6LWrJblhvcNwZhQiPkol1mvRBHH8xdJm295hi7tMX xJw8ZosuJvoNh2d2MNwPS8HE0Em4CELpJfor8AB75LYxGm3jn+vIUhtzpwoSyhHsLdpg VISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=ug8kUiYbHCvzNT75WXxqVVDAgKFy/WwU7Grv+9Z0vJw=; b=be8Q+o1Jh/OkMosAdsYhPmmexmcAIT3bbHN83wPC06SYPky2KWkB2W/zgoH+vuW+S8 APsBZG19VWFbyPjrcye352AlS5/QH8FyJNzIg2Vp5erVkw2crvtXAlWpGyfdhtZIHyOJ BF1RxMonlzobeoMgvyiJtT/rdflBD+WCN9jNBHJ8wVYbyBPrgqdU7uNAT/+ZJnu4xHw9 uaQ7IsuALLXDWpw4Ne3nKe7Oh015H2mzJZJFAG5lITDXJ7RAW9NqOTQhLg7E23cxo8vG MBcfbkZN7PixRwSB/mZmwSqhg/fV5Z2jOO2kGMJDoB9xwJ7YssSM1Xa7eWfUiqSIY+Ex 6GtA== X-Gm-Message-State: AA+aEWYhSM/XJs8ZVX+KE6iSMsKJ6RxDBEw6pfhlHWK3clxjKQNZnMio krkRhiQeFJn2Mk5ANM4p1LsusNFh X-Google-Smtp-Source: AFSGD/XMVQkFP/l1jeW1mfWW0nmX20gwRD9t8MP5pFydLDwAb4/JyU18qcE7visp1R2FblkZxMasRg== X-Received: by 2002:a5d:4d46:: with SMTP id a6mr17941235wru.28.1545208377121; Wed, 19 Dec 2018 00:32:57 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id x76sm11266588wmd.27.2018.12.19.00.32.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Dec 2018 00:32:55 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Robert Pluim's message of "Tue, 18 Dec 2018 09:23:05 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231918 Archived-At: Robert Pluim writes: > Paul Eggert writes: > >> Thanks, looks good to me too. One minor point: >> >> On 12/17/18 4:41 AM, Robert Pluim wrote: >>> +#ifdef HAVE_XFT >>> +#include >>> +#include >>> +#endif >>> +#ifdef USE_CAIRO >>> +#include >>> +#endif >> >> Please indent the include directives by using "# include" (with a >> space after "#"). > > Fixed. BTW, Emacs has ~500 instances of this rule not being followed. I=CA=BCm assuming that a mass change (similarly to mass whitespace fixes) would be frowned upon. Robert