From: Robert Pluim <rpluim@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: Compiling pdumper.c fails with gcc 4.7.2
Date: Thu, 24 Jan 2019 10:28:50 +0100 [thread overview]
Message-ID: <m2lg3av1yl.fsf@gmail.com> (raw)
In-Reply-To: <5C497FE6.4010601@gmx.at> (martin rudalics's message of "Thu, 24 Jan 2019 10:05:42 +0100")
martin rudalics <rudalics@gmx.at> writes:
>>> With gcc 4.7.2 compiling pdumper.c fails thusly:
>>>
>>> CC pdumper.o
>>> ../../src/pdumper.c: In function ‘emacs_offset’:
>>> ../../src/pdumper.c:718:27: error: declaration of ‘emacs_ptr’ shadows a global declaration [-Werror=shadow]
>>> ../../src/pdumper.c:710:1: error: shadowed declaration is here [-Werror=shadow]
>>>
>>> Is there any practicable way to fix this?
>>
>> Sure, the emacs_ptr function is static, so it can change name easily
>> enough. Something like the following works for me:
>
> Thank you very much. I verified that it would have worked here hadn't
> Eli installed a different fix.
Eli chose a better, shorter name than I did :-)
Robert
next prev parent reply other threads:[~2019-01-24 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 9:10 Compiling pdumper.c fails with gcc 4.7.2 martin rudalics
2019-01-23 13:48 ` Robert Pluim
2019-01-24 9:05 ` martin rudalics
2019-01-24 9:28 ` Robert Pluim [this message]
2019-01-23 15:41 ` Eli Zaretskii
2019-01-24 9:05 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lg3av1yl.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.