From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#40502: 28.0.50; Hangul Jamo conjoining characters are not composed Date: Wed, 08 Apr 2020 14:11:19 +0200 Message-ID: References: <83pncipaig.fsf@gnu.org> <83o8s2p6o1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83733"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40502@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 08 14:12:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jM9Yx-000LeJ-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Apr 2020 14:12:11 +0200 Original-Received: from localhost ([::1]:35198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jM9Yw-0007d4-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Apr 2020 08:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33855) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jM9Yp-0007ch-32 for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2020 08:12:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jM9Yo-0004s5-0G for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2020 08:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39941) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jM9Yn-0004re-SR for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2020 08:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jM9Yn-0008Q9-LI for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2020 08:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Apr 2020 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40502 X-GNU-PR-Package: emacs Original-Received: via spool by 40502-submit@debbugs.gnu.org id=B40502.158634789032331 (code B ref 40502); Wed, 08 Apr 2020 12:12:01 +0000 Original-Received: (at 40502) by debbugs.gnu.org; 8 Apr 2020 12:11:30 +0000 Original-Received: from localhost ([127.0.0.1]:51487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jM9YH-0008PP-U2 for submit@debbugs.gnu.org; Wed, 08 Apr 2020 08:11:30 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jM9YG-0008PA-Ck for 40502@debbugs.gnu.org; Wed, 08 Apr 2020 08:11:28 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id s8so7514542wrt.7 for <40502@debbugs.gnu.org>; Wed, 08 Apr 2020 05:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=E6uOr6je47vEihheLSEchU0f19M6DzwB/iJ9kTCf/1Y=; b=ciyfyNncAImzxxIim0UWOr6We+tVF/P8zLpoQYMkojqpJIS4uat7oxCUmi4vZeegTW uah4DnKnQz+U6xjQ51Ed/92BBv7qQj3mAIGbeWbav6RGnlqahD8tZSBC4Fd/LbTwEsQ5 mWoVqP4nl1GH4g8paqkL74AWdizs1UpJMjwd1XOpnDwY4mnt9RZcPUU5scVXedTvLaFN Vue+ztkH29tkeq086MEoU8oLIxcMpTy8FweaEyh8PkWNpnmfjIcc685yVjWH84mUu7qF Ia1OCIjj8th0hKoCNESW31zn11txdj3qNG4yHFCiZyRjaXO0ulIxkBRPFujpZydYQ0Qg G8nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=E6uOr6je47vEihheLSEchU0f19M6DzwB/iJ9kTCf/1Y=; b=uaY2tM6bUFAEjsujzXOLExogslNaxqwFvpZOQUy4rGJxWw4F0z3bJlGs3T+oJO2hmd DLjekYRsKXH+FBc09BZkDBEWQ2pzah2lhxXWc+xsKX3FRKJL0hKphlXJnKua1xYw4bBD JwvnWC4q4JKBnSYo3Bh3tn3Grpp69Y2JTaGU47XfB/NbzswJAoH2fRMCECv2QM//kjQ/ C6IEqSTU1pdnrBUvH7uzBRiIL4GxkEuB9C5OnGOaDukyp0YKP3cj53dkkevIByHEuWSB Arr7EGQtI6sXMBa8p9948YDgsMm43bLKXac0k5aCS3jV6G1JXy0gzec0R4RGATmYyVoX A/KQ== X-Gm-Message-State: AGi0PuYO82E0YfqH+/VOGZHT4AvvUOJNKi/PuThukBJ4QPOopCHVBvxE AKcWR5pC/NkTHkWqWkFwPYISHj1D X-Google-Smtp-Source: APiQypLpFogi62N50U2mTYOgKw1SzaQCqQoN2BNjgskI7R7aKS9kqBrmbX5XAj4MtUJyWvVS0WrbDA== X-Received: by 2002:a5d:5742:: with SMTP id q2mr6349828wrw.414.1586347881826; Wed, 08 Apr 2020 05:11:21 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:6806:a3f2:d306:50b4]) by smtp.gmail.com with ESMTPSA id k184sm6491089wmf.9.2020.04.08.05.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2020 05:11:20 -0700 (PDT) In-Reply-To: <83o8s2p6o1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Apr 2020 14:18:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178133 Archived-At: >>>>> On Wed, 08 Apr 2020 14:18:22 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 40502-done@debbugs.gnu.org >> Date: Wed, 08 Apr 2020 12:11:56 +0200 >>=20 Eli> The call is incorrect: 'vector' should include both 0 and the func= tion Eli> symbol. >>=20 >> Yes. I misread the docstring of composition-function-table rather th= an >> copying the correct call I had sitting in a buffer already. Eli> Maybe we should improve the doc string? Which part was confusing? I don=CA=BCt know if it=CA=BCs confusing, just that it says: The element at index C in the table, if non-nil, is a list of composition rules of this form: ([PATTERN PREV-CHARS FUNC] ...) So I did (list (vector [..] then continued to read the docstring, and by the time I got back to the code, my brain conflated the brackets from the regexp with the ones from the vector, so I closed the list, and carried on. So entirely down to my brain fart. Maybe saying ((vector PATTERN PREV-CHARS FUNC) ...) would have helped, but it=CA=BCs too late to tell now. Perhaps we should have a macro or defun 'composition-function-add-entry' or somesuch to hide the details? And ensure that we=CA=BCre not overwriting previous entries. How often do people write these things? (defsubst composition-function-add-entry (char-or-range pattern prev-chars func &optional replace) "Add composition-function-table entry for CHAR-OR-RANGE. CHAR-OR-RANGE is a single character or a cons of character codes. Adds [PATTERN PREV-CHARS FUNC] to any existing composition-function-tab= le entry for CHAR-OR-RANGE. Optional arg REPLACE non-nil means replace the existing entry rather than adding to it. See `composition-function-table' and `auto-composition-mode' for more details. (or does this end up growing 'add-to-front', 'supersede', 'sort-then-insert' etc options? :-) ) Robert