From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55595: 29.0.50; Compilation warnings on macOS Date: Sun, 05 Jun 2022 12:51:43 +0200 Message-ID: References: <83pmk45jp5.fsf@gnu.org> <83o7zo5i3r.fsf@gnu.org> <83fskmev9z.fsf@gnu.org> <83r145aroc.fsf@gnu.org> Reply-To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55595@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 05 12:56:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxnw1-0008vT-JF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 12:56:41 +0200 Original-Received: from localhost ([::1]:59756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxnw0-0005Ry-1J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 06:56:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxnsV-0004wU-Sk for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 06:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxnsU-0003Fb-4Z for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 06:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxnsU-0000yY-0z for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2022 10:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55595 X-GNU-PR-Package: emacs Original-Received: via spool by 55595-submit@debbugs.gnu.org id=B55595.16544263223674 (code B ref 55595); Sun, 05 Jun 2022 10:53:01 +0000 Original-Received: (at 55595) by debbugs.gnu.org; 5 Jun 2022 10:52:02 +0000 Original-Received: from localhost ([127.0.0.1]:60147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxnrV-0000x5-Gg for submit@debbugs.gnu.org; Sun, 05 Jun 2022 06:52:01 -0400 Original-Received: from qs51p00im-qukt01080502.me.com ([17.57.155.23]:36855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxnrR-0000wm-6A for 55595@debbugs.gnu.org; Sun, 05 Jun 2022 06:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1654426310; bh=789MEYenqoRhNEd1Lj3kP1hIHUybZXSKmE+uqAE2qgc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ZyB2ZOtJeBvxhM+Ltl0WwFDA5+0bVvHZue1C+URGuGcsk3VD91IxxT5DPPuDfpeh7 g5EGUl74zXGQ6ADk4oLGKqvn+b7Gy7DHVMl/Nfuc1IXyAvea7abSDWOrLt+ALmdVFR GrDuvHv6uFxJW1MlMYHDMMYAAMg9wa4VEPkqjXYFTIDAnRqbjOWfHhLAD4O6XNlywa //XbDAvEfUYFAXYl1YciToNQXw/swPik/WbEIsevRIizzA0C16FnRkEvUwErmjJmY+ ZQdTwFp7saynupabQf+o1hAesPCAwJS2ulvvPYV30nMzZq/qgmmSP3eEiu92D/bxfd e2T7GqWGbKV/g== Original-Received: from Workstation.local (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01080502.me.com (Postfix) with ESMTPSA id 591574E400A2; Sun, 5 Jun 2022 10:51:49 +0000 (UTC) In-Reply-To: <83r145aroc.fsf@gnu.org> X-Proofpoint-ORIG-GUID: lDwN2MuRqtaB9lVwU8S9gU7p0BTEOTgh X-Proofpoint-GUID: lDwN2MuRqtaB9lVwU8S9gU7p0BTEOTgh X-Proofpoint-Virus-Version: vendor=fsecure engine=1.1.170-22c6f66c430a71ce266a39bfe25bc2903e8d5c8f:6.0.138, 18.0.790, 17.0.605.474.0000000 definitions=2022-01-12_02:2020-02-14_02, 2022-01-12_02, 2020-01-23_02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2206050049 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233702 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > I'm sorry, I'm flying blind here, as I have no access to this > compiler. I've now tried a more radical solution, please see if the > latest master branch solves this. I still see the first four warnings at 6011d39b6a: CC comp.o comp.c:2816:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ^ comp.c:4698:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ^ comp.c:4714:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ^ comp.c:4967:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas] #pragma GCC diagnostic pop ^ I wonder, why not add the missing pushes? When I apply the patch below, Clang reports 0 warnings. Would that break some other compiler or something? Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-diagnostic-push-pop-compiler-warnings-on-macOS.patch >From 7ae3ef0ad33062128858c29645f641230092f26d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Sun, 5 Jun 2022 12:04:49 +0200 Subject: [PATCH] Fix diagnostic push/pop compiler warnings on macOS * src/comp.c: Add missing "#pragma diagnostic" pushes. * configure.ac: Revert previous attempts to fix Clang warnings. --- configure.ac | 2 -- src/comp.c | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 313a1436b5..1d2d1f190b 100644 --- a/configure.ac +++ b/configure.ac @@ -1024,7 +1024,6 @@ AC_DEFUN gl_WARN_ADD([-Wno-pointer-sign]) gl_WARN_ADD([-Wno-string-plus-int]) gl_WARN_ADD([-Wno-unknown-attributes]) - gl_WARN_ADD([-Wno-unknown-pragmas]) ]) ],[ isystem='-isystem ' @@ -1085,7 +1084,6 @@ AC_DEFUN if test "$emacs_cv_clang" = yes; then nw="$nw -Wdouble-promotion" - nm="$nm -Wunknown-pragmas" fi # This causes too much noise in the MinGW build. diff --git a/src/comp.c b/src/comp.c index 97bc6a5f9d..ea376a4370 100644 --- a/src/comp.c +++ b/src/comp.c @@ -2626,6 +2626,7 @@ emit_maybe_gc_or_quit (Lisp_Object insn) /* This is in charge of serializing an object and export a function to retrieve it at load time. */ +#pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Waddress" static void emit_static_object (const char *name, Lisp_Object obj) @@ -4681,6 +4682,7 @@ DEFUN ("comp--release-ctxt", Fcomp__release_ctxt, Scomp__release_ctxt, return Qt; } +#pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Waddress" DEFUN ("comp-native-driver-options-effective-p", Fcomp_native_driver_options_effective_p, @@ -4697,6 +4699,7 @@ DEFUN ("comp-native-driver-options-effective-p", } #pragma GCC diagnostic pop +#pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Waddress" DEFUN ("comp-native-compiler-options-effective-p", Fcomp_native_compiler_options_effective_p, @@ -4943,6 +4946,7 @@ DEFUN ("comp--compile-ctxt-to-file", Fcomp__compile_ctxt_to_file, return filename; } +#pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Waddress" DEFUN ("comp-libgccjit-version", Fcomp_libgccjit_version, Scomp_libgccjit_version, 0, 0, 0, -- 2.36.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Be especially critical of any statement following the word 'obviously.'" -- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=--