From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS codegen Date: Sun, 16 Jun 2024 08:16:38 +0200 Message-ID: References: <878qz8ezn4.fsf@gmail.com> <8734pfgb51.fsf@gmail.com> <86ikybyd2h.fsf@gnu.org> <87v82bebc6.fsf@gmail.com> <86wmmrwf86.fsf@gnu.org> <86r0czwdmc.fsf@gnu.org> <87jzire36a.fsf@gmail.com> <86plsiwxag.fsf@gnu.org> <868qz6wsvq.fsf@gnu.org> <878qz6egtb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , acorallo@gnu.org, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 16 08:17:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIjCp-0004md-OQ for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jun 2024 08:17:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIjC6-0002vD-0X; Sun, 16 Jun 2024 02:16:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIjC1-0002tL-Ev for emacs-devel@gnu.org; Sun, 16 Jun 2024 02:16:46 -0400 Original-Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIjBz-0002Wk-Dk; Sun, 16 Jun 2024 02:16:45 -0400 Original-Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-57a44c2ce80so3997027a12.0; Sat, 15 Jun 2024 23:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718518600; x=1719123400; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hBBF/5j6p0pvx5hoFv4WznKWC7UTxnDvvSYazKAedRc=; b=SCh8g42TjivY/PefZBSteApjO7fasXIS0eKAvRpCRzkSnhn4g5qBCFaTo2GIFM9bx+ NBQA07LcoRZ/3kF/BHclRWRj3qVEcVOBDbtEuUdH0R/G1SkqCjwDdBuv1EdzFk63VEfc PB1BM3YU/WAmXvXy5dSoT/hUDLVLNjjjgkIk5qhHXfNL6F1hezsy1X/bOg8A12+dgq9D VBSFPypCPlGvoRgMDbZD1ePSiTVp/uHg4PMQoMIghTk3jvhrP+5YBcYqefBKLGhkEAyK jy+ZkBgrXpGO2w5diyOtehPKl4Y6IR1UODrX2MJex5Z/7e1DHBr0Vla79S+yWf8P/YzU 9foA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718518600; x=1719123400; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hBBF/5j6p0pvx5hoFv4WznKWC7UTxnDvvSYazKAedRc=; b=WKydNUvHe4O+nRaaaiydOx4np8gmKobruC26zkewwyhAnYLKV12knSmsOgGvtN7xL5 QE8CHsxaHJzmpo9ZB5o2lAvoNq8TWQlNRiMnLf5RpVS8vVvd0V8XO6c1FSz6b06tntJu nNThW7YpAdX7vcTiLV2Q8Ck9bpXCwj3T80UkXJRAkO++w1SSXW7Pe0BejgM4umx6RLfH L/4ZbHJgBcdF26DbJeiHgKbwTq0QczicTcf5uOPWANDTvhbBOdj3wiLrA0NFcPVcp2va w4RmpZObQ8X3m3rKHG9nKQI/2GJuXConAPuv+YqOrLC+/hTv/3zUnCEZ0yJ+ubT4PI9y XSuA== X-Forwarded-Encrypted: i=1; AJvYcCWrLRttmBsQJ181WnD4HeCOYJ34wS3CvbD8vB0mZxh1nI+dmRFIwonb4XWVkg5sXRJgoOhLqW3fIHR18HYj0t7M4xwKFm7SYOqCah9Rl3hvn7oFLyOA X-Gm-Message-State: AOJu0YyXlcL3+xEW4pJq09VPiwgNdTZ821tWL8QC2NbhjA2xz+asPqa1 r1bgVLrhLUVbcUHglLfC9fiKuZ+zBmfuFcjoTtH9DRuuYRSDlMwp7Nxc6g== X-Google-Smtp-Source: AGHT+IF5xKmAWYH+ab0nCZPhMlVz8pKpjV1WqzdOG8RFc+B83Qfz+JY1FajqtspwmFtw7X2+sKQF4g== X-Received: by 2002:a50:955a:0:b0:57c:ab4c:f05e with SMTP id 4fb4d7f45d1cf-57cbd68e5c0mr4219631a12.20.1718518600178; Sat, 15 Jun 2024 23:16:40 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36751.dip0.t-ipconnect.de. [217.227.103.81]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72da069sm4607979a12.21.2024.06.15.23.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 23:16:39 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 15 Jun 2024 14:33:05 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320179 Archived-At: Gerd M=C3=B6llmann writes: > pdumper.c:4937: Emacs fatal error: assertion failed: rc =3D=3D 0 > gmake[3]: *** [Makefile:335: emacs-lisp/byte-opt.elc] Abort trap: 6 > gmake[3]: *** Waiting for unfinished jobs.... > > which is soothing. > > I'm reluctant to invest more time though because this all si obsolete > with your change. Just had an inspiration what it might be, and it is indeed the case: Forwarded symbols are created like this #define DEFVAR_LISP_NOPRO(lname, vname, doc) \ do { \ static struct Lisp_Objfwd const o_fwd \ =3D {Lisp_Fwd_Obj, &globals.f_##vname}; \ defvar_lisp_nopro (&o_fwd, lname); \ } while (false) The pdumper copies these static structs to the dump, and when the dump is loaded, the symbol's forwarding pointer is changed from pointing to the static struct to the copy to the dump. Both have the same contents. IOW, the static structs are no longer used. Consequenlty, when accessing the structs to get their type (XFWDTYPE) we are accessing something in the dump. Why pdumper is doing that escapes me ATM.