From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthew Bauer Newsgroups: gmane.emacs.bugs Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Date: Sat, 29 Jun 2024 14:55:05 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6822"; mail-complaints-to="usenet@ciao.gmane.io" To: 71844@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 00:33:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNgdT-0001dO-5j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 00:33:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNgd9-0001oU-El; Sat, 29 Jun 2024 18:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNgd0-0001kO-Mp for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 18:33:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNgcy-0004Hy-WB for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 18:33:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNgcy-0003io-Ex for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 18:33:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Bauer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2024 22:33:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171970034414195 (code B ref -1); Sat, 29 Jun 2024 22:33:04 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jun 2024 22:32:24 +0000 Original-Received: from localhost ([127.0.0.1]:53990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNgcJ-0003gm-Lv for submit@debbugs.gnu.org; Sat, 29 Jun 2024 18:32:24 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNgcD-0003ef-Fa for submit@debbugs.gnu.org; Sat, 29 Jun 2024 18:32:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNeAI-0007Pn-UC for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 15:55:19 -0400 Original-Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNeAE-0000mf-Br for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 15:55:16 -0400 Original-Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7f3c5af0a04so88700839f.0 for ; Sat, 29 Jun 2024 12:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719690912; x=1720295712; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=TEK/P1XekNqLmUvkxygoy2IRKRrwnidLW2Q48gR0svA=; b=lb8xbsymMo4NEvlx5sYRSg8myd/Lg3zqrEEjeQAOlmByVA6iJFnjSHNiEjkmcRoAvM 5YST4WDU5S7rxtzK9JCmJqnvs3+idNrTXs1ATY6kSBIqsMSbpKC744IksB/LoRZdsoGl X0L6UcvpC3jUFg9zH8SGXzFzE5LPJBmwVQL+WcG6xWO44IFgMIA0LgiaTY/rk0WKqJWV tB/G6L9KDN4Eu0oo0bd9lqEwQZfmfoSadf8TIpPnLk/5/cnI0qEkM0+elGHHOipMSG1C JJzY2G0pyc0fk6Rxu6Go21L52OFCo6qcPqngmOfYlOwtfnkVqLYW/uJfstusArcX2LOB wkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719690912; x=1720295712; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TEK/P1XekNqLmUvkxygoy2IRKRrwnidLW2Q48gR0svA=; b=eyRG0L9dgFkUfK9GuGiiU3p3Ecpwo2GtRYRqpXkbG5GJukTEfJ0G8LXpXwuWIcd0GY Tb5XToBVY+KeZtLLmHwLsgKtOg63PriahyIATkKo8Pk0Wd1ZvCrvhumh3UJ3SzPAjyrm oNzTk+S77A/Dxz/iqxbyVPYLaLJa00u0lDXj4+B3rcC4OWa71qk5EumfjVOCVr25HPQu NoO0OtU+MRF0QV8ATmNmufsTtxYhFXXDtX+9fPYf/3K1xad7tfh2eGsBu1Pu70sqZXS2 rVkgSZ2KCMLfWFs+1PZsiD9B0CY+yPxKL3znc89H4pvhnhHIV0I1jNzv4YX1W1YtRJob ZDrA== X-Gm-Message-State: AOJu0YzIKQ91Dx3b1Y9uQekoaT3B4GZbx/pmxRsfqKBEVp+HM9+qwgOa H4L70GS+IUbqEV5sTlViSRQqtA0WZ9cBR3J33LRiCh6v017kdefNSOx/KQ== X-Google-Smtp-Source: AGHT+IG5G5LGsqCmYA68uhVnfpJYzjTapGu3iaK4Xsmqq4F7dKJZzRhb9n3Z1fuv68mI5I5R+h/ikQ== X-Received: by 2002:a5d:8450:0:b0:7eb:7089:dfe4 with SMTP id ca18e2360f4ac-7f62ee74b4emr179520439f.15.1719690911863; Sat, 29 Jun 2024 12:55:11 -0700 (PDT) Original-Received: from Matthews-MacBook-Pro.local ([2605:a601:acd7:b300:19a2:be01:2170:228b]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73bb38a3sm1217185173.6.2024.06.29.12.55.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 12:55:11 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=mjbauer95@gmail.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288137 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I believe this regex for cucumber is not precise enough. Specifically, it was picking up this indentation in an error message from GHC: Main.hs:195:1: error: [GHC-44432] The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying= binding Suggested fix: Perhaps use one of these: =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) It picked up this as being error messages which I believe it shouldn=E2=80= =99t have: =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 This change just ignores it if there is remaining space. Probably it still needs to be refined, but this at least avoids this false positive for me. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Try-to-limit-false-positives-for-cucumber-compilatio.patch Content-Transfer-Encoding: quoted-printable Content-Description: Fix "cucumber" regexp >From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001 From: Matthew Bauer Date: Sat, 29 Jun 2024 14:45:35 -0500 Subject: [PATCH] Try to limit false positives for cucumber compilation MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit I believe this regex for cucumber is not precise enough. Specifically, it was picking up this indentation in an error message from GHC: Main.hs:195:1: error: [GHC-44432] The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying= binding Suggested fix: Perhaps use one of these: =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) It picked up this as being error messages which I believe it shouldn=E2=80= =99t have: =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 This change just ignores it if there is remaining space. Probably it still needs to be refined, but this at least avoids this false positive for me. --- lisp/progmodes/compile.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 2e4eb11811a..a03f1935971 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1)) " ")) "#") " " - (group (not "(") (* nonl)) ; file + (group (not (in "( ")) (* nonl)) ; file ":" (group (in "1-9") (* (in "0-9")))) ; line 1 2) --=20 2.39.3 (Apple Git-146) --=-=-=--