From: Matthew Bauer <mjbauer95@gmail.com>
To: 71844@debbugs.gnu.org
Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive
Date: Sat, 29 Jun 2024 14:55:05 -0500 [thread overview]
Message-ID: <m2le2n1q3q.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
I believe this regex for cucumber is not precise enough. Specifically,
it was picking up this indentation in an error message from GHC:
Main.hs:195:1: error: [GHC-44432]
The type signature for ‘apathway’ lacks an accompanying binding
Suggested fix:
Perhaps use one of these:
‘foo’ (Defined at Main.hs:196:1),
‘foo’ (Defined at Main.hs:216:1)
It picked up this as being error messages which I believe it shouldn’t have:
‘foo’ (Defined at Main.hs:216
‘foo’ (Defined at Main.hs:216
This change just ignores it if there is remaining space. Probably it
still needs to be refined, but this at least avoids this false positive
for me.
[-- Attachment #2: Fix "cucumber" regexp --]
[-- Type: text/x-patch, Size: 1666 bytes --]
From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001
From: Matthew Bauer <mjbauer95@gmail.com>
Date: Sat, 29 Jun 2024 14:45:35 -0500
Subject: [PATCH] Try to limit false positives for cucumber compilation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
I believe this regex for cucumber is not precise enough. Specifically,
it was picking up this indentation in an error message from GHC:
Main.hs:195:1: error: [GHC-44432]
The type signature for ‘apathway’ lacks an accompanying binding
Suggested fix:
Perhaps use one of these:
‘foo’ (Defined at Main.hs:196:1),
‘foo’ (Defined at Main.hs:216:1)
It picked up this as being error messages which I believe it shouldn’t have:
‘foo’ (Defined at Main.hs:216
‘foo’ (Defined at Main.hs:216
This change just ignores it if there is remaining space. Probably it
still needs to be refined, but this at least avoids this false positive
for me.
---
lisp/progmodes/compile.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 2e4eb11811a..a03f1935971 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
" "))
"#")
" "
- (group (not "(") (* nonl)) ; file
+ (group (not (in "( ")) (* nonl)) ; file
":"
(group (in "1-9") (* (in "0-9")))) ; line
1 2)
--
2.39.3 (Apple Git-146)
next reply other threads:[~2024-06-29 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 19:55 Matthew Bauer [this message]
2024-06-30 5:05 ` bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2le2n1q3q.fsf@gmail.com \
--to=mjbauer95@gmail.com \
--cc=71844@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.