From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Thu, 19 Dec 2024 10:04:37 +0100 Message-ID: References: <86wmi0g0x6.fsf@gnu.org> <11a86987cce9fe0a257c3fa58703dc33@finder.org> <86wmgl6jzv.fsf@gnu.org> <092cb755eee3a9b5e06d15c0b07e90b1@finder.org> <276414b03c24964aaeb9e43e8dba5e77@finder.org> <5fedec86bce470555814acbdf999f99d@finder.org> <86h6791khk.fsf@gnu.org> <09b0904da92efad899865b2ece5f3116@finder.org> <86ikrhm6zk.fsf@gnu.org> <868qsdlzt5.fsf@gnu.org> <8634ikncv8.fsf@gnu.org> <2aeb4a5f1e76879b874c88618beff37f@finder.org> <86ikrgkr15.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19513"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jared@finder.org, stefankangas@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org, rudalics@gmx.at To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 10:05:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOCT3-0004sT-FV for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 10:05:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOCSi-0007p1-0m; Thu, 19 Dec 2024 04:04:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOCSb-0007oY-N1 for emacs-devel@gnu.org; Thu, 19 Dec 2024 04:04:46 -0500 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOCSZ-0003Pk-A7; Thu, 19 Dec 2024 04:04:44 -0500 Original-Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5ceb03aadb1so675677a12.0; Thu, 19 Dec 2024 01:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734599080; x=1735203880; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=buQ73LLeEaYLb3RuBRRXWVfUCYgf1OfTwwaMrfY8xss=; b=HMFMiJjE0sIpHUyLkgMdsTdMHq1ssvxm1K+IUwBrncgOFvq1NiIX6e90P77PI2pT02 JUWt47kAmhxPNJAbmHfVEBuuU71HtueIUIs3b1O74ZF4aLnv/Xz9GJnjHSj5spGHAyv0 zz9nT7wU0qqvQsP5yXO/EKMYwCF2U3aEKwQ3uME22Jk/7T/i7CIhA8X5Fl11xrDcowp3 lAxjPrpavwPM1DoykkKSPybyiE8G2mEx6PSLCvbFe86zl/DYXRMcJfu932DrLYj+VoTE i/J+bHpwhOOcwQ8gdH3H8O163x9uWtEl3GlqdWSMb7HNbEyrt+p9am/jjyVzqjblCta5 +K3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734599080; x=1735203880; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=buQ73LLeEaYLb3RuBRRXWVfUCYgf1OfTwwaMrfY8xss=; b=N3uCwnxq2s704njgc2UoU0sGfBJO+IUFDe1E7qj5dJGY1nK8/8uLDr81+6m0YR5bmk nvegdVfX2h8QpYH8tNXV/JCX8PcWk9zgN0Bp+WHMJeIMMd/hSiPoHJiuHSVrd6MRGdOg EIbpmLjMUuaD/6T4N39jGY/3ohm7YAxGZ4LUMwfZMzk4hQlj0fAOs3OqReuuIoEaIhXX vDYrvN1n05coN+7YZn1q7RZYNULp2gxV8BUL7AJCxITSDkXiGmQf2q1f9NgklU0BR8fr KU3NCllxBK0xE2tCS5mtaraDNdhGNl8/oZ7tfAF89UHizbhOZjP/J7aGX6FfCNZQGNVu H+Bw== X-Forwarded-Encrypted: i=1; AJvYcCVq5OWtBw+Hj2eC+2l6imkvfOD7wTD4pLJ3Zr0Zto20lH8WU50hAG3gV+4lEDaegRa7eo2099oeVbOCnmI=@gnu.org, AJvYcCXVXQxCT2v6boXhB0cEb5Ewipo0MKQl0BwOAVyxSJp0dgMSiG7P8NuquPd4xoQQFZpqAIHhJFX6BQ==@gnu.org X-Gm-Message-State: AOJu0Yydmnmpednhkt5n2+/MAjdoEr6LYr339W1Q6oGyuYhgjAxuKv5r +oJISmbRPkR3NwNlhYcNLrjP4/pcQBQsiNZLE+XZ6Mo+6yTebjGC X-Gm-Gg: ASbGncvEjIaK6v3bCUv28TRh8xwpIXj3er2CX0ga5PHKu2iXj1OCh8Wt+5gngk0v+YU L/fwFPqcHCbq3CdfBc+xgML1xF/zQwCiT0cQHiccKB9zMdQ6QLcg+m+VB/OWEtQXTUg4CjyHvVe Xv4eetj/VdriLgKt4KiwzeUe6Ajo29qnbL1ekhf0m0TdS8uY0W5jpjEHsbhnkg4b1+VchSCreoU asnci8eW7b4g2fFOLQ+Bvu0V8RFxYJejtdWqpDxMXCpeimwipNZRT7pRJI8NJNUQjTnh+iwpRuv BSgmckxqo0Ex8yLV6YMwQ7kRGmBb3VqMu95fp/tyiixIA/A/1kGacezFIIPFvfghiw== X-Google-Smtp-Source: AGHT+IG23sOZ9/acWC3XuPuxlMGMKOxXXxTFax+dAIah1X9o2wczkIyMy8P5JQVrhNX3KWVE2vlCrA== X-Received: by 2002:a05:6402:51cb:b0:5d2:7199:ae5 with SMTP id 4fb4d7f45d1cf-5d7ee3b3924mr4393672a12.5.1734599079394; Thu, 19 Dec 2024 01:04:39 -0800 (PST) Original-Received: from pro2 (p200300e0b73f530035e1461ed45ebc64.dip0.t-ipconnect.de. [2003:e0:b73f:5300:35e1:461e:d45e:bc64]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80675a3d2sm434634a12.16.2024.12.19.01.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 01:04:38 -0800 (PST) In-Reply-To: <86ikrgkr15.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2024 10:36:54 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326709 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: Eli Zaretskii , stefankangas@gmail.com, >> acorallo@gnu.org, emacs-devel@gnu.org, rudalics@gmx.at >> Date: Thu, 19 Dec 2024 06:30:23 +0100 >>=20 >> And attached is what I came up today, with the help of a lot of coffee. >> The changelog is a page worth of changelog entries, the diff is from >> what I created these. As introductory text I'd use >>=20 >> This changeset adds support for child frames on ttys. > > I'd say > > Add support for child frames on ttys > > (without the period). like a caption, okay. > > The ChangeLog part looks reasonable. My only comment is that you > could collect changes with the same description together. For > example, instead of > > * lisp/frame.el (frame-at): New function. > (tty-frame-geometry): Declare C function. > (tty-frame-edges): Declare C function. > (tty-frame-list-z-order): Declare C function. > (tty-frame-restack): Declare C function. > (tty-display-pixel-height): Declare C function. > (tty-display-pixel-width): Declare C function. > > you could use > > * lisp/frame.el (frame-at): New function. > (tty-frame-geometry, tty-frame-edges, tty-frame-list-z-order) > (tty-frame-restack, tty-display-pixel-height) > (tty-display-pixel-width): Declare C function. > > But that's an optimization; what you have is perfectly okay. Yes, that came out of the order in which stuff appeared in the diff. I'll do that. > > Thanks. Very good. Thanks for the review! I'll merge when I've made these changes.