From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.bugs Subject: bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments Date: Thu, 26 Dec 2024 08:54:04 +0100 Message-ID: References: <2184374.9o76ZdvQCi@fedora> <86ed206xxh.fsf@gnu.org> <20814896-AF38-4358-A4A7-59D69C55CD71@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38122"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Vincenzo Pupillo , Stefan Kangas , 75012@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 26 08:56:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQij4-0009j1-0R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Dec 2024 08:56:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQij0-0002KA-W9; Thu, 26 Dec 2024 02:56:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQiix-0002JW-2H for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 02:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQiiw-0006GH-PZ for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 02:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=f1chHENpcootJFitVi4uKXTH4RUxYtwYMbwGdF93Nfo=; b=ttsEk9Iqfa3cYXb1DwLuZxVcCl71qzmrYZeoQv6gA9ZWLrvagGFQxtUZwMaUiPcGa2tw5wEr+ZItztcjNKoJQDE0s2tC/CcUaawWtRmZiSy6V4ogp2x1NX6rfV9l2ZS+FjRmlVyRWASPcRpjUX3J8+vebOgU/CfwBzR/hC0lCREN3fLEwGAEUFo/jYW/LRy+u2j1XzPagc/lK11Fg3WxcIrrbQ7OKMwqlhSBvCOZ3H+PRZt4ys+uND9LCwo7UZzKCmG95WOqjazUcLxWVRESGN7jBCf33Npxz5kwLWgVNOPgM+scuodpWUot5EyvLh3Q35/cKzbgR66ZLA/SZPavuA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQiiw-0007Vc-Kq for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 02:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75012 X-GNU-PR-Package: emacs Original-Received: via spool by 75012-submit@debbugs.gnu.org id=B75012.173519971928799 (code B ref 75012); Thu, 26 Dec 2024 07:56:02 +0000 Original-Received: (at 75012) by debbugs.gnu.org; 26 Dec 2024 07:55:19 +0000 Original-Received: from localhost ([127.0.0.1]:39945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQiiF-0007UQ-2Q for submit@debbugs.gnu.org; Thu, 26 Dec 2024 02:55:19 -0500 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:42315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQiiC-0007U5-6x for 75012@debbugs.gnu.org; Thu, 26 Dec 2024 02:55:16 -0500 Original-Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso37766525e9.1 for <75012@debbugs.gnu.org>; Wed, 25 Dec 2024 23:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735199650; x=1735804450; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=f1chHENpcootJFitVi4uKXTH4RUxYtwYMbwGdF93Nfo=; b=SM4igSkgyrq1L9/Y7edGlOoR3+oiLvQfa9kSHInWVknifSfa+Aksfhll85BInGOqC9 mNJRUtfTTvicCeN0KdfiZJA2Kcl5GAPP3kb2dac+14DbT21XHE3q3lAK3q5qJLLC1HnX wlC1eQGXrLi2ofHbuOA6pL0qGEnB4fhPLsO7ILpolyzC9xOYrrJdDv1kIryGgq0uGa2W WADtOffTZEi0qLTlv1g+lIUCe7uhqoeh7gmJuHZZp0RcM0LiufA2xuNdcwL2b0/7afE1 oCD1P5l1CcQmhL2EI6IiOsIByl+xpDT2hU3g/R2aU3emoVO2RWiAEDCWH5yKx6wZChHo RKww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735199650; x=1735804450; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f1chHENpcootJFitVi4uKXTH4RUxYtwYMbwGdF93Nfo=; b=nSnssR/QpX2kRft69KCRbWwF0Ls+BuctwVDwFB9GXjFQqBt2NjsWVOd8ZfHG4QtQRU IOLvd5ubdl244kWmWVle9lr0Tz6/OlZmm+buTRzuVOGLxQekJnVshymj530PSPKWj3xx hhoAY/akHv3eagCWB8dvNCbzQy/IFca5x9U8PDi2HbzFZHdou7zn9t215yDmSKUXSnIE K3UHzxUttkzzN1B0A+sC+wvM0fzfWEVlA6pkwhLRE1wtxuF0/QWcPtAZvn/aNbsE9+zj +MS/BxvrjF4t9qMcmU1zQ+NB+57RW6oEGNvnEmVPS7H0jY7HYrGKu3Xv+ccke5ZlIpJe vI7A== X-Forwarded-Encrypted: i=1; AJvYcCWr2COLaIoPoZMJJnfQkxMjzgRblM8z8R1DGmK4UgXjoLk2xJgsmYyMatyHuYEPWPBNztO2Vw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxqWuJoOu6m06yBvEQvF/SwulubIUdRdhBdMnhuVRL1nGaZHpb5 ui6d8qoA1q+krpeDT3cVEonPoiNsYo6Qt5pFYxnkOkJstVrKiszHWkHteMu2 X-Gm-Gg: ASbGncuKPKo3Sk96VwpmnwTxgxj76vlJ4zKoklgWT4Acex2RhVVQp9eIpkjx5mmWnA5 rKa49WapGjAXXe3IsYy7nmZvgQwReG6+SRjoPXVviPu5Soa7Ho/XkylWpGuc89rf5G2K6utx1G+ V15N5RgUHRpdxxj6I2hlUD9QP51s/r4zVoUxyizifmz+RRd8kdbU2i9vhalchllePDj8VE+zvKC pocdnmbagv2pXhY/JMfTdDww8QGRK2C/we93WP8KoOR2NuivkwmKeKRkwnf2Mpv X-Google-Smtp-Source: AGHT+IEXhUCg/qQ54TpfhYIeBebknyoEMc4P/sZaihtZWUjs+h/BoWTovpg/gWBEvBXpFsrnq1rI9w== X-Received: by 2002:a05:600c:4302:b0:435:edb0:5d27 with SMTP id 5b1f17b1804b1-4365c775131mr209070555e9.9.1735199649697; Wed, 25 Dec 2024 23:54:09 -0800 (PST) Original-Received: from mba ([151.56.12.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b207sm257058415e9.32.2024.12.25.23.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Dec 2024 23:54:07 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297751 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Yuan Fu writes: >> On Dec 24, 2024, at 11:32=E2=80=AFPM, Filippo Argiolas wrote: >>=20 >> Stefan Kangas writes: >>=20 >>> Yuan Fu writes: >>>=20 >>>> Thanks for the ping. From the screenshot it looks very nice! If no one >>>> objects I think we should merge this. >>>=20 >>> Sounds good to me. >>=20 >> Great! If you go ahead and install this feel free to take this as a >> trivial suggestion as I still don't have the signed agreement. > > Your patch seems to be within 15 LOC, in that case we can apply it even w= ithout the assignment (unless you=E2=80=99ve used the 15 LOC wavier before)= . Do you want to submit a patch? > I have two 'Co-authored' commits, mostly doc changes were I was involved in the discussion but I wouldn't say I authored, and one 'Suggested by' trivial bug fix. I guess I'm still within the trivial realm, patch attached. Thanks, Filippo --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Improve-doxygen-comments-font-lock-rules-in-c-ts-mod.patch >From 09b26c95fce881a375393864c9487c1f4d45f05a Mon Sep 17 00:00:00 2001 From: Filippo Argiolas Date: Thu, 26 Dec 2024 08:06:55 +0100 Subject: [PATCH] Improve doxygen comments font lock rules in c-ts modes * lisp/progmodes/c-ts-common.el (c-ts-mode-doxygen-comment-font-lock-settings): Add rules for type, storageclass and note/warning/error tags. (Bug#75012) Copyright-paperwork-exempt: yes --- lisp/progmodes/c-ts-common.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el index 25b386cbaa7..7a0b2660095 100644 --- a/lisp/progmodes/c-ts-common.el +++ b/lisp/progmodes/c-ts-common.el @@ -397,7 +397,12 @@ c-ts-mode-doxygen-comment-font-lock-settings :override t :feature 'keyword '((tag_name) @font-lock-constant-face - (storageclass) @font-lock-constant-face) + (type) @font-lock-type-face + (emphasis) @bold + ((tag_name) @bold (:match ".note" @bold)) + ((tag_name) @warning (:match ".warning" @warning)) + ((tag_name) @error (:match ".error" @error)) + (storageclass) @font-lock-keyword-face) :language 'doxygen :override t -- 2.47.0 --=-=-=--