bug#423: flymake faces hard to read on dark backgrounds

bug#423: flymake faces hard to read on dark backgrounds

[Nikolaj Schumacher]

[-- Attachment #1: Type: text/plain, Size: 124 bytes --]

Hello,

flymake-errline and flymake-warnline faces are very hard to read on dark
backgrounds.


regards,
Nikolaj Schumacher

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 1118 bytes --]

diff -du /Users/nik/emacs/var/backup/\!Applications\!Emacs.app\!Contents\!Resources\!share\!emacs\!22.2.50\!lisp\!progmodes\!flymake.el.\~1\~ /Applications/Emacs.app/Contents/Resources/share/emacs/22.2.50/lisp/progmodes/flymake.el
--- lisp/progmodes/flymake.el	2008-06-12 23:22:42.000000000 +0200
+++ lisp/progmodes/flymake.el	2008-06-15 22:28:02.000000000 +0200
@@ -799,15 +799,15 @@
     has-flymake-overlays))
 
 (defface flymake-errline
-  ;;+   '((((class color)) (:foreground "OrangeRed" :bold t :underline t))
-  ;;+   '((((class color)) (:underline "OrangeRed"))
-  '((((class color)) (:background "LightPink"))
+  '((((background dark)) (:background "Firebrick4"))
+    (((background light)) (:background "LightPink"))
     (t (:bold t)))
   "Face used for marking error lines."
   :group 'flymake)
 
 (defface flymake-warnline
-  '((((class color)) (:background "LightBlue2"))
+  '((((background dark)) (:background "DarkBlue"))
+    (((background light)) (:background "LightBlue2"))
     (t (:bold t)))
   "Face used for marking warning lines."
   :group 'flymake)

Diff finished.  Sun Jun 15 22:28:11 2008

bug#423: marked as done (flymake faces hard to read on dark backgrounds)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]


Your message dated Wed, 23 Jul 2008 17:56:56 -0400
with message-id <87abg8463b.fsf@stupidchicken.com>
and subject line Re: flymake faces hard to read on dark backgrounds
has caused the Emacs bug report #423,
regarding flymake faces hard to read on dark backgrounds
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
423: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=423
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3627 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 124 bytes --]

Hello,

flymake-errline and flymake-warnline faces are very hard to read on dark
backgrounds.


regards,
Nikolaj Schumacher

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: patch --]
[-- Type: text/x-patch, Size: 1118 bytes --]

diff -du /Users/nik/emacs/var/backup/\!Applications\!Emacs.app\!Contents\!Resources\!share\!emacs\!22.2.50\!lisp\!progmodes\!flymake.el.\~1\~ /Applications/Emacs.app/Contents/Resources/share/emacs/22.2.50/lisp/progmodes/flymake.el
--- lisp/progmodes/flymake.el	2008-06-12 23:22:42.000000000 +0200
+++ lisp/progmodes/flymake.el	2008-06-15 22:28:02.000000000 +0200
@@ -799,15 +799,15 @@
     has-flymake-overlays))
 
 (defface flymake-errline
-  ;;+   '((((class color)) (:foreground "OrangeRed" :bold t :underline t))
-  ;;+   '((((class color)) (:underline "OrangeRed"))
-  '((((class color)) (:background "LightPink"))
+  '((((background dark)) (:background "Firebrick4"))
+    (((background light)) (:background "LightPink"))
     (t (:bold t)))
   "Face used for marking error lines."
   :group 'flymake)
 
 (defface flymake-warnline
-  '((((class color)) (:background "LightBlue2"))
+  '((((background dark)) (:background "DarkBlue"))
+    (((background light)) (:background "LightBlue2"))
     (t (:bold t)))
   "Face used for marking warning lines."
   :group 'flymake)

Diff finished.  Sun Jun 15 22:28:11 2008

[-- Attachment #3: Type: message/rfc822, Size: 1116 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Nikolaj Schumacher <n_schumacher@web.de>
Cc: 423-done@emacsbugs.donarmstrong.com
Subject: Re: flymake faces hard to read on dark backgrounds
Date: Wed, 23 Jul 2008 17:56:56 -0400
Message-ID: <87abg8463b.fsf@stupidchicken.com>

> flymake-errline and flymake-warnline faces are very hard to read on
> dark backgrounds.

Your patch looks reasonable.  I've checked it in.  Thanks.