From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Francis Moreau Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Sending patch with Gnus Date: Thu, 16 Dec 2010 21:20:10 +0100 Message-ID: References: <871v5i212s.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1292530932 17187 80.91.229.12 (16 Dec 2010 20:22:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 16 Dec 2010 20:22:12 +0000 (UTC) Cc: Thierry Volpiatto , ding@gnus.org, emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 16 21:22:07 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PTKL1-0004uZ-Be for ged-emacs-devel@m.gmane.org; Thu, 16 Dec 2010 21:22:07 +0100 Original-Received: from localhost ([127.0.0.1]:47687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTKL0-0004Ty-HH for ged-emacs-devel@m.gmane.org; Thu, 16 Dec 2010 15:22:06 -0500 Original-Received: from [140.186.70.92] (port=59561 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTKKw-0004Tt-4y for emacs-devel@gnu.org; Thu, 16 Dec 2010 15:22:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTKKu-0001N6-Tp for emacs-devel@gnu.org; Thu, 16 Dec 2010 15:22:02 -0500 Original-Received: from mail-ew0-f43.google.com ([209.85.215.43]:64092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTKKu-0001N2-Ns for emacs-devel@gnu.org; Thu, 16 Dec 2010 15:22:00 -0500 Original-Received: by ewy22 with SMTP id 22so2361973ewy.30 for ; Thu, 16 Dec 2010 12:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=cuC4CUraUAiEAmp2U9sPS4ZdDvU8IahJvAmxZe/EEeE=; b=e+t9FKI6FZZXT/DKcJimUNsTESJsALdxmffhIW6Kwdu+LWgqjsV4xdXB/djrjkAJGV xGGzdE5bfPzuJRZWm4vTb30Gzy6vqyXDNEXwAgczAOzE8JC9/9h4XJgJmm5bh6SP5AVh EmzwPdXVBz7q4/nyka+j+1OR8Y/gg0Ai43t0k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=p/mJ7hRYIKpgl4LIq8vRnuQiAbzurwra/1z9kTXSY4A20ruF9PILUpUSuEnr2S+6DF ZEzf4bDLF5TE+J2hvIhQN5woWBgDD77y6uW+U7wep+Limt4ZESxex33yvDjE8DRpH6v/ b6aSqJmUuBKyXzwCIgu15D9j2prCQ5Y3BQxQk= Original-Received: by 10.216.90.79 with SMTP id d57mr2741970wef.65.1292530901637; Thu, 16 Dec 2010 12:21:41 -0800 (PST) Original-Received: from localhost (au213-1-82-235-205-153.fbx.proxad.net [82.235.205.153]) by mx.google.com with ESMTPS id j58sm251976wes.21.2010.12.16.12.20.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 16 Dec 2010 12:20:12 -0800 (PST) In-Reply-To: (Leo's message of "Thu, 16 Dec 2010 13:07:29 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133749 gmane.emacs.gnus.general:75153 Archived-At: Leo writes: > On 2010-12-16 10:01 +0000, Francis Moreau wrote: >> Leo writes: >> >> [...] > >> >>> >>> I tweaked gnus-dired to support git-send-email (patches attached). >> >> Thanks for doing that. >> >> Unfortunately your patches don't seem to be based on Gnus repository but >> rather to emacs one that I don't have. So I can't test them. > > OK, I put it in a separate file as attached. > >>> So if you have gnus-dired loaded you can in dired buffer: >>> >>> C-c C-m C-i import patches as DRAFTS >>> C-c C-m C-s send patches directly >>> >>> This is handy when you need to send a large patch set. For one to two >>> patches I just copy and paste. >> >> Funny because I feel the opposite, I use git-send-email(1) when dealing >> with a large patch set since the overhead to set it up is ok in this >> case. But for one patch, I do it by hands as you do, but I would prefer >> to not have editing the email manually. >> >> But I think, your approach can still be usefull since it imports patches >> as _drafts_. I don't think it's a good idea to modify the patch itself, >> but modifying or adding some header fields like To, Cc, Bcc... should be >> ok. And I like to check what the patch looks like before sending it. >> >> One other idea is to generate one or several drafts from a buffer which >> contains one or several mbox files. Let's call the magic command: M-x >> create-draft-from-buffer (yeah the name sucks). >> >> With such command, one could do in an emacs session: >> >> M-! git format-patch --stdout HEAD~4 >> C-x o >> M-x create-draft-from-buffer >> >> So you're putting in the *Shell Command Output* buffer the mbox files, >> and then switching to that buffer and generating the drafts. The main >> advantages I see is that you use a shell command to generate the buffer >> containing the patches. >> >> BTW, if you needn't to modify the patches and only want to see them >> before sending them then you can currently do this: >> >> M-! git format-patch --stdout HEAD~4 >/tmp/patch-set.mbox >> C-x b *Group* >> G f /tmp/patch-set.mbox >> >> This will create a nndoc group which contains all your patches as >> articles. >> >> Then you can mark all of them and resend them with 'S D r'. But you >> can't add Cc or Gcc header fields with this method. > > Now we have four commands (not bound to any keys for the moment) > > gitmail-import-mbox-as-draft > gitmail-send-mbox > gitmail-send-mbox-buffer > gitmail-import-mbox-buffer why making them Git specific like the command names suggest ? I would actually do: 's/gitmail/gnus/' > > Editing drafts in Gnus resets the date so you need this small patch (or > is there a butter way to handle this?): I know almost nothing in elisp sorry, so I can't comment your patches. However I would be interested to know what Gnus developpers think about these new commands. I don't think that Gnus is currently able to import a mbox file/buffer and make it a draft(s). Also your gnus-dired stuffs seem interesting. -- Francis