Re: [PATCH][ox-koma-letter]: sender, email and cleanup

[Alan Schmitt <alan.schmitt@polytechnique.org>]

Rasmus writes:

> Viktor,
>
>>>   1. Viktor's latest patch.
>>>   2. The patch describe above that gets user name and email and works
>>>      on my system. . .
>>
>> Your code works for me. From my point of view, the pros are that per
>> default `org-koma-letter-{author,sender}' pick up the values of
>> `user-full-name' and `user-mail-address' whenever they are changed.
>> That's very nice! The cons are that IHMO it's quite complicated for
>> setting something as simple as author and email and you mentioned a
>> possible crash which I did not test further. Could this be tested using
>> `functionp'? Still, I think we should stick with it for now.
>
> functionp seems better, yes.  I didn't know about it (doh!).  Thanks!
>
> While it is complicated I think it's OK given our desire to disable
> author and still have a similar default to ox-latex.el.  Also, it
> allows for arbitrary functions which could potentially determine the
> name based on the context of the letter (I don't know since it's
> already initialized in the options-alist).
>
> I'll let you and Alan decide.

I like this approach.

>> As a side note, I had quite a few problems working with your patches.
>> None of them applied against master, or against my latest patch as you
>> claimed. 
>
> Right.  I was working off of branch and I guess one reasons is that it
> was against the history of my previoues patches—of which not all was
> applied to the master, it seems (?).  I've now tried to rework the
> entire thing against the current master and produces simplified
> patches.  I tested them with git am and they work on my system.
>
> There are still things I don't understand such as why git wants to
> re-add the authors in patch 4 but I've spend way to much time on
> rebasing and understanding git already and my head hurts.  It seems to
> ignore it when using git am.
>
> Before applying the patches my git log says
>
> commit 847637f4bdacb861723438c1389f1a3bcdac48af
> Merge: 43cc5be 206762b
> Author: Nicolas Goaziou <n.goaziou@gmail.com>
> Date:   Sat May 25 22:03:48 2013 +0200
>
>     Merge branch 'maint'
>
> Patches:
>
> 1. summarizes all changes in author.  It uses my solution as mentioned above.
> 2. full support for after closing keywords.  See commit message
> 3. signature to nil
> 4. change handling of subject and allow for setting subject in
> OPTION-line.

I'm going to apply the patches. Thanks to both of you for the nice work!

Alan