From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23074@debbugs.gnu.org
Subject: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.
Date: Tue, 22 Mar 2016 19:04:06 -0700 [thread overview]
Message-ID: <m2k2kueyqx.wl%esq@lawlist.com> (raw)
In-Reply-To: <m237rkquxw.wl%esq@lawlist.com>
With the modification that I made in startup.el -- building with the default gtk3 toolkit -- the fancy image takes up a substantial portion of the welcome screen such that the last partially visible line is: "Auto-save file lists were found. If an Emacs session crashed recently,"
I had assumed based on the comments in the function that I modified that the concern was a potential second window displaying an error message. If the error message is displayed in that second window, then suppress the image in the welcome screen. That is why I suggested the idea of a `one-window-p` test to determine whether an error window might be displayed.
Your idea of having all text visible in the welcome screen makes good sense. I haven't familiarized myself with everything that goes into determining the initial default frame size or default size of subsequently created frames. So, I have no opinion regarding what the default should be. I also have no opinion regarding the text that makes up the contents of the welcome screen.
My primary concern when building Emacs was that perhaps I did not have proper image support because the Emacs logo was not appearing. But, that concern has now been resolved by tracking it down to use-fancy-splash-screens-p.
Keith
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
At Tue, 22 Mar 2016 18:07:18 +0200,
Eli Zaretskii wrote:
>
> * * *
>
> Then, with the code you modified in startup.el, you do succeed to get
> the fancy splash image, but the text below it is only partially
> visible, right? IOW, one or two (maybe even 3) last lines are not
> visible? This is exactly what the test was trying to avoid. So if we
> go with your proposal, it is not clear why we should insist on some
> minimal frame height at all.
>
> (Or maybe you don't have auto-save file lists in your home directory,
> in which case your startup screen shows 2 lines less than it does on
> my system, and you are not aware of the problem for that reason.)
>
> I think the correct solution will be to increase the default frame
> size by 1 or maybe even 2 lines. Because on my system, the last line
> is only partially visible, so the calculation in
> use-fancy-splash-screens-p is slightly inaccurate (because it is
> off-by-one -- we need to subtract 2 from the frame height, not 1).
next prev parent reply other threads:[~2016-03-23 2:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 5:08 bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil Keith David Bershatsky
2016-03-21 16:03 ` Eli Zaretskii
2016-03-22 1:03 ` Keith David Bershatsky
2016-03-22 16:07 ` Eli Zaretskii
2016-03-23 2:04 ` Keith David Bershatsky [this message]
2016-03-25 7:49 ` Eli Zaretskii
2016-03-27 4:04 ` Keith David Bershatsky
2016-03-27 14:57 ` Eli Zaretskii
2016-04-08 8:30 ` Eli Zaretskii
2016-04-08 16:26 ` Keith David Bershatsky
2016-04-09 6:48 ` Keith David Bershatsky
2016-04-09 7:53 ` Eli Zaretskii
2016-04-16 11:59 ` Eli Zaretskii
2020-08-15 4:22 ` Stefan Kangas
2021-04-10 15:33 ` John Hawkinson
2021-04-10 17:35 ` Eli Zaretskii
2021-04-10 17:49 ` John Hawkinson
2021-12-30 22:49 ` John Hawkinson
2021-12-31 13:27 ` Eli Zaretskii
2016-04-09 19:05 ` Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k2kueyqx.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=23074@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.