* Org-get-property-block can’t handle preceding drawers
@ 2018-01-31 20:01 Nikolai Weibull
2018-01-31 20:12 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Nikolai Weibull @ 2018-01-31 20:01 UTC (permalink / raw)
To: emacs-orgmode
Hi!
I’m doing some restructuring of my Org files and I’m getting a lot
of claims that I have malformed drawers. Some of these files are
quite old, so at first this seemed like a reasonable problem, but
when I looked closer everything looked fine. The problem was that
I had :LOGBOOK: drawers before quite a few of my :PROPERTY:
drawers and apparently org-get-property-block is /completely/
unaware of this possibility. At first I figured that the rules
had changed and that the :PROPERTY: drawer must come first, but
then I tried it out and Org would gladly create a new :LOGBOOK:
drawer for an entry that already had a :PROPERTY: drawer and place
the :LOGBOOK: drawer first.
Now, what’s worse is that the whole “you have a malformed drawers,
should I fix it?” functionality in org-buffer-property-keys will
not actually move the :PROPERTY: drawer to the location that it
expects, it simply creates an empty :PROPERTY: drawer instead and
leaves the “misplaced” one where it was.
What’s going on here?
Nikolai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Org-get-property-block can’t handle preceding drawers
2018-01-31 20:01 Org-get-property-block can’t handle preceding drawers Nikolai Weibull
@ 2018-01-31 20:12 ` Nicolas Goaziou
2018-01-31 20:52 ` Nikolai Weibull
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2018-01-31 20:12 UTC (permalink / raw)
To: Nikolai Weibull; +Cc: emacs-orgmode
Hello,
Nikolai Weibull <now@disu.se> writes:
> At first I figured that the rules had changed and that
> the :PROPERTY: drawer must come first
That's correct.
> but then I tried it out and Org would gladly create a new :LOGBOOK:
> drawer for an entry that already had a :PROPERTY: drawer and place
> the :LOGBOOK: drawer first.
That is a bug. I don't expect anything like this to happen in a recent
Org.
> Now, what’s worse is that the whole “you have a malformed drawers,
> should I fix it?” functionality in org-buffer-property-keys will not
> actually move the :PROPERTY: drawer to the location that it expects,
> it simply creates an empty :PROPERTY: drawer instead and leaves the
> “misplaced” one where it was.
In ORG-NEWS, you will file a function that repairs your documents.
I removed "You have a malformed drawer" question a while ago from the
code base.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Org-get-property-block can’t handle preceding drawers
2018-01-31 20:12 ` Nicolas Goaziou
@ 2018-01-31 20:52 ` Nikolai Weibull
0 siblings, 0 replies; 3+ messages in thread
From: Nikolai Weibull @ 2018-01-31 20:52 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Nicolas Goaziou, 2018-01-31 20:12:
> Nikolai Weibull <now@disu.se> writes:
>
>> At first I figured that the rules had changed and that the
>> :PROPERTY: drawer must come first
>
> That's correct.
>
>> but then I tried it out and Org would gladly create a new
>> :LOGBOOK: drawer for an entry that already had a :PROPERTY:
>> drawer and place the :LOGBOOK: drawer first.
>
> That is a bug. I don't expect anything like this to happen in a
> recent Org.
I’m running 9.1.5 (20171225) and it happened, but I must have made
a mistake in my testing, because now it works.
Sorry about the noise, everything’s fine.
Best regards,
Nikolai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-31 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 20:01 Org-get-property-block can’t handle preceding drawers Nikolai Weibull
2018-01-31 20:12 ` Nicolas Goaziou
2018-01-31 20:52 ` Nikolai Weibull
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.