From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.devel Subject: xdisp.c: Suggestion to delete a few unused lines of code ... Date: Tue, 28 Apr 2020 11:46:26 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59080"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 28 20:50:14 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTVJ7-000FFr-4k for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Apr 2020 20:50:13 +0200 Original-Received: from localhost ([::1]:45074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTVJ5-0003NS-UO for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Apr 2020 14:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53044) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTVHg-0002BY-L5 for emacs-devel@gnu.org; Tue, 28 Apr 2020 14:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTVFm-000784-31 for emacs-devel@gnu.org; Tue, 28 Apr 2020 14:48:43 -0400 Original-Received: from gateway24.websitewelcome.com ([192.185.50.252]:40687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTVFl-0006nW-8q for emacs-devel@gnu.org; Tue, 28 Apr 2020 14:46:45 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 2FB385AAB for ; Tue, 28 Apr 2020 13:46:28 -0500 (CDT) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id TVFTjhRkMVQh0TVFUjp8mG; Tue, 28 Apr 2020 13:46:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FvsOyhCoZVB4fXALm/Dze2N6oTloHE4gqKYrHadrirA=; b=nEHrtAHk/HaZFpsyDeQiDsJGBo v1gQA1fAkVob7UK+q5tupNG3lzKoZIuW1qmdVdDywaQsJuXz4vGrFqcrgpUD1SXNEhV9JGTzLhfdU ecTti0N77pRCC69GhnYOzgNLUsQbLz1WI4MozremWK6dFP0eVr0U/J8kB4ffKPfmn2Ihf8DO97Du2 8OoY3VGLhXLWt/03k4A9iyNZSU3RR3RusENlEzq5XY0Moc+u2KDfQInUe/e0FAQXGIlrPHFzVI8BN +TQlsaEXbWIfZsfeKde1+ZnxHaYsC0hAYOkIqbcSYFcR5nyrGQxBJ448wPpyOJAsffMKcckEEIDhI JgMYqh3A==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:49991 helo=server.private) by gator3053.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jTVFT-000RUm-Gj for emacs-devel@gnu.org; Tue, 28 Apr 2020 13:46:27 -0500 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1jTVFT-000RUm-Gj X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.private) [45.48.239.195]:49991 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes Received-SPF: pass client-ip=192.185.50.252; envelope-from=esq@lawlist.com; helo=gateway24.websitewelcome.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/28 14:46:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 192.185.50.252 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248039 Archived-At: In the function display_line within xdisp.c, there is the following code set forth below. Inasmuch as the first main condition is whether (line_number_needed), the second test within the ELSE IF statement for whether (line_number_needed) will always be negative; i.e., it would have to be negative or else we would never have gotten to the ELSE IF statement ... since the test will always be negative, Emacs will never call maybe_produce_line_number within the ELSE IF section of this code. /* Produce line number, if needed. */ if (line_number_needed) maybe_produce_line_number (it); } else if (it->area == TEXT_AREA) { /* ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; */ /* SUGGESTED DELETION */ /* Line numbers should precede the line-prefix or wrap-prefix. */ if (line_number_needed) maybe_produce_line_number (it); /* ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; */ /* We only do this when not calling move_it_in_display_line_to above, because that function calls itself handle_line_prefix. */ handle_line_prefix (it); } else { /* Line-prefix and wrap-prefix are always displayed in the text area. But if this is the first call to display_line after init_iterator, the iterator might have been set up to write into a marginal area, e.g. if the line begins with some display property that writes to the margins. So we need to wait with the call to handle_line_prefix until whatever writes to the margin has done its job. */ pending_handle_line_prefix = true; }