bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[tastytea]

[-- Attachment #1.1: Type: text/plain, Size: 298 bytes --]

Hi,
I found a little bug in rainbow-mode 1.0.3. In c-mode and c++-mode it
colors the “#def” in #define.

Minimal init.el (assuming that rainbow-mode is installed):
(package-initialize)
(require 'rainbow-mode)

Minimal C++ example:
#define XYZ
int main() {}

Kind regards, tastytea

[-- Attachment #1.2: screenshot_rainbow_define.png --]
[-- Type: image/png, Size: 3094 bytes --]

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Lars Ingebrigtsen]

tastytea <tastytea@tastytea.de> writes:

> I found a little bug in rainbow-mode 1.0.3. In c-mode and c++-mode it
> colors the “#def” in #define.
>
> Minimal init.el (assuming that rainbow-mode is installed):
> (package-initialize)
> (require 'rainbow-mode)
>
> Minimal C++ example:
> #define XYZ
> int main() {}

I can confirm that the bug is still present in the current ELPA
package.  Perhaps Julien has some insight here?  (Cc'd.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Julien Danjou]

On Tue, Oct 27 2020, Lars Ingebrigtsen wrote:

Hi there,

> I can confirm that the bug is still present in the current ELPA
> package.  Perhaps Julien has some insight here?  (Cc'd.)

It's not a bug per say since it matches the regexp.
We just need to add even more code to avoid matching languages'
keywords.

-- 
Julien Danjou
;; Free Software hacker
;; https://julien.danjou.info

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Lars Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> It's not a bug per say since it matches the regexp.
> We just need to add even more code to avoid matching languages'
> keywords.

It seems like a more general problem to me.  That is, "#def" should be
colourized, but "#defi" should not?

So would checking for a word boundary after the regexp be sufficient?
Or are there places where #000000foobar makes sense and we really want
to colourize that #000000 bit?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Julien Danjou]

On Fri, Oct 30 2020, Lars Ingebrigtsen wrote:

> It seems like a more general problem to me.  That is, "#def" should be
> colourized, but "#defi" should not?
>
> So would checking for a word boundary after the regexp be sufficient?
> Or are there places where #000000foobar makes sense and we really want
> to colourize that #000000 bit?

It might be. It's hard to say since I don't have a good memory and there
is no unit test. :(

-- 
Julien Danjou
/* Free Software hacker
   https://julien.danjou.info */

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Lars Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

>> So would checking for a word boundary after the regexp be sufficient?
>> Or are there places where #000000foobar makes sense and we really want
>> to colourize that #000000 bit?
>
> It might be. It's hard to say since I don't have a good memory and there
> is no unit test. :(

Right.  I guess this one will just have to wait until somebody that uses
it tries such a change and sees what the results are...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> So would checking for a word boundary after the regexp be sufficient?
> Or are there places where #000000foobar makes sense and we really want
> to colourize that #000000 bit?

I've now made this change in rainbow-mode for the ^#... matches, which
should probably be correct for most things.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no