From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Help with pdumper Date: Sun, 30 Jun 2024 07:16:43 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2581"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Daniel Colascione To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 07:17:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNmw2-0000Sb-2I for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 07:17:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNmvi-0002Zz-Uw; Sun, 30 Jun 2024 01:16:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNmvg-0002ZZ-DF for emacs-devel@gnu.org; Sun, 30 Jun 2024 01:16:48 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNmve-0002JT-Ph for emacs-devel@gnu.org; Sun, 30 Jun 2024 01:16:48 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-57d280e2d5dso2250473a12.1 for ; Sat, 29 Jun 2024 22:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719724605; x=1720329405; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=OFT0/9YNxAAgzfM6FVLyK01Y5xROH3zImO+PzECN7KY=; b=VtAJ5R76nVQYC90qfEuGjgdS4WbMbi6l0Vmz7ni7pJcz1e/7iM7gxhSdxdkcqVGHSU t9o8BJSUdEeiB71SOKEMi7HH3RIUvDh8B1VgSPArzLGd739grq2maXF5kmwuUwHqUMWu G+SfuE+IG8a1oAIOdOoUW2tha0oE3aiveocDKcxx0w6PTauNli7+A1oBQlvG8J85Axdj zfAQywno4nE35T+skQwa9A1RLXnG/JN/loPhz5U5KN2I6EOwCrGyPIdF0KU/71NYP56O Bb+wQwYX8rHlWM99znBaBN2iBzFKABex+BlZnDXgQEzXo5BtsgsJ0V8DwmpR77AZcJbx mCgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719724605; x=1720329405; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OFT0/9YNxAAgzfM6FVLyK01Y5xROH3zImO+PzECN7KY=; b=hUbJGb/BTSD02LNiKhs9JU13zK7olT4nwzit+sNGM+f62kE7SP+ydc9USMk+dfLVXu YICmCoxhJP9LWB/kU8o6EF+LctiJrnnrxQwPgsJWhcpHxPp1yeQjSW4ec9MxWTLqooyi tDNC0MBb+Rmq1K0nB0AJdXcdsK60lpVQ7QlGTxpVRqDv9kJ3tYGd5fZ5EwgL8wmxi3Y7 oeqM8zOi8U13Xq4tFoFE0k5Epdo41JpGQoin5wpbP9jGPlrLErsu7pk+nG7Mm6ZbZhAJ rhuigTcZlmKBs/9KuFh0zLquGnasogrZTjT2w+77jA3NoBMwo+YzZntri2FN9nt1Tv3+ SLEw== X-Gm-Message-State: AOJu0Ywe7X9tC0vH/vUrAs2GwvHuINlTa6fuPx/3+lC+6oGqkqsMCinK sHFqjTmOiIaMvsNW7m0i5t0aYqX7jWosrJ/3jgo9JQORBH4W/xiu X-Google-Smtp-Source: AGHT+IGxePE3Et0RdD5zdWml+XU/3zn5DC5+Tk8t3xOS0wnv4CKhd7Sw1yqTjGMIpBEgUfkfEJT8dg== X-Received: by 2002:a05:6402:13c5:b0:57d:5ac:7426 with SMTP id 4fb4d7f45d1cf-5879f0c68dcmr1894892a12.9.1719724604792; Sat, 29 Jun 2024 22:16:44 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a45.dip0.t-ipconnect.de. [217.227.106.69]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5861324dca6sm2973291a12.31.2024.06.29.22.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 22:16:44 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 29 Jun 2024 15:28:47 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320913 Archived-At: Stefan Monnier writes: > +static dump_off > +dump_markers (struct dump_context *ctx, const struct Lisp_Markers *t) > +{ > + ptrdiff_t bytesize = (sizeof (struct Lisp_Markers) > + + t->size * sizeof (struct Lisp_Marker *)); > + struct Lisp_Markers *out = malloc (bytesize); > + dump_object_start (ctx, out, bytesize); > + DUMP_FIELD_COPY (out, t, size); > + DUMP_FIELD_COPY (out, t, gap_beg); > + DUMP_FIELD_COPY (out, t, gap_end); > + for (m_index_t i = 0; i < t->size; i++) > + if (t->markers[i]) > + dump_field_fixup_later (ctx, out, t, &t->markers[i]); > + dump_off offset = dump_object_finish (ctx, out, bytesize); > + free (out); > + for (m_index_t i = 0; i < t->size; i++) > + { > + struct Lisp_Marker *m = t->markers[i]; > + if (m) > + dump_remember_fixup_ptr_raw > + (ctx, > + offset + dump_offsetof (struct Lisp_Markers, markers[i]), > + dump_marker (ctx, m)); > + } > return offset; > } Is the returned offset right? I'm always forgetting this, but I thbnk the offset being returned should be where the object starts? Example from igc static dump_off dump_hash_vec (struct dump_context *ctx, const Lisp_Object array[], size_t len) { dump_align_output (ctx, DUMP_ALIGNMENT); struct dump_flags old_flags = ctx->flags; ctx->flags.pack_objects = true; #ifdef HAVE_MPS dump_igc_start_obj (ctx, IGC_OBJ_HASH_VEC, array); #endif dump_off start_offset = ctx->offset; for (size_t i = 0; i < len; i++) { Lisp_Object out; const Lisp_Object *slot = &array[i]; dump_object_start_1 (ctx, &out, sizeof out); dump_field_lv (ctx, &out, slot, slot, WEIGHT_STRONG); dump_object_finish_1 (ctx, &out, sizeof out); } ctx->flags = old_flags; #ifdef HAVE_MPS dump_igc_finish_obj (ctx); #endif return start_offset; }