* bug#71675: [PATCH] missing declaration for image_cache_refcount
@ 2024-06-20 12:17 Pankaj Jangid
2024-06-20 14:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 14:22 ` Andrea Corallo
0 siblings, 2 replies; 5+ messages in thread
From: Pankaj Jangid @ 2024-06-20 12:17 UTC (permalink / raw)
To: 71675
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Tags: patch
Build was failing on macos. Perhaps this declaration was accidently
deleted in a previous commit.
In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.5.0, NS
appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-06-20 built on
Pankajs-MacBook-Pro.local
Repository revision: 41cbfead7e2bce2f563e37a9a737a00a7b86e7f1
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description: macOS 14.5
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-missing-declaration-for-image_cache_refcount.patch --]
[-- Type: text/patch, Size: 872 bytes --]
From f823075ef4b05fa701c570885416fc7d1f628520 Mon Sep 17 00:00:00 2001
From: Pankaj Jangid <pankaj@codeisgreat.org>
Date: Thu, 20 Jun 2024 19:12:29 +0700
Subject: [PATCH] missing declaration for image_cache_refcount
* (src/nsfns.m): perhaps this was accidently deleted in a
previous commit
---
src/nsfns.m | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/nsfns.m b/src/nsfns.m
index d9c1296056c..e2c000791d0 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -86,7 +86,7 @@ Updated by Christian Limpach (chris@nice.ch)
/* Static variables to handle AppleScript execution. */
static Lisp_Object as_script, *as_result;
static int as_status;
-
+static ptrdiff_t image_cache_refcount;
static struct ns_display_info *ns_display_info_for_name (Lisp_Object);
/* ==========================================================================
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#71675: [PATCH] missing declaration for image_cache_refcount
2024-06-20 12:17 bug#71675: [PATCH] missing declaration for image_cache_refcount Pankaj Jangid
@ 2024-06-20 14:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 14:22 ` Andrea Corallo
1 sibling, 0 replies; 5+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-06-20 14:16 UTC (permalink / raw)
To: Pankaj Jangid; +Cc: 71675-done
Pankaj Jangid <pankaj@codeisgreat.org> writes:
> Tags: patch
>
> Build was failing on macos. Perhaps this declaration was accidently
> deleted in a previous commit.
No, it was rendered redundant by the deletion of some hideous code,
but the NS port was not properly adjusted for the same, which was
corrected some 30 minutes ago. Closing, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#71675: [PATCH] missing declaration for image_cache_refcount
2024-06-20 12:17 bug#71675: [PATCH] missing declaration for image_cache_refcount Pankaj Jangid
2024-06-20 14:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-20 14:22 ` Andrea Corallo
2024-07-16 3:13 ` Pankaj Jangid
1 sibling, 1 reply; 5+ messages in thread
From: Andrea Corallo @ 2024-06-20 14:22 UTC (permalink / raw)
To: Pankaj Jangid; +Cc: 71675
Pankaj Jangid <pankaj@codeisgreat.org> writes:
> Tags: patch
>
> Build was failing on macos. Perhaps this declaration was accidently
> deleted in a previous commit.
>
>
>
> In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.5.0, NS
> appkit-2487.60 Version 14.5 (Build 23F79)) of 2024-06-20 built on
> Pankajs-MacBook-Pro.local
> Repository revision: 41cbfead7e2bce2f563e37a9a737a00a7b86e7f1
> Repository branch: master
> Windowing system distributor 'Apple', version 10.3.2487
> System Description: macOS 14.5
>
>>From f823075ef4b05fa701c570885416fc7d1f628520 Mon Sep 17 00:00:00 2001
> From: Pankaj Jangid <pankaj@codeisgreat.org>
> Date: Thu, 20 Jun 2024 19:12:29 +0700
> Subject: [PATCH] missing declaration for image_cache_refcount
>
> * (src/nsfns.m): perhaps this was accidently deleted in a
> previous commit
> ---
> src/nsfns.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Pankaj,
I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
this, could you confirm?
Thanks
Andrea
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#71675: [PATCH] missing declaration for image_cache_refcount
2024-06-20 14:22 ` Andrea Corallo
@ 2024-07-16 3:13 ` Pankaj Jangid
2024-07-19 23:27 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Pankaj Jangid @ 2024-07-16 3:13 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 71675
Andrea Corallo <acorallo@gnu.org> writes:
> I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
> this, could you confirm?
Yes. This was fixed. Sorry for the delayed reply.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#71675: [PATCH] missing declaration for image_cache_refcount
2024-07-16 3:13 ` Pankaj Jangid
@ 2024-07-19 23:27 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2024-07-19 23:27 UTC (permalink / raw)
To: Pankaj Jangid, Andrea Corallo; +Cc: 71675-done
Pankaj Jangid <pankaj@codeisgreat.org> writes:
> Andrea Corallo <acorallo@gnu.org> writes:
>
>> I suspect 199fcbe2d30ff021491b345decf22024913ca40f has already fixed
>> this, could you confirm?
>
> Yes. This was fixed. Sorry for the delayed reply.
I'm therefore closing this bug report.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-19 23:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 12:17 bug#71675: [PATCH] missing declaration for image_cache_refcount Pankaj Jangid
2024-06-20 14:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 14:22 ` Andrea Corallo
2024-07-16 3:13 ` Pankaj Jangid
2024-07-19 23:27 ` Stefan Kangas
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.