bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[David Röthlisberger]

If I have ido-mode enabled, the output of `C-h k C-x C-f' is:

> C-x C-f runs the command ido-find-file, which is an interactive
> compiled Lisp function in `ido.el'.


But if I'm just learning Emacs and I do `C-h ? k C-x C-f', the output is for (non-ido) find-file:

> C-x C-f runs the command find-file, which is an interactive compiled
> Lisp function in `files.el'.


I'm not sure what causes this. `help-for-help' in `help.el' seems to use the same `help-map' that binds `C-h k' to `describe-key'; I couldn't understand the `make-help-screen' macro so that's as far as I got with my investigation.

I reproduced this on Emacs 23.3 and a 2012-01-08 nightly build of 24.0.92.1 (revno: 106821).

Recipe starting from `emacs -Q':

M-: (ido-mode t)
C-h k C-x C-f
C-h ? k C-x C-f

Thanks,
Dave.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[martin rudalics]

 > If I have ido-mode enabled, the output of `C-h k C-x C-f' is:
 >
 >> C-x C-f runs the command ido-find-file, which is an interactive
 >> compiled Lisp function in `ido.el'.
 >
 >
 > But if I'm just learning Emacs and I do `C-h ? k C-x C-f', the output is for (non-ido) find-file:
 >
 >> C-x C-f runs the command find-file, which is an interactive compiled
 >> Lisp function in `files.el'.

FWIW this is due to `make-help-screen' binding `minor-mode-map-alist' to
nil.  Applying the patch below seems to fix it, but maybe someone more
knowledgeable has a better solution.  (If you want to try the patch,
make sure to recompile help.el after compiling help-macro.el).

martin


*** lisp/help-macro.el	2011-01-25 04:08:28 +0000
--- lisp/help-macro.el	2012-01-09 18:05:39 +0000
***************
*** 186,192 ****
   			       (setq config nil))
   			     ;; `defn' must make sure that its frame is
   			     ;; selected, so we won't iconify it below.
! 			     (call-interactively defn)
   			     (when new-frame
   			       ;; Do not iconify the selected frame.
   			       (unless (eq new-frame (selected-frame))
--- 186,193 ----
   			       (setq config nil))
   			     ;; `defn' must make sure that its frame is
   			     ;; selected, so we won't iconify it below.
! 			     (let ((minor-mode-map-alist new-minor-mode-map-alist))
! 			       (call-interactively defn))
   			     (when new-frame
   			       ;; Do not iconify the selected frame.
   			       (unless (eq new-frame (selected-frame))

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[Glenn Morris]

martin rudalics wrote:

> FWIW this is due to `make-help-screen' binding `minor-mode-map-alist' to
> nil.  Applying the patch below seems to fix it, but maybe someone more
> knowledgeable has a better solution.

I'm no more knowledgeable, but it must be something to do with
minor-mode-map-alist, so FWIW if your solution makes it work I suggest
installing it and closing this.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[martin rudalics]

 > I'm no more knowledgeable, but it must be something to do with
 > minor-mode-map-alist, so FWIW if your solution makes it work I suggest
 > installing it and closing this.

Done.

martin

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[David Röthlisberger]

martin rudalics wrote:

> (If you want to try the patch, make sure to recompile help.el
> after compiling help-macro.el).

The patch doesn't work for me -- am I doing something wrong?

I'm finding "help.el.gz" by going `C-h k C-h k' and clicking on
the `help.el' link in the help buffer.

Then I open help-macro.el.gz in the same directory; apply the
patch; then
M-x byte-compile-file help-macro.el.gz
M-x byte-compile-file help.el.gz
and restart Emacs.

Thanks!
Dave.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[Andreas Schwab]

David Röthlisberger <david@rothlis.net> writes:

> Then I open help-macro.el.gz in the same directory; apply the
> patch; then
> M-x byte-compile-file help-macro.el.gz
> M-x byte-compile-file help.el.gz

You need to reload help-macro inbetween.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[David Röthlisberger]

Andreas Schwab wrote:

>> Then I open help-macro.el.gz in the same directory; apply the
>> patch; then
>> M-x byte-compile-file help-macro.el.gz
>> M-x byte-compile-file help.el.gz
> 
> You need to reload help-macro inbetween.


Good point. I have now tried that, as well as trying the following:
* Deleting help.elc & help-macro.elc altogether, then restarting Emacs
* M-x eval-buffer on help-macro.el.gz before & after byte-compiling it, then M-x eval-buffer on help.el.gz before byte-compiling it, then restarting Emacs.
* M-x load-file help-macro.el.gz before & after byte-compiling it, then M-x load-file help.el.gz before byte-compiling it, then restarting Emacs.
* Restarting Emacs after byte-compiling help-macro.el.gz, then byte-compiling help.el.gz, then restarting Emacs.

In all cases the patch still doesn't work for me.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[Glenn Morris]

David Röthlisberger wrote:

> * Deleting help.elc & help-macro.elc altogether, then restarting Emacs
> * M-x eval-buffer on help-macro.el.gz before & after byte-compiling it, then M-x eval-buffer on help.el.gz before byte-compiling it, then restarting Emacs.
> * M-x load-file help-macro.el.gz before & after byte-compiling it, then M-x load-file help.el.gz before byte-compiling it, then restarting Emacs.
> * Restarting Emacs after byte-compiling help-macro.el.gz, then byte-compiling help.el.gz, then restarting Emacs.

help.el is dumped into the Emacs image, so restarting Emacs defeats all
your good work. You either need to rebuild Emacs, or (should work),
explicitly load help-macro.el and then load help.el, then try it in the
same Emacs session.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[David Röthlisberger]

Glenn Morris wrote:

> help.el is dumped into the Emacs image, so restarting Emacs defeats all
> your good work. You either need to rebuild Emacs, or (should work),
> explicitly load help-macro.el and then load help.el, then try it in the
> same Emacs session.

Heheh, no wonder. I can now confirm that Martin's patch does work
for me. :-)

Thank you all for all your help.
Dave.

bug#10454: 23.3; Different result from `C-h k' and `C-h ? k'

[martin rudalics]

 > I can now confirm that Martin's patch does work
 > for me. :-)

Installed in revision 106895 on trunk.

 > Thank you all for all your help.

Thank you for the precise report.

martin