From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: org-review-schedule
Date: Thu, 24 Apr 2014 13:51:02 +0200 [thread overview]
Message-ID: <m2iopzdjyx.fsf@polytechnique.org> (raw)
In-Reply-To: <877g6leltk.fsf@bzg.ath.cx> (Bastien's message of "Sat, 19 Apr 2014 10:14:35 +0200")
[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]
Hi Bastien,
On 2014-04-19 10:14, Bastien <bzg@gnu.org> writes:
> Hi Alan,
>
> thanks for sharing -- some comments:
>
> - you need to update the copyright of the file;
I changed the date. As I signed the FSF paper, do I need to change the
name as well and put mine?
> - example code in section 3 of the header is mangled;
I removed that example; it should not be in the file.
> - there are some dangling parentheses;
Are those parentheses on a line by themselves? I could not find them.
> - use (get-text-property (point-min) ...) instead of
> (get-text-property 1 ...)
Changed.
> - I'd use org-review instead of org-review-schedule as prefix;
Changed.
> - maybe you can use "naked" timestamps like 2014-04-19 sam.
> instead of inactive ones, this way using "[" in the agenda
> will not create false positives by inserting entries with
> a REVIEW property.
This is now the case by default, with an option to have inactive or
active time stamps.
> - I infer from a quick read that this works for the agenda but
> I guess this could work for both the agenda and Org buffers;
It depends what "this" means ;-) My goal was to use it in an agenda
view, but most of the functionality does not depend on it.
> Since you took inspirationg from org-expiry, I guess some of
> the comments above would apply there too... feel free to hack
> into this directions for both org-expiry.el and org-review.el!
> Actually, maybe both should be merged somehow, since expiring
> is just reviewing entries to interactively delete them.
I'm still not sure where to take this ... I agree both are cases of
adding dates to entries and doing things according to those dates, but
I still need to think more about how to generalize it to cover both
cases.
I attach the new version. I would like to propose to add this to the
contrib directory, but I don't know the procedure to submit this code.
Thanks,
Alan
[-- Attachment #2: org-review.el --]
[-- Type: application/emacs-lisp, Size: 7011 bytes --]
next prev parent reply other threads:[~2014-04-25 1:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 20:27 org-review-schedule Alan Schmitt
2014-04-19 8:14 ` org-review-schedule Bastien
2014-04-19 11:16 ` org-review-schedule Alan Schmitt
2014-04-19 11:51 ` org-review-schedule Bastien
2014-04-24 11:51 ` Alan Schmitt [this message]
2014-04-25 6:51 ` org-review-schedule Nicolas Goaziou
2014-04-25 7:43 ` org-review-schedule Alan Schmitt
2014-04-25 8:02 ` org-review-schedule Nicolas Goaziou
2014-04-27 8:09 ` org-review-schedule Alan Schmitt
2014-04-28 7:20 ` org-review-schedule AW
2014-04-28 11:29 ` org-review-schedule Alan Schmitt
2014-05-06 9:27 ` org-review-schedule Bastien
2014-05-15 10:07 ` org-review-schedule Bastien
2014-05-20 12:48 ` org-review-schedule Alan Schmitt
2014-05-21 12:08 ` org-review-schedule Bastien
2014-05-21 12:58 ` org-review-schedule Alan Schmitt
2014-04-26 8:57 ` org-review-schedule Alan Schmitt
2014-04-26 10:38 ` org-review-schedule Thorsten Jolitz
2014-04-26 12:25 ` org-review-schedule Nicolas Goaziou
2014-04-27 8:08 ` org-review-schedule Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2iopzdjyx.fsf@polytechnique.org \
--to=alan.schmitt@polytechnique.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.