bug#20000: 25.0.50; auto-revert tries to install notification handler on remote files

[Filipp Gunbin <fgunbin@fastmail.fm>]

On 04/03/2015 15:04 +0100, Michael Albinus wrote:

> I don't understand. Could you, please, explain what you intend to fix?

This is the existing code:

-  (when (or (string-match auto-revert-notify-exclude-dir-regexp
-			  (expand-file-name default-directory))
-	    (file-symlink-p (or buffer-file-name default-directory)))
-    ;; Fallback to file checks.
-    (set (make-local-variable 'auto-revert-use-notify) nil))
-
-  (when (not auto-revert-notify-watch-descriptor)
-    (setq auto-revert-notify-watch-descriptor
...

So even when string-match will return non-nil (as it will with remote
files e.g. starting with "/ssh:...") we go on and set
`auto-revert-notify-watch-descriptor' which is what
`auto-revert-notify-exclude-dir-regexp' is supposed to protect us from
(if I understand it correctly).

I ran across this in this way:

1) open remote file via tramp and ssh
2) turn on global-auto-revert-mode

Tramp then asked for the password for the remote host.

Now this behaviour is gone.

Filipp