all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Danjou <julien@danjou.info>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master 3c1f421: rainbow: fix font-lock-mode refresh
Date: Sat, 07 Mar 2015 10:38:25 +0100	[thread overview]
Message-ID: <m2ioed2lm6.fsf@danjou.info> (raw)
In-Reply-To: <jwvzj7pg9n7.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Fri, 06 Mar 2015 19:16:27 -0500")

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Fri, Mar 06 2015, Stefan Monnier wrote:

Hi Stefan,

>> +    ;; Call font-lock-mode to refresh the buffer when used e.g. interactively
>> +    (font-lock-mode 1)))
>
> I'm not sure I understand why you need that.  Do you really mean that
> rainbow requires font-lock-mode to be enabled?

To work rainbow-mode needs font-lock-mode, that's for sure.
Without that change, even if font-lock-mode is activated, typing "M-x
rainbow-mode" does not refresh the buffer correctly when it's enabled or
disabled. Adding this line fixes that.

So that's the only way we found to refresh the current fontification of
a buffer with font-lock-mode. If there's a better way, let me know!

Cheers,
-- 
Julien Danjou
;; Free Software hacker
;; http://julien.danjou.info

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

  reply	other threads:[~2015-03-07  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150306160149.10234.93321@vcs.savannah.gnu.org>
     [not found] ` <E1YTuhB-0002fg-Id@vcs.savannah.gnu.org>
2015-03-07  0:16   ` [elpa] master 3c1f421: rainbow: fix font-lock-mode refresh Stefan Monnier
2015-03-07  9:38     ` Julien Danjou [this message]
2015-03-07 12:48       ` Artur Malabarba
2015-03-09  4:10         ` Stefan Monnier
2015-03-09  4:09       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ioed2lm6.fsf@danjou.info \
    --to=julien@danjou.info \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.