From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: Should we have a commit size guideline? Date: Tue, 15 Dec 2015 09:56:56 -0800 Message-ID: References: <83bn9r3cwr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1450202258 6937 80.91.229.3 (15 Dec 2015 17:57:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Dec 2015 17:57:38 +0000 (UTC) Cc: dak@gnu.org, bruce.connor.am@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 15 18:57:27 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8tqn-0008IL-PA for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 18:57:25 +0100 Original-Received: from localhost ([::1]:38518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8tqn-0003PO-7V for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 12:57:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8tqj-0003Om-Pc for emacs-devel@gnu.org; Tue, 15 Dec 2015 12:57:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8tqi-0005Z2-Qs for emacs-devel@gnu.org; Tue, 15 Dec 2015 12:57:21 -0500 Original-Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:34149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8tqb-0005Vo-V5; Tue, 15 Dec 2015 12:57:14 -0500 Original-Received: by mail-pa0-x229.google.com with SMTP id wq6so8374440pac.1; Tue, 15 Dec 2015 09:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version:content-type; bh=fBiTsXx8cVA8ZsDb5ff8uGbWK8UAWZaD69BPwDXoThY=; b=EqqLGqSOPaAwU96uHTLQg/JAtG8cW+3TNm2PGx8W2B0PbJwtAL+nj87bC+lbaIP0ln D3Xi+9QhqrxHOErnendVJire60t+DvqIC3yK9iCkZf3dcwEzG85kxeE3vhlpSBvm0Nvn dmrswPcUkH1aVsVvDjrY/XK0R93k7KVt1WfB70ywMdgw6pDX7iB7HqtBK+L+8t7T91SK q9hUBRcIMpVymOyFlJ7cgl4aXNvTUpaZHqHT10c8u3HNWJZQCvpYzCdHtIqctvl0KDbu IfauHpY+0B4LkCS77cCd+Wrfq8IOKrGyf483SnQTdYawL/M3EeapMBhk79eFp1nUeCak UIuw== X-Received: by 10.67.22.137 with SMTP id hs9mr56381804pad.66.1450202233144; Tue, 15 Dec 2015 09:57:13 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id dz6sm3640174pab.19.2015.12.15.09.57.12 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 15 Dec 2015 09:57:12 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 8E5361174BD8C; Tue, 15 Dec 2015 09:57:11 -0800 (PST) In-Reply-To: <83bn9r3cwr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Dec 2015 18:16:36 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) Mail-Followup-To: Eli Zaretskii , bruce.connor.am@gmail.com, dak@gnu.org, emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196317 Archived-At: >>>>> Eli Zaretskii writes: > I generally prefer to see the commits in one go, rather than split. It makes > it easier for me to review it. The best of both worlds should be: A commit series from a feature branch, merged into the target branch. This allows using "commit^..commit" to view all the changes in one go against the target branch, while just "commit" will show the series and it evolved on the feature branch. Rebasing the feature branch also makes this nicer to read, as it omits possibly frequent back-merges from the target into the feature branch as it was being worked on. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2