From: John Wiegley <jwiegley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dak@gnu.org, bruce.connor.am@gmail.com, emacs-devel@gnu.org
Subject: Re: Should we have a commit size guideline?
Date: Tue, 15 Dec 2015 09:56:56 -0800 [thread overview]
Message-ID: <m2io3z389j.fsf@newartisans.com> (raw)
In-Reply-To: <83bn9r3cwr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Dec 2015 18:16:36 +0200")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
> I generally prefer to see the commits in one go, rather than split. It makes
> it easier for me to review it.
The best of both worlds should be: A commit series from a feature branch,
merged into the target branch. This allows using "commit^..commit" to view all
the changes in one go against the target branch, while just "commit" will show
the series and it evolved on the feature branch.
Rebasing the feature branch also makes this nicer to read, as it omits
possibly frequent back-merges from the target into the feature branch as it
was being worked on.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2015-12-15 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 13:48 Should we have a commit size guideline? (was: builds are getting slower?) Artur Malabarba
2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
2015-12-16 11:12 ` Artur Malabarba
2015-12-15 16:16 ` Should we have a commit size guideline? (was: builds are getting slower?) Eli Zaretskii
2015-12-15 17:56 ` John Wiegley [this message]
2015-12-16 0:13 ` Should we have a commit size guideline? Paul Eggert
2015-12-16 0:23 ` Dmitry Gutov
2015-12-16 1:00 ` Paul Eggert
2015-12-16 1:19 ` indent-tabs-mode setting in Emacs's dir-locals.el Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2io3z389j.fsf@newartisans.com \
--to=jwiegley@gmail.com \
--cc=bruce.connor.am@gmail.com \
--cc=dak@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.