From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29002@debbugs.gnu.org
Subject: bug#29002: it.first_visible_x is erroneously 0 while horizontal scrolling.
Date: Sun, 29 Oct 2017 11:56:22 -0700 [thread overview]
Message-ID: <m2inex6aw9.wl%esq@lawlist.com> (raw)
In-Reply-To: <m2h8umbu0k.wl%esq@lawlist.com>
I agree ... and that leads us to bug #29002. :)
In the normal situation, the screen refreshes when the arrow key is used and non-current lines cease to be horizontally scrolled. In the current example, however, non-current lines remain horizontally scrolled and Emacs "thinks" that they are not. When I say that Emacs "thinks" they are not, I am referring to IT.
There are few ways that I look at this unique situation:
A. If the Emacs design is to permit non-current lines to remain horizontally scrolled in this unique situation, then we may need something like a new window pointer to store the value of the first-visible-x for those non-current lines.
OR
B. If the Emacs design is NOT to permit non-current lines to remain horizontally scrolled in this unique situation, then redisplay needs to refresh all non-current lines so that they snap back to a non-horizontal scroll state.
OR
C. IT is incorrect such that it.first_visible_x needs to be changed to reflect the proper value. [From an untrained eye, it looks like the value is the same as w->hscroll in this unique situation.]
If this unique situation is "a feature", then we need a way to properly calculate the first-visible-x for non-current lines. If this is *not* a feature, then redisplay should refresh all non-current lines so that they are no longer horizontally scrolled.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
DATE: [10-29-2017 11:29:16] <29 Oct 2017 20:29:16 +0200>
FROM: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Sun, 29 Oct 2017 10:29:29 -0700
> > From: Keith David Bershatsky <esq@lawlist.com>
> > Cc: 29002@debbugs.gnu.org
> >
> > Here is a link to screen-shot #3:
> >
> > https://www.lawlist.com/images/bug_hscl_03.png
> >
> > In that screen-shot, we make the following observations:
> >
> > * A total of 5 screen lines.
> >
> > * Line 1 is the current line.
> >
> > * All 5 lines visually appear to be horizontally scrolled.
> >
> > * Using the revised function bug-hscroll (below), we iterate over each screen line and generate the values for it.first_visible_x and it.vpos.
> >
> > * it.first_visible_x returns as being 0 for each of the 5 screen lines.
>
> This cannot be true: if every line in the window is hscrolled,
> first_visible_x must be non-zero, right after the call to
> start_display. If first_visible_x is zero, only the current line can
> be hscrolled.
next prev parent reply other threads:[~2017-10-29 18:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 1:03 bug#29002: it.first_visible_x is erroneously 0 while horizontal scrolling Keith David Bershatsky
2017-10-26 3:45 ` Keith David Bershatsky
2017-10-26 4:51 ` Eli Zaretskii
2017-10-26 6:20 ` Keith David Bershatsky
2017-10-26 15:56 ` Eli Zaretskii
2017-10-26 18:56 ` Keith David Bershatsky
2017-10-29 11:23 ` Eli Zaretskii
2017-10-29 17:29 ` Keith David Bershatsky
2017-10-29 18:29 ` Eli Zaretskii
2017-10-29 18:56 ` Eli Zaretskii
2017-10-29 18:56 ` Keith David Bershatsky [this message]
2017-10-29 19:23 ` Eli Zaretskii
2017-10-29 19:08 ` Keith David Bershatsky
2017-10-29 20:12 ` Keith David Bershatsky
2017-10-30 18:02 ` Eli Zaretskii
2017-10-30 19:36 ` Keith David Bershatsky
2017-11-04 9:32 ` Eli Zaretskii
2017-11-05 0:16 ` Keith David Bershatsky
2017-11-05 9:15 ` Keith David Bershatsky
2017-11-05 10:44 ` Eli Zaretskii
2017-11-05 16:59 ` Keith David Bershatsky
2017-11-05 18:12 ` Eli Zaretskii
2017-11-06 1:05 ` Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2inex6aw9.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=29002@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.